All of lore.kernel.org
 help / color / mirror / Atom feed
From: Miquel Raynal <miquel.raynal@bootlin.com>
To: Gabor Juhos <j4g8y7@gmail.com>
Cc: Richard Weinberger <richard@nod.at>,
	 Vignesh Raghavendra <vigneshr@ti.com>,
	 linux-arm-msm@vger.kernel.org, linux-mtd@lists.infradead.org,
	 linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mtd: parsers: qcom: drop setting of partition's mask_flags
Date: Mon, 12 Oct 2026 20:27:09 +0200	[thread overview]
Message-ID: <87qzhuzsea.fsf@bootlin.com> (raw)
In-Reply-To: <20261006-qcom-smempart-ignore-mask_flags-v1-1-a48d9395b21b@gmail.com> (Gabor Juhos's message of "Tue, 06 Oct 2026 22:00:41 +0200")

Hi Gabor,

On 06/10/2026 at 22:00:41 +02, Gabor Juhos <j4g8y7@gmail.com> wrote:

> The 'attr' member of struct 'smem_flash_pentry' is 8 bits wide,
> so it is only usable to mask the lower 8 bits in the MTD flags.
> However the MTD layer does not define any maskable flags in
> these bits at all. Additionally, the meaning of the bits in the
> 'attr' field is not documented, so it is not even possible to map
> those to the defined MTD flags.
>
> Due to the reasons above, remove the 'mask_flags' assignment code
> since it has no effect anyway.
>
> Signed-off-by: Gabor Juhos <j4g8y7@gmail.com>

Sorry but it no longer applies after Weigang He's:
[PATCH] mtd: parsers: qcom: fix offset/size overflow on large partitions

Thanks,
Miquèl

______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/

  reply	other threads:[~2026-10-12 18:27 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-06 20:00 [PATCH] mtd: parsers: qcom: drop setting of partition's mask_flags Gabor Juhos
2026-10-12 18:27 ` Miquel Raynal [this message]
2026-10-13  9:45   ` Gabor Juhos

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87qzhuzsea.fsf@bootlin.com \
    --to=miquel.raynal@bootlin.com \
    --cc=j4g8y7@gmail.com \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mtd@lists.infradead.org \
    --cc=richard@nod.at \
    --cc=vigneshr@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.