From: Mattijs Korpershoek <mkorpershoek@kernel.org>
To: Pengpeng Hou <pengpeng@iscas.ac.cn>, u-boot@lists.u-boot-project.org
Cc: Pengpeng Hou <pengpeng@iscas.ac.cn>,
Quentin Schulz <u-boot@0leil.net>,
Kever Yang <kever.yang@rock-chips.com>,
Simon Glass <sjg@chromium.org>, Tom Rini <trini@konsulko.com>
Subject: Re: [PATCH] fastboot: fix the RK3328 buffer-address default
Date: Mon, 07 Sep 2026 10:29:17 +0200 [thread overview]
Message-ID: <87qzj5tqg2.fsf@kernel.org> (raw)
In-Reply-To: <20260904131951.44451-1-pengpeng@iscas.ac.cn>
Hi Pengpeng,
Thank you for the patch.
On Fri, Sep 04, 2026 at 21:19, Pengpeng Hou <pengpeng@iscas.ac.cn> wrote:
> The default fastboot buffer address tests ROCKCHIP_RK3329, but U-Boot has
> no such SoC symbol. The supported SoC is ROCKCHIP_RK3328.
>
> Use the existing RK3328 symbol so custom RK3328 configurations that do
> not override FASTBOOT_BUF_ADDR receive the intended Rockchip default.
> Existing in-tree RK3328 defconfigs that set the address explicitly are
> unchanged.
>
> Fixes: 48f6232e5897 ("Kconfig: Migrate all of cmd/fastboot/Kconfig to defconfigs")
> Signed-off-by: Pengpeng Hou <pengpeng@iscas.ac.cn>
Reviewed-by: Mattijs Korpershoek <mkorpershoek@kernel.org>
> ---
> drivers/fastboot/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/fastboot/Kconfig b/drivers/fastboot/Kconfig
> index 90212fcf9ef..1887f78bcec 100644
> --- a/drivers/fastboot/Kconfig
> +++ b/drivers/fastboot/Kconfig
> @@ -57,7 +57,7 @@ config FASTBOOT_BUF_ADDR
> default 0x22000000 if ARCH_SUNXI && MACH_SUN9I
> default 0x60800800 if ROCKCHIP_RK3036 || ROCKCHIP_RK3188 || \
> ROCKCHIP_RK322X
> - default 0x800800 if ROCKCHIP_RK3288 || ROCKCHIP_RK3329 || \
> + default 0x800800 if ROCKCHIP_RK3288 || ROCKCHIP_RK3328 || \
> ROCKCHIP_RK3399
> default 0x280000 if ROCKCHIP_RK3368
> default 0x100000 if ARCH_ZYNQMP
> --
> 2.50.1 (Apple Git-155)
prev parent reply other threads:[~2026-09-07 8:29 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-04 13:19 [PATCH] fastboot: fix the RK3328 buffer-address default Pengpeng Hou
2026-09-07 8:29 ` Mattijs Korpershoek [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87qzj5tqg2.fsf@kernel.org \
--to=mkorpershoek@kernel.org \
--cc=kever.yang@rock-chips.com \
--cc=pengpeng@iscas.ac.cn \
--cc=sjg@chromium.org \
--cc=trini@konsulko.com \
--cc=u-boot@0leil.net \
--cc=u-boot@lists.u-boot-project.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.