From: "Alex Bennée" <alex.bennee@linaro.org>
To: Anthony Roberts <anthony.roberts@linaro.org>
Cc: qemu-devel@nongnu.org, "Marc-André Lureau" <marcandre.lureau@redhat.com>
Subject: Re: [PATCH] ui/sdl2: Fix assumption of EGL presence at runtime
Date: Thu, 09 Apr 2026 13:08:37 +0100 [thread overview]
Message-ID: <87qzoo9vzu.fsf@draig.linaro.org> (raw)
In-Reply-To: <20260409110256.684-1-anthony.roberts@linaro.org> (Anthony Roberts's message of "Thu, 9 Apr 2026 12:02:55 +0100")
Anthony Roberts <anthony.roberts@linaro.org> writes:
> The original commit had a section of code which worked on the assumption
> that if OpenGL was enabled at build, it was present on the end user machine,
> and calls could be made to it. This is not always the case (such as Windows
> on Arm devices).
>
> This line should have also included a runtime check.
>
> This commit moves the relevant line to inside a runtime check for OpenGL.
>
> Fixes: 52053b7e0a0e ("ui/sdl2: Implement dpy dmabuf functions")
> Resolves: https://gitlab.com/qemu-project/qemu/-/work_items/3347
> Signed-off-by: Anthony Roberts <anthony.roberts@linaro.org>
Reviewed-by: Alex Bennée <alex.bennee@linaro.org>
--
Alex Bennée
Virtualisation Tech Lead @ Linaro
next prev parent reply other threads:[~2026-04-09 12:09 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-09 11:02 [PATCH] ui/sdl2: Fix assumption of EGL presence at runtime Anthony Roberts
2026-04-09 12:08 ` Alex Bennée [this message]
2026-04-09 12:21 ` Mohamed Mediouni
2026-04-09 13:22 ` Alex Bennée
2026-04-09 20:18 ` Peter Maydell
2026-04-17 16:47 ` Alex Bennée
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87qzoo9vzu.fsf@draig.linaro.org \
--to=alex.bennee@linaro.org \
--cc=anthony.roberts@linaro.org \
--cc=marcandre.lureau@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.