From: Thomas Gleixner <tglx@linutronix.de>
To: Ioana Ciornei <ioana.ciornei@nxp.com>,
Ulf Hansson <ulf.hansson@linaro.org>,
Geert Uytterhoeven <geert+renesas@glider.be>,
Johan Hovold <johan+linaro@kernel.org>,
"Rafael J. Wysocki" <rafael@kernel.org>,
"Rob Herring (Arm)" <robh@kernel.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Alexander Stein <alexander.stein@ew.tq-group.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 1/2] irqchip/ls-extirq: convert to a platform driver
Date: Fri, 12 Dec 2025 10:24:19 +0900 [thread overview]
Message-ID: <87qzt0eblo.ffs@tglx> (raw)
In-Reply-To: <20251205155735.2366732-2-ioana.ciornei@nxp.com>
On Fri, Dec 05 2025 at 17:57, Ioana Ciornei wrote:
> Since there is no need for ls-extirq to be initialized early, convert it
> to a proper platform driver. Instead of using IRQCHIP_DECLARE, add an
> of_device_id array with the same compatible strings as before. Also
> change the prototype and name of the probe function and adjust it to a
> platform_device structure.
>
> With this change we also have the added advantage of avoiding the
> irqchip_init() -> of_irq_init() code path which imposes dt checks that
> the ls-extirq does not comply with because of its improper use of the
> interrupt-map property.
>
> Fixes: 1b1f04d8271e ("of/irq: Ignore interrupt parent for nodes without interrupts")
I'm not seeing how that Fixes tag is related. Your changelog clearly
lacks a proper explanation.
Aside of that there is this series:
https://lore.kernel.org/20251201105144.539450-1-alexander.stein@ew.tq-group.com
which is way more complete and cleans up the thing nicely instead of
just converting it to a platform driver with minimal effort.
Thanks,
tglx
next prev parent reply other threads:[~2025-12-12 1:24 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-12-05 15:57 [PATCH v2 0/2] irqchip: convert ls-extirq to a platform driver Ioana Ciornei
2025-12-05 15:57 ` [PATCH v2 1/2] irqchip/ls-extirq: convert " Ioana Ciornei
2025-12-12 1:24 ` Thomas Gleixner [this message]
2025-12-12 9:51 ` Alexander Stein
2025-12-12 14:17 ` Ioana Ciornei
2025-12-12 14:54 ` Alexander Stein
2025-12-12 14:13 ` Ioana Ciornei
2025-12-05 15:57 ` [PATCH v2 2/2] bus: simple-pm-bus: probe the Layerscape SCFG node Ioana Ciornei
2026-01-13 15:33 ` [PATCH v2 0/2] irqchip: convert ls-extirq to a platform driver Vladimir Oltean
2026-01-13 18:36 ` Thomas Gleixner
2026-01-13 18:43 ` Vladimir Oltean
2026-01-13 20:20 ` Thomas Gleixner
2026-01-14 12:00 ` Ioana Ciornei
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87qzt0eblo.ffs@tglx \
--to=tglx@linutronix.de \
--cc=alexander.stein@ew.tq-group.com \
--cc=geert+renesas@glider.be \
--cc=gregkh@linuxfoundation.org \
--cc=ioana.ciornei@nxp.com \
--cc=johan+linaro@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rafael@kernel.org \
--cc=robh@kernel.org \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.