From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 44D47D3B7DD for ; Mon, 8 Dec 2025 08:52:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-ID:Date:References :In-Reply-To:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=QknrOWZqpYyWlOT1VCNvHzU+ZF7ZHXnTJIgYnZssOUM=; b=DAvHdFoe1HN+Zm yGyatXexm965wSueiLV0IptUDL/AJaVILO1+Fz2OJARK1Z+lL5gAFZCD9Cd4LNzcKZamE/okz3Szb qeO1yfDxohumpM4dvqf46pXGJpsp/NwhQLBITWUyiQ4ta40QkHamxJ/obfv0lA9bzH16tHZlDa5NI zyAI5SiorRA5QbZ62NrAbI3ZrqdhnzR/hPzmZFeq2WbeMIO2Ks++/+BMgR3QU2JGQlVFBGYHTOGq5 xOJTeEh/MWT5KaSrvjX42C76QtuwaDsUe1LrY416ArDu0gxDDFGq50tgN8enrH/J2mU8UedVgjj2W pSxNsj2vpvoT9SHTwHpQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1vSWym-0000000Cppw-2O4k; Mon, 08 Dec 2025 08:52:24 +0000 Received: from smtpout-02.galae.net ([185.246.84.56]) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1vSWyi-0000000CppV-3zy2 for linux-mtd@lists.infradead.org; Mon, 08 Dec 2025 08:52:22 +0000 Received: from smtpout-01.galae.net (smtpout-01.galae.net [212.83.139.233]) by smtpout-02.galae.net (Postfix) with ESMTPS id 42FC21A201B for ; Mon, 8 Dec 2025 08:52:18 +0000 (UTC) Received: from mail.galae.net (mail.galae.net [212.83.136.155]) by smtpout-01.galae.net (Postfix) with ESMTPS id 17F7F60707; Mon, 8 Dec 2025 08:52:18 +0000 (UTC) Received: from [127.0.0.1] (localhost [127.0.0.1]) by localhost (Mailerdaemon) with ESMTPSA id 994FC102F0D51; Mon, 8 Dec 2025 09:52:16 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=dkim; t=1765183937; h=from:subject:date:message-id:to:cc:mime-version:content-type: content-transfer-encoding:in-reply-to:references; bh=8hGarfSPljfdjvvaFqnVE6KI08H7h3+flngId20ZoOg=; b=Fe+3Ipk8XpKTyI1kzQRBgTJwr7ch6Fv7jLuiFuJP6/PjbFojHF7XZ650hakTQ81UQ213Ex kfnOjCHsXziVsUfsku+1gxx57axv1/whHQ7KYMCj+EuEAkNmzcSdVkmIJMux0Kp8qzpHew c8QF0xIiAbabh/QFOvTICf5p51yI6tCBd6GFCDu6O0MN6eL7eFj5CVaZE3vlozvlUnahyq fubhQPB/E17eCXqJko0mx6QjNNrbnITYhPOgABz0VZ0tFt9Oe04tkUDYgb/7UOR0zrkl34 tDYxbZs8jOOaq+g+GJQqngMMg4v8VDXLhuRhPRt1p9nrOhdfRGkqUD+GEF2irg== From: Miquel Raynal To: Ahmed Naseef Cc: Richard Weinberger , Vignesh Raghavendra , linux-kernel@vger.kernel.org, linux-mtd@lists.infradead.org Subject: Re: [PATCH] mtd: spinand: add support for Dosilicon DS35Q1GA/DS35M1GA In-Reply-To: <20251207150923.86328-1-naseefkm@gmail.com> (Ahmed Naseef's message of "Sun, 7 Dec 2025 19:09:20 +0400") References: <20251207150923.86328-1-naseefkm@gmail.com> User-Agent: mu4e 1.12.7; emacs 30.2 Date: Mon, 08 Dec 2025 09:52:15 +0100 Message-ID: <87qzt573uo.fsf@bootlin.com> MIME-Version: 1.0 X-Last-TLS-Session-Version: TLSv1.3 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20251208_005221_127801_4E88F073 X-CRM114-Status: GOOD ( 10.38 ) X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-mtd" Errors-To: linux-mtd-bounces+linux-mtd=archiver.kernel.org@lists.infradead.org SGkgQWhtZWQsIHRoYW5rcyBmb3IgdGhpcyBjb250cmlidXRpb24uCgo+ICtzdGF0aWMgU1BJTkFO RF9PUF9WQVJJQU5UUyhyZWFkX2NhY2hlX3ZhcmlhbnRzLAo+ICsJCVNQSU5BTkRfUEFHRV9SRUFE X0ZST01fQ0FDSEVfWDRfT1AoMCwgMSwgTlVMTCwgMCksCj4gKwkJU1BJTkFORF9QQUdFX1JFQURf RlJPTV9DQUNIRV9YMl9PUCgwLCAxLCBOVUxMLCAwKSwKPiArCQlTUElOQU5EX1BBR0VfUkVBRF9G Uk9NX0NBQ0hFX09QKHRydWUsIDAsIDEsIE5VTEwsIDApLAo+ICsJCVNQSU5BTkRfUEFHRV9SRUFE X0ZST01fQ0FDSEVfT1AoZmFsc2UsIDAsIDEsIE5VTEwsIDApKTsKClRoZXNlIG1hY3JvcyBoYXZl IGJlZW4gcmVuYW1lZCwgcGxlYXNlIHJlYmFzZSBhdCAtcmMxLgoKPiArCj4gK3N0YXRpYyBTUElO QU5EX09QX1ZBUklBTlRTKHdyaXRlX2NhY2hlX3ZhcmlhbnRzLAo+ICsJCVNQSU5BTkRfUFJPR19M T0FEX1g0KHRydWUsIDAsIE5VTEwsIDApLAo+ICsJCVNQSU5BTkRfUFJPR19MT0FEKHRydWUsIDAs IE5VTEwsIDApKTsKPiArCj4gK3N0YXRpYyBTUElOQU5EX09QX1ZBUklBTlRTKHVwZGF0ZV9jYWNo ZV92YXJpYW50cywKPiArCQlTUElOQU5EX1BST0dfTE9BRF9YNChmYWxzZSwgMCwgTlVMTCwgMCks Cj4gKwkJU1BJTkFORF9QUk9HX0xPQUQoZmFsc2UsIDAsIE5VTEwsIDApKTsKPiArCj4gK3N0YXRp YyBpbnQgZHMzNXh4X29vYmxheW91dF9lY2Moc3RydWN0IG10ZF9pbmZvICptdGQsIGludCBzZWN0 aW9uLAo+ICsJCQkJc3RydWN0IG10ZF9vb2JfcmVnaW9uICpyZWdpb24pCj4gK3sKPiArCXJldHVy biAtRVJBTkdFOwo+ICt9CgpUaGlzIGlzIHN0cmFuZ2UsIHRoZXJlIGlzIHVzdWFsbHkgc29tZSBz cGFyZSBhcmVhIHVzZWQgZm9yIHN0b3JpbmcgdGhlCkVDQy4gQXJlIHlvdSBzdXJlIG5vbmUgb2Yg dGhlIGJ5dGVzIGluIHRoZSBzcGFyZSBhcmVhIGFyZSBiZWluZyBzbWFzaGVkCndoZW4geW91IHdy aXRlIHRoZW0/Cgo+ICtzdGF0aWMgaW50IGRzMzV4eF9vb2JsYXlvdXRfZnJlZShzdHJ1Y3QgbXRk X2luZm8gKm10ZCwgaW50IHNlY3Rpb24sCj4gKwkJCQkgc3RydWN0IG10ZF9vb2JfcmVnaW9uICpy ZWdpb24pCj4gK3sKPiArCWlmIChzZWN0aW9uKQo+ICsJCXJldHVybiAtRVJBTkdFOwo+ICsJcmVn aW9uLT5vZmZzZXQgPSAyOwo+ICsJcmVnaW9uLT5sZW5ndGggPSA2MjsKPiArCXJldHVybiAwOwo+ ICt9Cj4gKwoKTEdUTSBvdGhlcndpc2UuCgpUaGFua3MsCk1pcXXDqGwKCl9fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpMaW51eCBNVEQgZGlzY3Vz c2lvbiBtYWlsaW5nIGxpc3QKaHR0cDovL2xpc3RzLmluZnJhZGVhZC5vcmcvbWFpbG1hbi9saXN0 aW5mby9saW51eC1tdGQvCg== From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtpout-04.galae.net (smtpout-04.galae.net [185.171.202.116]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C934E29A322 for ; Mon, 8 Dec 2025 08:52:19 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.171.202.116 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765183943; cv=none; b=gtK4e/XeKKrj2GNgjiggV2c/Iy365BjYYbN5W5uiE5VieokTp5Mt8uHqpmj2TN3MkUalzWGdkGq/PH0Z/cWcvGrRI7b97kjVvAasdvgos5DUb7Uao/CCHAQsKDOtY6msIgJgyqTKvb1fqvc7vwVT1KQ1L5vqwxuZ7yqmK/WRTzQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765183943; c=relaxed/simple; bh=vLRfOCJc4nOF5GNCA/WxSk2dG3J63uLUCrbeIZ6cYCc=; h=From:To:Cc:Subject:In-Reply-To:References:Date:Message-ID: MIME-Version:Content-Type; b=RKiEkXJDU0/IlNhxPlMxEtvKcXneNB3KgXMzenTs+HUtTBqZ9+PdhcKcLKor6vg17u/EfAOhHSPeQp7utbn3iyXTCJYMqRDieue2QF9TF/a0a6B8fbBXTvaB2SAWuW71IqRO6JslELXsjnaXCFVABWVFkGUaiGECdZROyCK9JJU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com; spf=pass smtp.mailfrom=bootlin.com; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b=Fe+3Ipk8; arc=none smtp.client-ip=185.171.202.116 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=bootlin.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b="Fe+3Ipk8" Received: from smtpout-01.galae.net (smtpout-01.galae.net [212.83.139.233]) by smtpout-04.galae.net (Postfix) with ESMTPS id 64A02C1018A; Mon, 8 Dec 2025 08:51:54 +0000 (UTC) Received: from mail.galae.net (mail.galae.net [212.83.136.155]) by smtpout-01.galae.net (Postfix) with ESMTPS id 17F7F60707; Mon, 8 Dec 2025 08:52:18 +0000 (UTC) Received: from [127.0.0.1] (localhost [127.0.0.1]) by localhost (Mailerdaemon) with ESMTPSA id 994FC102F0D51; Mon, 8 Dec 2025 09:52:16 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=dkim; t=1765183937; h=from:subject:date:message-id:to:cc:mime-version:content-type: content-transfer-encoding:in-reply-to:references; bh=8hGarfSPljfdjvvaFqnVE6KI08H7h3+flngId20ZoOg=; b=Fe+3Ipk8XpKTyI1kzQRBgTJwr7ch6Fv7jLuiFuJP6/PjbFojHF7XZ650hakTQ81UQ213Ex kfnOjCHsXziVsUfsku+1gxx57axv1/whHQ7KYMCj+EuEAkNmzcSdVkmIJMux0Kp8qzpHew c8QF0xIiAbabh/QFOvTICf5p51yI6tCBd6GFCDu6O0MN6eL7eFj5CVaZE3vlozvlUnahyq fubhQPB/E17eCXqJko0mx6QjNNrbnITYhPOgABz0VZ0tFt9Oe04tkUDYgb/7UOR0zrkl34 tDYxbZs8jOOaq+g+GJQqngMMg4v8VDXLhuRhPRt1p9nrOhdfRGkqUD+GEF2irg== From: Miquel Raynal To: Ahmed Naseef Cc: Richard Weinberger , Vignesh Raghavendra , linux-kernel@vger.kernel.org, linux-mtd@lists.infradead.org Subject: Re: [PATCH] mtd: spinand: add support for Dosilicon DS35Q1GA/DS35M1GA In-Reply-To: <20251207150923.86328-1-naseefkm@gmail.com> (Ahmed Naseef's message of "Sun, 7 Dec 2025 19:09:20 +0400") References: <20251207150923.86328-1-naseefkm@gmail.com> User-Agent: mu4e 1.12.7; emacs 30.2 Date: Mon, 08 Dec 2025 09:52:15 +0100 Message-ID: <87qzt573uo.fsf@bootlin.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Last-TLS-Session-Version: TLSv1.3 Hi Ahmed, thanks for this contribution. > +static SPINAND_OP_VARIANTS(read_cache_variants, > + SPINAND_PAGE_READ_FROM_CACHE_X4_OP(0, 1, NULL, 0), > + SPINAND_PAGE_READ_FROM_CACHE_X2_OP(0, 1, NULL, 0), > + SPINAND_PAGE_READ_FROM_CACHE_OP(true, 0, 1, NULL, 0), > + SPINAND_PAGE_READ_FROM_CACHE_OP(false, 0, 1, NULL, 0)); These macros have been renamed, please rebase at -rc1. > + > +static SPINAND_OP_VARIANTS(write_cache_variants, > + SPINAND_PROG_LOAD_X4(true, 0, NULL, 0), > + SPINAND_PROG_LOAD(true, 0, NULL, 0)); > + > +static SPINAND_OP_VARIANTS(update_cache_variants, > + SPINAND_PROG_LOAD_X4(false, 0, NULL, 0), > + SPINAND_PROG_LOAD(false, 0, NULL, 0)); > + > +static int ds35xx_ooblayout_ecc(struct mtd_info *mtd, int section, > + struct mtd_oob_region *region) > +{ > + return -ERANGE; > +} This is strange, there is usually some spare area used for storing the ECC. Are you sure none of the bytes in the spare area are being smashed when you write them? > +static int ds35xx_ooblayout_free(struct mtd_info *mtd, int section, > + struct mtd_oob_region *region) > +{ > + if (section) > + return -ERANGE; > + region->offset =3D 2; > + region->length =3D 62; > + return 0; > +} > + LGTM otherwise. Thanks, Miqu=C3=A8l