Re: [dovetail 6.1.y-cip][PATCH 3/3] arm64: fpsimd: dovetail: Drop extra condition from WARN_ON

[Philippe Gerum <rpm@xenomai.org>]

Philippe Gerum <rpm@xenomai.org> writes:

> Jan Kiszka <jan.kiszka@siemens.com> writes:
>
>> From: Jan Kiszka <jan.kiszka@siemens.com>
>>
>> There is no indication that this function is called over oob context as
>> well, and newer dovetail versions do not carry this extra condition
>> anymore.
>>
>
> Depends on whether patch 2/3 is actually correct.

1/3, not 2/3.

>
>> Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
>> ---
>>  arch/arm64/kernel/fpsimd.c | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/arch/arm64/kernel/fpsimd.c b/arch/arm64/kernel/fpsimd.c
>> index f915706332191..ed269edea7907 100644
>> --- a/arch/arm64/kernel/fpsimd.c
>> +++ b/arch/arm64/kernel/fpsimd.c
>> @@ -1950,7 +1950,7 @@ void fpsimd_save_and_flush_cpu_state(void)
>>  {
>>  	if (!system_supports_fpsimd())
>>  		return;
>> -	WARN_ON(!hard_irqs_disabled() && preemptible());
>> +	WARN_ON(preemptible());
>>  	get_cpu_fpsimd_context();
>>  	__fpsimd_save();
>>  	fpsimd_flush_cpu_state();

-- 
Philippe.