From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from galois.linutronix.de (Galois.linutronix.de [193.142.43.55]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4905D2DE6F7; Mon, 21 Jul 2025 15:20:43 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=193.142.43.55 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1753111244; cv=none; b=XPp49NC9tCOStJw0B/lcoRxRMEly0k5gbTNoemMsV/P5nwjEJBPojjS1flTBWw4oqAkRLIZgaSp+Y8eKa+zOhFDfgsQXTm8IbZP2Qc8gZ9hRxPws1/+VLxt2PEXkCDd1pz31hWKJriNunBsZFxD8Q1nXuYYjkW2OthssYtliOA8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1753111244; c=relaxed/simple; bh=EKv/CuvVWTqGB+3lPgiI/Kb5dtzwxeNfNXJbovQpa9I=; h=From:To:Cc:Subject:In-Reply-To:References:Date:Message-ID: MIME-Version:Content-Type; b=u6ERqfSYS+M2Hr+gosEj3fsCnnnHf6SisTSvhGLuB8eaD+AJPSHeAW6A9CTnz8SzgQMFzxZAfUao/tyb3TR9cX2wdb1Y1vo80JPGw6ilLi7AdJqsi5EozFZKrjFVgVS00awF3tuFW0GN0gVpi10jMtvDm0+qchxye6fJEtUsJI0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linutronix.de; spf=pass smtp.mailfrom=linutronix.de; dkim=pass (2048-bit key) header.d=linutronix.de header.i=@linutronix.de header.b=dSUpea09; dkim=permerror (0-bit key) header.d=linutronix.de header.i=@linutronix.de header.b=Q0GGv108; arc=none smtp.client-ip=193.142.43.55 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linutronix.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linutronix.de Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linutronix.de header.i=@linutronix.de header.b="dSUpea09"; dkim=permerror (0-bit key) header.d=linutronix.de header.i=@linutronix.de header.b="Q0GGv108" From: Thomas Gleixner DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1753111241; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=/9FzCqmcyJh+8Ydz6tHP0relc2+nn3FdzXGKT9u9tC0=; b=dSUpea09yTKvaap84BHTchrX/mvRMJUc48+kcHHkQxoYAlMq1o9H91n0rEyouWUQZds+Ls rJWeBKpdVh+r6TVg9PcQPcuj0sZz+kTaDMsLK4KCjaOjlWQYgv4f4R/F/uiKtEsxW6IPu8 BZs7DYrF+ZLrdRacfIavNLPjVeum/qGXpUL0kBgehfj92Ae5GBzPEau0pmYMGKZYiMUTmA WBzzEbBwXCWSUfsni3ElVs+D8g26iSUsJ/++lpGRihfVxdZY1aFI35kcEgLVtGeA+2qJTV JIM9YCZ9KB6Tup50FIIXZa38Dsi7uKFBiXUKjNhkEMalmJWrVmGFGCj4lmFI7A== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1753111241; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=/9FzCqmcyJh+8Ydz6tHP0relc2+nn3FdzXGKT9u9tC0=; b=Q0GGv108K0Wx0ZlG5G8V8V0Na3jr3eUG3hFHWm0zuYoWeHBjtZZPu1Oy3mIu6+M+ntdxcb YsPYlYqxSgIstBDQ== To: panchuang , Miquel Raynal Cc: =?utf-8?B?5p2O5oms6Z+s?= , Uwe =?utf-8?Q?Kleine-K?= =?utf-8?Q?=C3=B6nig?= , "Rafael J. Wysocki" , Daniel Lezcano , Zhang Rui , Lukasz Luba , Markus Mayer , Broadcom internal kernel review list , Florian Fainelli , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , zhanghongchen , Yinbo Zhu , Amit Kucheria , Thara Gopinath , Niklas =?utf-8?Q?S=C3=B6derlund?= , Geert Uytterhoeven , Magnus Damm , Heiko Stuebner , Bartlomiej Zolnierkiewicz , Krzysztof Kozlowski , Alim Akhtar , Maxime Coquelin , Alexandre Torgue , Vasily Khoruzhick , Yangtao Li , Chen-Yu Tsai , Jernej Skrabec , Samuel Holland , Thierry Reding , Jonathan Hunter , Kunihiko Hayashi , Masami Hiramatsu , Matthias Brugger , AngeloGioacchino Del Regno , Srinivas Pandruvada , Greg KH , Peter Zijlstra , =?utf-8?Q?N=C3=ADcolas_F=2E_R=2E_A=2E_Prado?= , Conor Dooley , Julien Panis , Arnd Bergmann , Uwe =?utf-8?Q?Kleine-K=C3=B6nig?= , Colin Ian King , Raphael Gallais-Pou , Patrice Chotard , Jonathan Cameron , "Jiri Slaby (SUSE)" , Sebastian Andrzej Siewior , Andrew Morton , Costa Shulyupin , Yury Norov , Cheng-Yang Chou , Caleb Sander Mateos , "linux-pm@vger.kernel.org" , LKML , "linux-arm-kernel@lists.infradead.org" , "imx@lists.linux.dev" , "linux-arm-msm@vger.kernel.org" , "linux-renesas-soc@vger.kernel.org" , "linux-rockchip@lists.infradead.org" , "linux-samsung-soc@vger.kernel.org" , "linux-stm32@st-md-mailman.stormreply.com" , "linux-sunxi@lists.linux.dev" , "linux-tegra@vger.kernel.org" , "linux-mediatek@lists.infradead.org" Subject: Re: =?utf-8?B?5Zue5aSNOg==?= [PATCH v6 01/24] genirq/devres: Add devm_request_threaded_irq_probe() and devm_request_irq_probe() In-Reply-To: References: Date: Mon, 21 Jul 2025 17:20:39 +0200 Message-ID: <87qzy9tvso.ffs@tglx> Precedence: bulk X-Mailing-List: imx@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On Sat, Jul 19 2025 at 23:08, Thomas Gleixner wrote: > On Wed, Jul 09 2025 at 17:13, panchuang@vivo.com wrote: >> Hi tglx and Miqu=C3=A8l, Just a gentle ping on this patchset. I understa= nd=20 >> you're likely busy with many other tasks, but any feedback or guidance=20 >> on how to proceed would be greatly appreciated. As discussed in the=20 >> previous thread, there was some uncertainty about whether we should=20 >> directly integrate dev_err_probe() into devm_request_threaded_irq(), or= =20 >> if it's better to create a wrapper function. Thanks for your time!=20 >> Thanks, Panchuang For simplicity sake just rename the existing functions devm_request_threaded_irq() and devm_request_any_context_irq() to __devm_request_threaded_irq() and __devm_request_any_context_irq(). Then create new functions for the API, which - invoke the underscore variants - and on error invoke dev_err_probe() similar to what I suggested in my reply in this thread. In the rare case of failure, this will print error messages for the affected drivers both in the core and at the callsite, but that's not the end of the world. Then go and remove the random printks from the drivers, once the core change has hit upstream. Thanks, tglx From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 9D404CCD1A5 for ; Mon, 20 Oct 2025 12:17:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-ID:Date:References :In-Reply-To:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=wT+l6g+m9Xx0KxmOlstRdRZk+Z7GaQqt9kDMHBvjtPQ=; b=xAAegY+clIAYO9 mLIccKY1p0BJrF2H+Z4B/AD+lEI6EB5N8AIouQRnnOgZ8JxSUedS1P0gp9oAXLduLNmoXnSGMXARh Fg6kGZ3KLsdRQjEpOln2CKsiVhVLl8SjhshwIHxQSXHAWcAYEJcgpHXLMbN7vy23gZA+hXxxJzMpt eo+R+oK/q6aQvtQtHSdh00r/Fxf3ox4u17carTC4/0k+kTkzCi51+kGfQ4y66ffhVFpzaflpGVdRL K1zaTWU0JxbAxR2Dbh7toNHDsIHNqYIG0DRMn4Dn098x1uQAGtnNiYngZyWeDGnaGveMGG9AiIdFb 9vVnkj/P6gvjIunbJ7qA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1vAoox-0000000DMdW-4Bsu; Mon, 20 Oct 2025 12:17:04 +0000 Received: from galois.linutronix.de ([193.142.43.55]) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1udsJo-000000003mB-49gQ; Mon, 21 Jul 2025 15:20:46 +0000 From: Thomas Gleixner DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1753111241; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=/9FzCqmcyJh+8Ydz6tHP0relc2+nn3FdzXGKT9u9tC0=; b=dSUpea09yTKvaap84BHTchrX/mvRMJUc48+kcHHkQxoYAlMq1o9H91n0rEyouWUQZds+Ls rJWeBKpdVh+r6TVg9PcQPcuj0sZz+kTaDMsLK4KCjaOjlWQYgv4f4R/F/uiKtEsxW6IPu8 BZs7DYrF+ZLrdRacfIavNLPjVeum/qGXpUL0kBgehfj92Ae5GBzPEau0pmYMGKZYiMUTmA WBzzEbBwXCWSUfsni3ElVs+D8g26iSUsJ/++lpGRihfVxdZY1aFI35kcEgLVtGeA+2qJTV JIM9YCZ9KB6Tup50FIIXZa38Dsi7uKFBiXUKjNhkEMalmJWrVmGFGCj4lmFI7A== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1753111241; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=/9FzCqmcyJh+8Ydz6tHP0relc2+nn3FdzXGKT9u9tC0=; b=Q0GGv108K0Wx0ZlG5G8V8V0Na3jr3eUG3hFHWm0zuYoWeHBjtZZPu1Oy3mIu6+M+ntdxcb YsPYlYqxSgIstBDQ== To: panchuang , Miquel Raynal Cc: =?utf-8?B?5p2O5oms6Z+s?= , Uwe =?utf-8?Q?Kleine-K?= =?utf-8?Q?=C3=B6nig?= , "Rafael J. Wysocki" , Daniel Lezcano , Zhang Rui , Lukasz Luba , Markus Mayer , Broadcom internal kernel review list , Florian Fainelli , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , zhanghongchen , Yinbo Zhu , Amit Kucheria , Thara Gopinath , Niklas =?utf-8?Q?S=C3=B6derlund?= , Geert Uytterhoeven , Magnus Damm , Heiko Stuebner , Bartlomiej Zolnierkiewicz , Krzysztof Kozlowski , Alim Akhtar , Maxime Coquelin , Alexandre Torgue , Vasily Khoruzhick , Yangtao Li , Chen-Yu Tsai , Jernej Skrabec , Samuel Holland , Thierry Reding , Jonathan Hunter , Kunihiko Hayashi , Masami Hiramatsu , Matthias Brugger , AngeloGioacchino Del Regno , Srinivas Pandruvada , Greg KH , Peter Zijlstra , =?utf-8?Q?N=C3=ADcolas_F=2E_R=2E_A=2E_Prado?= , Conor Dooley , Julien Panis , Arnd Bergmann , Uwe =?utf-8?Q?Kleine-K=C3=B6nig?= , Colin Ian King , Raphael Gallais-Pou , Patrice Chotard , Jonathan Cameron , "Jiri Slaby (SUSE)" , Sebastian Andrzej Siewior , Andrew Morton , Costa Shulyupin , Yury Norov , Cheng-Yang Chou , Caleb Sander Mateos , "linux-pm@vger.kernel.org" , LKML , "linux-arm-kernel@lists.infradead.org" , "imx@lists.linux.dev" , "linux-arm-msm@vger.kernel.org" , "linux-renesas-soc@vger.kernel.org" , "linux-rockchip@lists.infradead.org" , "linux-samsung-soc@vger.kernel.org" , "linux-stm32@st-md-mailman.stormreply.com" , "linux-sunxi@lists.linux.dev" , "linux-tegra@vger.kernel.org" , "linux-mediatek@lists.infradead.org" Subject: Re: =?utf-8?B?5Zue5aSNOg==?= [PATCH v6 01/24] genirq/devres: Add devm_request_threaded_irq_probe() and devm_request_irq_probe() In-Reply-To: References: Date: Mon, 21 Jul 2025 17:20:39 +0200 Message-ID: <87qzy9tvso.ffs@tglx> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250721_082045_169405_EB13E51A X-CRM114-Status: GOOD ( 14.08 ) X-Mailman-Approved-At: Mon, 20 Oct 2025 05:16:55 -0700 X-BeenThere: linux-rockchip@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Upstream kernel work for Rockchip platforms List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "Linux-rockchip" Errors-To: linux-rockchip-bounces+linux-rockchip=archiver.kernel.org@lists.infradead.org T24gU2F0LCBKdWwgMTkgMjAyNSBhdCAyMzowOCwgVGhvbWFzIEdsZWl4bmVyIHdyb3RlOgo+IE9u IFdlZCwgSnVsIDA5IDIwMjUgYXQgMTc6MTMsIHBhbmNodWFuZ0B2aXZvLmNvbSB3cm90ZToKPj4g SGkgdGdseCBhbmQgTWlxdcOobCwgSnVzdCBhIGdlbnRsZSBwaW5nIG9uIHRoaXMgcGF0Y2hzZXQu IEkgdW5kZXJzdGFuZCAKPj4geW91J3JlIGxpa2VseSBidXN5IHdpdGggbWFueSBvdGhlciB0YXNr cywgYnV0IGFueSBmZWVkYmFjayBvciBndWlkYW5jZSAKPj4gb24gaG93IHRvIHByb2NlZWQgd291 bGQgYmUgZ3JlYXRseSBhcHByZWNpYXRlZC4gQXMgZGlzY3Vzc2VkIGluIHRoZSAKPj4gcHJldmlv dXMgdGhyZWFkLCB0aGVyZSB3YXMgc29tZSB1bmNlcnRhaW50eSBhYm91dCB3aGV0aGVyIHdlIHNo b3VsZCAKPj4gZGlyZWN0bHkgaW50ZWdyYXRlIGRldl9lcnJfcHJvYmUoKSBpbnRvIGRldm1fcmVx dWVzdF90aHJlYWRlZF9pcnEoKSwgb3IgCj4+IGlmIGl0J3MgYmV0dGVyIHRvIGNyZWF0ZSBhIHdy YXBwZXIgZnVuY3Rpb24uIFRoYW5rcyBmb3IgeW91ciB0aW1lISAKPj4gVGhhbmtzLCBQYW5jaHVh bmcKCkZvciBzaW1wbGljaXR5IHNha2UganVzdCByZW5hbWUgdGhlIGV4aXN0aW5nIGZ1bmN0aW9u cwpkZXZtX3JlcXVlc3RfdGhyZWFkZWRfaXJxKCkgYW5kIGRldm1fcmVxdWVzdF9hbnlfY29udGV4 dF9pcnEoKSB0bwpfX2Rldm1fcmVxdWVzdF90aHJlYWRlZF9pcnEoKSBhbmQgX19kZXZtX3JlcXVl c3RfYW55X2NvbnRleHRfaXJxKCkuCgpUaGVuIGNyZWF0ZSBuZXcgZnVuY3Rpb25zIGZvciB0aGUg QVBJLCB3aGljaAoKICAgLSBpbnZva2UgdGhlIHVuZGVyc2NvcmUgdmFyaWFudHMKICAgLSBhbmQg b24gZXJyb3IgaW52b2tlIGRldl9lcnJfcHJvYmUoKSBzaW1pbGFyIHRvIHdoYXQgSSBzdWdnZXN0 ZWQgaW4KICAgICBteSByZXBseSBpbiB0aGlzIHRocmVhZC4KCkluIHRoZSByYXJlIGNhc2Ugb2Yg ZmFpbHVyZSwgdGhpcyB3aWxsIHByaW50IGVycm9yIG1lc3NhZ2VzIGZvciB0aGUKYWZmZWN0ZWQg ZHJpdmVycyBib3RoIGluIHRoZSBjb3JlIGFuZCBhdCB0aGUgY2FsbHNpdGUsIGJ1dCB0aGF0J3Mg bm90CnRoZSBlbmQgb2YgdGhlIHdvcmxkLgoKVGhlbiBnbyBhbmQgcmVtb3ZlIHRoZSByYW5kb20g cHJpbnRrcyBmcm9tIHRoZSBkcml2ZXJzLCBvbmNlIHRoZSBjb3JlCmNoYW5nZSBoYXMgaGl0IHVw c3RyZWFtLgoKVGhhbmtzLAoKICAgICAgICB0Z2x4CgoKCgpfX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fXwpMaW51eC1yb2NrY2hpcCBtYWlsaW5nIGxpc3QKTGlu dXgtcm9ja2NoaXBAbGlzdHMuaW5mcmFkZWFkLm9yZwpodHRwOi8vbGlzdHMuaW5mcmFkZWFkLm9y Zy9tYWlsbWFuL2xpc3RpbmZvL2xpbnV4LXJvY2tjaGlwCg==