All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Gleixner <tglx@linutronix.de>
To: Tianyang Zhang <zhangtianyang@loongson.cn>,
	chenhuacai@kernel.org, kernel@xen0n.name, corbet@lwn.net,
	alexs@kernel.org, si.yanteng@linux.dev, jiaxun.yang@flygoat.com,
	peterz@infradead.org, wangliupu@loongson.cn,
	lvjianmin@loongson.cn, maobibo@loongson.cn,
	siyanteng@cqsoftware.com.cn, gaosong@loongson.cn,
	yangtiezhu@loongson.cn
Cc: loongarch@lists.linux.dev, linux-doc@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	Super User <root@localhost.localdomain>
Subject: Re: [PATCH v4 0/2]  Loongarch irq-redirect supprot
Date: Fri, 13 Jun 2025 16:02:10 +0200	[thread overview]
Message-ID: <87qzznivtp.ffs@tglx> (raw)
In-Reply-To: <20250610114252.21077-1-zhangtianyang@loongson.cn>

On Tue, Jun 10 2025 at 19:42, Tianyang Zhang wrote:
> From: Super User <root@localhost.localdomain>

That's a valid developer name :)

> This series of patches introduces support for interrupt-redirect
> controllers, and this hardware feature will be supported on 3C6000
> for the first time
>
> change log:
> 	v3->v4
> 	1.Provide reasonable comments on the modifications made to IRQ_SET_MASK_OK_DONE	

That's not really what I asked for:

  "This change really wants to be seperate with a proper explanation and
   not burried inside of this pile of changes."

Emphasis on _seperate_, which translates to:

  "Put it into a seperate patch with a proper changelog explaining this
   modification and why it is correct."

You still have burried this in the whole pile of unrelated changes.

Thanks,

        tglx

  parent reply	other threads:[~2025-06-13 14:02 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-06-10 11:42 [PATCH v4 0/2] Loongarch irq-redirect supprot Tianyang Zhang
2025-06-10 11:42 ` [PATCH v4 1/2] Docs/LoongArch: Add Advanced Extended-Redirect IRQ model description Tianyang Zhang
2025-06-10 11:42 ` [PATCH v4 2/2] irq/irq-loongarch-ir:Add Redirect irqchip support Tianyang Zhang
2025-06-13 15:20   ` Thomas Gleixner
2025-06-23  2:45     ` Tianyang Zhang
2025-06-23  8:27       ` Thomas Gleixner
2025-06-23  9:33         ` Tianyang Zhang
2025-06-23 20:05           ` Thomas Gleixner
2025-06-24  1:39             ` Tianyang Zhang
2025-06-10 11:54 ` [PATCH v4 0/2] Loongarch irq-redirect supprot Huacai Chen
2025-06-10 12:07   ` Tianyang Zhang
2025-06-24  6:34   ` Tianyang Zhang
2025-06-13 14:02 ` Thomas Gleixner [this message]
2025-06-23  1:13   ` Tianyang Zhang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87qzznivtp.ffs@tglx \
    --to=tglx@linutronix.de \
    --cc=alexs@kernel.org \
    --cc=chenhuacai@kernel.org \
    --cc=corbet@lwn.net \
    --cc=gaosong@loongson.cn \
    --cc=jiaxun.yang@flygoat.com \
    --cc=kernel@xen0n.name \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=loongarch@lists.linux.dev \
    --cc=lvjianmin@loongson.cn \
    --cc=maobibo@loongson.cn \
    --cc=peterz@infradead.org \
    --cc=root@localhost.localdomain \
    --cc=si.yanteng@linux.dev \
    --cc=siyanteng@cqsoftware.com.cn \
    --cc=wangliupu@loongson.cn \
    --cc=yangtiezhu@loongson.cn \
    --cc=zhangtianyang@loongson.cn \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.