All of lore.kernel.org
 help / color / mirror / Atom feed
From: Philippe Gerum <rpm@xenomai.org>
To: Jan Kiszka <jan.kiszka@siemens.com>
Cc: Xenomai <xenomai@lists.linux.dev>
Subject: Re: [PATCH dovetail 6.1-cip] igb: add missing header for oob extensions
Date: Wed, 11 Jun 2025 19:02:42 +0200	[thread overview]
Message-ID: <87qzzq2oul.fsf@xenomai.org> (raw)
In-Reply-To: <c2874537-14c2-4e1a-b8da-20ed0e50661a@siemens.com> (Jan Kiszka's message of "Wed, 11 Jun 2025 18:50:03 +0200")

Jan Kiszka <jan.kiszka@siemens.com> writes:

> On 11.06.25 18:36, Philippe Gerum wrote:
>> Jan Kiszka <jan.kiszka@siemens.com> writes:
>> 
>>> From: Jan Kiszka <jan.kiszka@siemens.com>
>>>
>>> Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
>>> ---
>>>
>>> Not yet tested, but this should make our pipeline green again:
>>> https://source.denx.de/Xenomai/xenomai-images/-/jobs/1166309
>>>
>>>  drivers/net/ethernet/intel/igb/igb_main.c | 1 +
>>>  1 file changed, 1 insertion(+)
>>>
>>> diff --git a/drivers/net/ethernet/intel/igb/igb_main.c b/drivers/net/ethernet/intel/igb/igb_main.c
>>> index c0932a3cb220f..26be743f2a6cf 100644
>>> --- a/drivers/net/ethernet/intel/igb/igb_main.c
>>> +++ b/drivers/net/ethernet/intel/igb/igb_main.c
>>> @@ -12,6 +12,7 @@
>>>  #include <linux/pagemap.h>
>>>  #include <linux/netdevice.h>
>>>  #include <linux/ipv6.h>
>>> +#include <linux/skbuff.h>
>>>  #include <linux/slab.h>
>>>  #include <net/checksum.h>
>>>  #include <net/ip6_checksum.h>
>> 
>> Interestingly, the original code never directly included that
>> header. The x4 includes it indirectly, x3 does not since it does not
>> use the oob netstack. Applying this patch, and forwarding it to v6.12.y
>> which is going to have the same issue.
>
> Interestingly, the current 6.12.y builds did not fail.
>

Maybe the pipeline ran on the fixed tree already (or some indirect
inclusion was at work with v6.12..).

-- 
Philippe.

  reply	other threads:[~2025-06-11 17:02 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-06-11 16:20 [PATCH dovetail 6.1-cip] igb: add missing header for oob extensions Jan Kiszka
2025-06-11 16:36 ` Philippe Gerum
2025-06-11 16:50   ` Jan Kiszka
2025-06-11 17:02     ` Philippe Gerum [this message]
2025-06-12 13:58 ` Jan Kiszka
2025-06-12 14:15   ` Philippe Gerum
2025-06-12 15:11   ` Philippe Gerum
2025-06-12 16:15     ` Jan Kiszka
2025-06-12 16:37       ` Philippe Gerum
2025-06-12 16:39         ` Jan Kiszka

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87qzzq2oul.fsf@xenomai.org \
    --to=rpm@xenomai.org \
    --cc=jan.kiszka@siemens.com \
    --cc=xenomai@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.