From: Markus Armbruster <armbru@redhat.com>
To: Pierrick Bouvier <pierrick.bouvier@linaro.org>
Cc: qemu-devel@nongnu.org, michael.roth@amd.com, thuth@redhat.com,
pbonzini@redhat.com, richard.henderson@linaro.org,
armbru@redhat.com, peter.maydell@linaro.org,
berrange@redhat.com, philmd@linaro.org
Subject: Re: [PATCH v4 14/15] qapi/misc-i386: s/field will be set/field is set/
Date: Tue, 27 May 2025 13:17:43 +0200 [thread overview]
Message-ID: <87r00aqp48.fsf@pond.sub.org> (raw)
In-Reply-To: <20250522190542.588267-15-pierrick.bouvier@linaro.org> (Pierrick Bouvier's message of "Thu, 22 May 2025 12:05:41 -0700")
Pierrick Bouvier <pierrick.bouvier@linaro.org> writes:
> As requested by Markus:
>> I'd prefer "field is set".
>
> Signed-off-by: Pierrick Bouvier <pierrick.bouvier@linaro.org>
> ---
> qapi/misc-i386.json | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/qapi/misc-i386.json b/qapi/misc-i386.json
> index 3fda7a20bdd..6f79817e382 100644
> --- a/qapi/misc-i386.json
> +++ b/qapi/misc-i386.json
> @@ -129,7 +129,7 @@
> # Return information about SEV/SEV-ES/SEV-SNP.
> #
> # If unavailable due to an incompatible configuration the
> -# returned @enabled field will be set to 'false' and the
> +# returned @enabled field is set to 'false' and the
> # state of all other fields is undefined.
> #
> # Returns: @SevInfo
I'd squash this into PATCH 02. I figure you didn't because PATCH 02 is
Daniel's. Here's how I would record provenance when squashing:
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
[Doc comment tweaked]
Signed-off-by: Pierrick Bouvier <pierrick.bouvier@linaro.org>
If you want to blame me for the tweak (kidding, it's fine), you could
use [Doc comment tweaked at Markus's request].
next prev parent reply other threads:[~2025-05-27 11:18 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-22 19:05 [PATCH v4 00/15] qapi: remove all TARGET_* conditionals from the schema Pierrick Bouvier
2025-05-22 19:05 ` [PATCH v4 01/15] qapi: expose rtc-reset-reinjection command unconditionally Pierrick Bouvier
2025-05-22 19:05 ` [PATCH v4 02/15] qapi: expand docs for SEV commands Pierrick Bouvier
2025-05-27 11:26 ` Markus Armbruster
2025-05-27 16:54 ` Pierrick Bouvier
2025-05-28 6:01 ` Markus Armbruster
2025-05-28 18:38 ` Pierrick Bouvier
2025-05-27 12:47 ` Markus Armbruster
2025-05-22 19:05 ` [PATCH v4 03/15] qapi: make SEV commands unconditionally available Pierrick Bouvier
2025-05-22 19:05 ` [PATCH v4 04/15] qapi: expose query-gic-capability command unconditionally Pierrick Bouvier
2025-05-22 19:05 ` [PATCH v4 05/15] qapi: make SGX commands unconditionally available Pierrick Bouvier
2025-05-22 19:05 ` [PATCH v4 06/15] qapi: make Xen event " Pierrick Bouvier
2025-05-22 19:05 ` [PATCH v4 07/15] qapi: remove the misc-target.json file Pierrick Bouvier
2025-05-22 19:05 ` [PATCH v4 08/15] qapi: Make CpuModelExpansionInfo::deprecated-props optional and generic Pierrick Bouvier
2025-05-27 11:32 ` Markus Armbruster
2025-05-27 17:04 ` Pierrick Bouvier
2025-05-22 19:05 ` [PATCH v4 09/15] qapi: make most CPU commands unconditionally available Pierrick Bouvier
2025-05-27 11:38 ` Markus Armbruster
2025-05-27 16:56 ` Pierrick Bouvier
2025-05-28 4:56 ` Markus Armbruster
2025-05-22 19:05 ` [PATCH v4 10/15] qapi: make s390x specific " Pierrick Bouvier
2025-05-26 6:07 ` Thomas Huth
2025-05-22 19:05 ` [PATCH v4 11/15] qapi: remove qapi_specific_outputs from meson.build Pierrick Bouvier
2025-05-22 19:05 ` [PATCH v4 12/15] qapi: make all generated files common Pierrick Bouvier
2025-05-22 19:05 ` [PATCH v4 13/15] qapi: use imperative style in documentation Pierrick Bouvier
2025-05-27 11:12 ` Markus Armbruster
2025-05-27 16:57 ` Pierrick Bouvier
2025-05-22 19:05 ` [PATCH v4 14/15] qapi/misc-i386: s/field will be set/field is set/ Pierrick Bouvier
2025-05-27 11:17 ` Markus Armbruster [this message]
2025-05-22 19:05 ` [PATCH v4 15/15] qapi/misc-i386: move errors to their own documentation section Pierrick Bouvier
2025-05-27 11:20 ` Markus Armbruster
2025-05-27 16:58 ` Pierrick Bouvier
2025-05-28 4:59 ` Markus Armbruster
2025-05-28 19:00 ` Pierrick Bouvier
2025-05-27 12:57 ` Markus Armbruster
2025-05-27 13:00 ` [PATCH v4 00/15] qapi: remove all TARGET_* conditionals from the schema Markus Armbruster
2025-05-27 16:51 ` Pierrick Bouvier
2025-05-28 5:01 ` Markus Armbruster
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87r00aqp48.fsf@pond.sub.org \
--to=armbru@redhat.com \
--cc=berrange@redhat.com \
--cc=michael.roth@amd.com \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=philmd@linaro.org \
--cc=pierrick.bouvier@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=richard.henderson@linaro.org \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.