From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 4F9D7C54756 for ; Thu, 22 May 2025 05:13:36 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1uHyEs-0001Jm-Ak; Thu, 22 May 2025 01:13:06 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uHyEq-0001HB-Nb for qemu-devel@nongnu.org; Thu, 22 May 2025 01:13:04 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uHyEn-0008Qb-Vi for qemu-devel@nongnu.org; Thu, 22 May 2025 01:13:04 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1747890780; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=eDKbEM18tNdBvzazUW8RzQaeaopHf7gS5udjK7TsgFs=; b=dhILVMbmc3WHf3nP3AVjRnv/0hSpfa+nAKlTGWFCD+o4C0xytrd6Lo74TmoF28DVpzSy1f 6pg+AYVzjNPfR/j29B+J47jVtJ2lBwIM4vhs0NYRcIf3tiK0ma3HP5kUvfqxWfQpbYHbt0 al6gn+fnB/A+h27Xbps2g+6nMN/5iFo= Received: from mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-56-OI4bfzP0Nm6zrAya2-36vw-1; Thu, 22 May 2025 01:12:56 -0400 X-MC-Unique: OI4bfzP0Nm6zrAya2-36vw-1 X-Mimecast-MFC-AGG-ID: OI4bfzP0Nm6zrAya2-36vw_1747890775 Received: from mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.12]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 5F2B71956086; Thu, 22 May 2025 05:12:55 +0000 (UTC) Received: from blackfin.pond.sub.org (unknown [10.45.242.7]) by mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 72D9C19560A7; Thu, 22 May 2025 05:12:54 +0000 (UTC) Received: by blackfin.pond.sub.org (Postfix, from userid 1000) id C63A221E6757; Thu, 22 May 2025 07:12:51 +0200 (CEST) From: Markus Armbruster To: Pierrick Bouvier Cc: qemu-devel@nongnu.org, Thomas Huth , Richard Henderson , Michael Roth , Paolo Bonzini , Philippe =?utf-8?Q?Mathieu-Daud=C3=A9?= , berrange@redhat.com, Peter Maydell Subject: Re: [PATCH v2 09/12] qapi: make most CPU commands unconditionally available In-Reply-To: <8e2df5cd-0cb4-4c0c-88f1-30523c6c5315@linaro.org> (Pierrick Bouvier's message of "Wed, 21 May 2025 12:29:05 -0700") References: <20250515172732.3992504-1-pierrick.bouvier@linaro.org> <20250515172732.3992504-10-pierrick.bouvier@linaro.org> <875xhxjeq3.fsf@pond.sub.org> <8e2df5cd-0cb4-4c0c-88f1-30523c6c5315@linaro.org> Date: Thu, 22 May 2025 07:12:51 +0200 Message-ID: <87r00hxm7g.fsf@pond.sub.org> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 3.0 on 10.30.177.12 Received-SPF: pass client-ip=170.10.133.124; envelope-from=armbru@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -22 X-Spam_score: -2.3 X-Spam_bar: -- X-Spam_report: (-2.3 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.184, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Pierrick Bouvier writes: > On 5/18/25 11:29 PM, Markus Armbruster wrote: >> Pierrick Bouvier writes: >>=20 >>> From: Daniel P. Berrang=C3=A9 >>> >>> This removes the TARGET_* conditions from all the CPU commands >>> that are conceptually target independent. Top level stubs are >>> provided to cope with targets which do not currently implement >>> all of the commands. >>> >>> Reviewed-by: Richard Henderson >>> Signed-off-by: Daniel P. Berrang=C3=A9 >>> Signed-off-by: Pierrick Bouvier >>=20 >> [...] >>=20 >>> diff --git a/qapi/machine-target.json b/qapi/machine-target.json >>> deleted file mode 100644 >>> index e153291a7fc..00000000000 >>> --- a/qapi/machine-target.json >>> +++ /dev/null >>=20 >> [...] >>=20 >>> -## >>> -# @query-cpu-model-comparison: >>> -# >>> -# Compares two CPU models, @modela and @modelb, returning how they >>> -# compare in a specific configuration. The results indicates how >>> -# both models compare regarding runnability. This result can be >>> -# used by tooling to make decisions if a certain CPU model will >>> -# run in a certain configuration or if a compatible CPU model has >>> -# to be created by baselining. >>> -# >>> -# Usually, a CPU model is compared against the maximum possible CPU >>> -# model of a certain configuration (e.g. the "host" model for KVM). >>> -# If that CPU model is identical or a subset, it will run in that >>> -# configuration. >>> -# >>> -# The result returned by this command may be affected by: >>> -# >>> -# * QEMU version: CPU models may look different depending on the QEMU >>> -# version. (Except for CPU models reported as "static" in >>> -# query-cpu-definitions.) >>> -# * machine-type: CPU model may look different depending on the >>> -# machine-type. (Except for CPU models reported as "static" in >>> -# query-cpu-definitions.) >>> -# * machine options (including accelerator): in some architectures, >>> -# CPU models may look different depending on machine and accelerator >>> -# options. (Except for CPU models reported as "static" in >>> -# query-cpu-definitions.) >>> -# * "-cpu" arguments and global properties: arguments to the -cpu >>> -# option and global properties may affect expansion of CPU models. >>> -# Using query-cpu-model-expansion while using these is not advised. >>> -# >>> -# Some architectures may not support comparing CPU models. s390x >>> -# supports comparing CPU models. >>> -# >>> -# @modela: description of the first CPU model to compare, referred to >>> -# as "model A" in CpuModelCompareResult >>> -# >>> -# @modelb: description of the second CPU model to compare, referred to >>> -# as "model B" in CpuModelCompareResult >>> -# >>> -# Returns: a CpuModelCompareInfo describing how both CPU models >>> -# compare >>> -# >>> -# Errors: >>> -# - if comparing CPU models is not supported >>> -# - if a model cannot be used >>> -# - if a model contains an unknown cpu definition name, unknown >>> -# properties or properties with wrong types. >>> -# >>> -# .. note:: This command isn't specific to s390x, but is only >>> -# implemented on this architecture currently. >>=20 >> We lose this note. Intentional? >>=20 >> Perhaps because we also have the "Some architectures ..." paragraph >> above? >>=20 >>> -# >>> -# Since: 2.8 >>> -## >>> -{ 'command': 'query-cpu-model-comparison', >>> - 'data': { 'modela': 'CpuModelInfo', 'modelb': 'CpuModelInfo' }, >>> - 'returns': 'CpuModelCompareInfo', >>> - 'if': 'TARGET_S390X' } >>> - >>> -## >>> -# @query-cpu-model-baseline: >>> -# >>> -# Baseline two CPU models, @modela and @modelb, creating a compatible >>> -# third model. The created model will always be a static, >>> -# migration-safe CPU model (see "static" CPU model expansion for >>> -# details). >>> -# >>> -# This interface can be used by tooling to create a compatible CPU >>> -# model out two CPU models. The created CPU model will be identical >>> -# to or a subset of both CPU models when comparing them. Therefore, >>> -# the created CPU model is guaranteed to run where the given CPU >>> -# models run. >>> -# >>> -# The result returned by this command may be affected by: >>> -# >>> -# * QEMU version: CPU models may look different depending on the QEMU >>> -# version. (Except for CPU models reported as "static" in >>> -# query-cpu-definitions.) >>> -# * machine-type: CPU model may look different depending on the >>> -# machine-type. (Except for CPU models reported as "static" in >>> -# query-cpu-definitions.) >>> -# * machine options (including accelerator): in some architectures, >>> -# CPU models may look different depending on machine and accelerator >>> -# options. (Except for CPU models reported as "static" in >>> -# query-cpu-definitions.) >>> -# * "-cpu" arguments and global properties: arguments to the -cpu >>> -# option and global properties may affect expansion of CPU models. >>> -# Using query-cpu-model-expansion while using these is not advised. >>> -# >>> -# Some architectures may not support baselining CPU models. s390x >>> -# supports baselining CPU models. >>> -# >>> -# @modela: description of the first CPU model to baseline >>> -# >>> -# @modelb: description of the second CPU model to baseline >>> -# >>> -# Returns: a CpuModelBaselineInfo describing the baselined CPU model >>> -# >>> -# Errors: >>> -# - if baselining CPU models is not supported >>> -# - if a model cannot be used >>> -# - if a model contains an unknown cpu definition name, unknown >>> -# properties or properties with wrong types. >>> -# >>> -# .. note:: This command isn't specific to s390x, but is only >>> -# implemented on this architecture currently. >>=20 >> We lose this note. Intentional? >>=20 >> Perhaps because we also have the "Some architectures ..." paragraph >> above? >>=20 >>> -# >>> -# Since: 2.8 >>> -## >>> -{ 'command': 'query-cpu-model-baseline', >>> - 'data': { 'modela': 'CpuModelInfo', >>> - 'modelb': 'CpuModelInfo' }, >>> - 'returns': 'CpuModelBaselineInfo', >>> - 'if': 'TARGET_S390X' } >>=20 >> [...] >>=20 > > Yes, those notes don't have any reason to be present anymore, and the=20 > new "Some architectures..." paragraph replaces them. Okay. A brief mention in the commit message like "Adjust the doc comments accordingly" might be helpful. Up to you!