From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 94DCDC369C2 for ; Fri, 25 Apr 2025 15:09:10 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1u8KfJ-0004P9-DK; Fri, 25 Apr 2025 11:08:33 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1u8KfH-0004Og-Oz for qemu-devel@nongnu.org; Fri, 25 Apr 2025 11:08:31 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1u8KfF-0001E1-Ub for qemu-devel@nongnu.org; Fri, 25 Apr 2025 11:08:31 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1745593709; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=WqmlhTdk/qYEYcde7IsgJF2CYBQPd2SHcNX05DyIZVE=; b=RPol1TieuHGysPd+bMYgVZC3AMxZRh7bbxSd+8SvVH3jQ8EZSDxwcJlNoGOSNsY0RpXlV2 XbrUBdEM6eM9nkmXuuRAjDtop+1+OxLShbUa40Bo1tfUaIB5DJ+yHKLlG6Ueud3LIZtEzj gSolcHHdaUmr87ZnnmkT+gxYkmNbiNg= Received: from mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-563-NrP6w5sIOPeXmVZTUWbbjA-1; Fri, 25 Apr 2025 11:08:26 -0400 X-MC-Unique: NrP6w5sIOPeXmVZTUWbbjA-1 X-Mimecast-MFC-AGG-ID: NrP6w5sIOPeXmVZTUWbbjA_1745593702 Received: from mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.111]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 209EB1955E79; Fri, 25 Apr 2025 15:08:21 +0000 (UTC) Received: from blackfin.pond.sub.org (unknown [10.45.242.5]) by mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 9F130180045B; Fri, 25 Apr 2025 15:08:19 +0000 (UTC) Received: by blackfin.pond.sub.org (Postfix, from userid 1000) id E907A21E66C3; Fri, 25 Apr 2025 17:08:16 +0200 (CEST) From: Markus Armbruster To: Daniel P. =?utf-8?Q?Berrang=C3=A9?= Cc: "Michael S. Tsirkin" , Akihiko Odaki , Jason Wang , Dmitry Fleytman , Sriram Yagnaraman , Luigi Rizzo , Giuseppe Lettieri , Vincenzo Maffione , Andrew Melnychenko , Yuri Benditovich , Paolo Bonzini , Eduardo Habkost , Michael Roth , Marcel Apfelbaum , Philippe =?utf-8?Q?Mathieu-Daud=C3=A9?= , Yanan Wang , Zhao Liu , Lei Yang , BALATON Zoltan , qemu-devel@nongnu.org, devel@daynix.com Subject: Re: [PATCH v6 0/4] virtio: Convert feature properties to OnOffAuto In-Reply-To: ("Daniel P. =?utf-8?Q?Berrang?= =?utf-8?Q?=C3=A9=22's?= message of "Fri, 25 Apr 2025 13:20:44 +0100") References: <20250306-virtio-v6-0-1235eab776d9@daynix.com> <20250425081234-mutt-send-email-mst@kernel.org> Date: Fri, 25 Apr 2025 17:08:16 +0200 Message-ID: <87r01gb7of.fsf@pond.sub.org> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.111 Received-SPF: pass client-ip=170.10.129.124; envelope-from=armbru@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -23 X-Spam_score: -2.4 X-Spam_bar: -- X-Spam_report: (-2.4 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.314, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Daniel P. Berrang=C3=A9 writes: > On Fri, Apr 25, 2025 at 08:14:13AM -0400, Michael S. Tsirkin wrote: >> On Thu, Mar 06, 2025 at 03:16:26PM +0900, Akihiko Odaki wrote: >> > This series was spun off from: >> > "[PATCH 0/3] virtio-net: Convert feature properties to OnOffAuto" >> > (https://patchew.org/QEMU/20240714-auto-v3-0-e27401aabab3@daynix.com/) >> >=20 >> > Some features are not always available with vhost. Legacy features are >> > not available with vp_vdpa in particular. virtio devices used to disab= le >> > them when not available even if the corresponding properties were >> > explicitly set to "on". >> >=20 >> > QEMU already has OnOffAuto type, which includes the "auto" value to let >> > it automatically decide the effective value. Convert feature properties >> > to OnOffAuto and set them "auto" by default to utilize it. This allows >> > QEMU to report an error if they are set "on" and the corresponding >> > features are not available. >> >=20 >> > Signed-off-by: Akihiko Odaki >>=20 >>=20 >> Marcus, Paolo, Daniel, Eduardo, any feedback on the QOM bits? > > I've said on every previous version that I don't think we should be > changing OnOffAuto to secretly accept bool values. That is bypassing > QAPI schema definitions with a special code hack. I also objected to v4. Thread starts at Message-ID: <87cyfwxveo.fsf@pond.sub.org> https://lore.kernel.org/qemu-devel/87cyfwxveo.fsf@pond.sub.org/ I could be persuaded to accept a patch that changes exactly the properties that need to be changed to tri-state, with suitable rationale. This patch changes a bunch of unrelated properties, too.