All of lore.kernel.org
 help / color / mirror / Atom feed
From: Philippe Gerum <rpm@xenomai.org>
To: Jan Kiszka <jan.kiszka@siemens.com>
Cc: Florian Bezdeka <florian.bezdeka@siemens.com>,
	 Xenomai <xenomai@lists.linux.dev>
Subject: Re: [PATCH] dovetail: Fix interrupt re-enabling after hibernation
Date: Thu, 20 Mar 2025 19:49:28 +0100	[thread overview]
Message-ID: <87r02rill3.fsf@xenomai.org> (raw)
In-Reply-To: <e6cfc82a-1b3a-4dc3-b390-8c01728c2ed0@siemens.com> (Jan Kiszka's message of "Thu, 20 Mar 2025 18:04:38 +0100")

Jan Kiszka <jan.kiszka@siemens.com> writes:

> On 20.03.25 17:50, Florian Bezdeka wrote:
>> On Thu, 2025-03-20 at 17:41 +0100, Jan Kiszka wrote:
>>> From: Jan Kiszka <jan.kiszka@siemens.com>
>>>
>>> We had unbalanced hard_cond_local_irq_disable here so far.
>>>
>>> Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
>>> ---
>>>
>>> Minus one hunk that is already in current 6.12.y, this needs to be 
>>> applied to older stable versions as well.
>> 
>> How was that tested? I think up to now nobody really cared about
>> hibernation... Will that really work now when I try to test that or
>> will I run into (other) problems?
>> 
>
> This was not tested yet, but the affected code is patched since an
> eternity. If we don't want to support this anymore, we must remove the
> changes AND declare CONFIG_HIBERNATION incompatible to
> CONFIG_IRQ_PIPELINE instead.
>

We may definitely have a system running a real-time core which is
allowed to hibernate at specific times (e.g. a copier running Xenomai
would typically do this). This used to work fine for a couple of
projects I can think of (granted, a long time ago). Let's fix the code.

-- 
Philippe.

  reply	other threads:[~2025-03-20 18:49 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-03-20 16:41 [PATCH] dovetail: Fix interrupt re-enabling after hibernation Jan Kiszka
2025-03-20 16:50 ` Florian Bezdeka
2025-03-20 17:04   ` Jan Kiszka
2025-03-20 18:49     ` Philippe Gerum [this message]
2025-03-20 18:51   ` Philippe Gerum
2025-03-21  7:51 ` Philippe Gerum
2025-03-21 12:51   ` Florian Bezdeka
2025-03-21 13:31     ` Philippe Gerum
2025-03-21 13:35       ` Philippe Gerum
2025-03-21 13:51         ` Philippe Gerum
2025-03-24 17:18           ` Jan Kiszka
2025-03-24 11:18 ` Florian Bezdeka
2025-03-24 11:21   ` Jan Kiszka
2025-03-24 14:19   ` Philippe Gerum
2025-03-24 20:05     ` Florian Bezdeka

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87r02rill3.fsf@xenomai.org \
    --to=rpm@xenomai.org \
    --cc=florian.bezdeka@siemens.com \
    --cc=jan.kiszka@siemens.com \
    --cc=xenomai@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.