All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jani Nikula <jani.nikula@intel.com>
To: Luca Coelho <luca@coelho.fi>,
	intel-gfx@lists.freedesktop.org, intel-xe@lists.freedesktop.org
Subject: Re: [PATCH v2 3/5] drm/i915/dp: convert to struct intel_display
Date: Thu, 12 Dec 2024 12:30:54 +0200	[thread overview]
Message-ID: <87r06dw5up.fsf@intel.com> (raw)
In-Reply-To: <5ddef9ce5dd38db49379697fe532802ea34b6a76.camel@coelho.fi>

On Thu, 12 Dec 2024, Luca Coelho <luca@coelho.fi> wrote:
> On Tue, 2024-12-10 at 12:46 +0200, Jani Nikula wrote:
>> Going forward, struct intel_display is the main device data structure
>> for display. Switch to it internally in DP code.
>> 
>> Signed-off-by: Jani Nikula <jani.nikula@intel.com>
>> ---
>
> These huge mechanical changes are impossible to review fully with my
> attention span, but the patch looks sane.  Again, if you used any
> semantic patch to do this, it would be easier to review it instead. ;)

I started off with a *huge* semantic patch which isn't easy to review
either... especially so because it falls short on a bunch of cases and
needs manual tweaking anyway.

I'm not sure what the return on investment is with tweaking the cocci,
because making changes to it ends up being a lot of trial and error. :(

> Reviewed-by: Luca Coelho <luciano.coelho@intel.com>

Thanks,
Jani.

>
> --
> Cheers,
> Luca.

-- 
Jani Nikula, Intel

  reply	other threads:[~2024-12-12 10:31 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-12-10 10:46 [PATCH v2 0/5] drm/i915/dp: convert to struct intel_display Jani Nikula
2024-12-10 10:46 ` [PATCH v2 1/5] drm/i915/dp: s/intel_encoder/encoder/ Jani Nikula
2024-12-12 10:09   ` Luca Coelho
2024-12-10 10:46 ` [PATCH v2 2/5] drm/i915/dp: s/intel_connector/connector/ Jani Nikula
2024-12-12 10:13   ` Luca Coelho
2024-12-10 10:46 ` [PATCH v2 3/5] drm/i915/dp: convert to struct intel_display Jani Nikula
2024-12-12 10:18   ` Luca Coelho
2024-12-12 10:30     ` Jani Nikula [this message]
2024-12-10 10:46 ` [PATCH v2 4/5] drm/i915/dp: convert interfaces " Jani Nikula
2024-12-12 10:21   ` Luca Coelho
2024-12-10 10:46 ` [PATCH v2 5/5] drm/i915/dp: finish link training conversion " Jani Nikula
2024-12-12 10:28   ` Luca Coelho
2024-12-10 12:28 ` ✓ CI.Patch_applied: success for drm/i915/dp: convert to struct intel_display (rev2) Patchwork
2024-12-10 12:28 ` ✓ CI.checkpatch: " Patchwork
2024-12-10 12:30 ` ✓ CI.KUnit: " Patchwork
2024-12-10 12:48 ` ✓ CI.Build: " Patchwork
2024-12-10 12:50 ` ✓ CI.Hooks: " Patchwork
2024-12-10 12:52 ` ✗ CI.checksparse: warning " Patchwork
2024-12-10 13:27 ` ✓ Xe.CI.BAT: success " Patchwork
2024-12-10 14:37 ` ✗ Xe.CI.Full: failure " Patchwork
2024-12-10 14:45 ` ✗ Fi.CI.SPARSE: warning " Patchwork
2024-12-10 15:01 ` ✓ i915.CI.BAT: success " Patchwork
2024-12-10 17:07 ` ✓ i915.CI.Full: " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87r06dw5up.fsf@intel.com \
    --to=jani.nikula@intel.com \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=intel-xe@lists.freedesktop.org \
    --cc=luca@coelho.fi \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.