From: Gregory CLEMENT <gregory.clement@bootlin.com>
To: "Rob Herring (Arm)" <robh@kernel.org>,
Andrew Lunn <andrew@lunn.ch>,
Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Russell King <linux@armlinux.org.uk>
Cc: linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, Frank Wunderlich <linux@fw-web.de>
Subject: Re: [PATCH] arm64: dts: marvell: Drop undocumented SATA phy names
Date: Tue, 05 Nov 2024 17:28:57 +0100 [thread overview]
Message-ID: <87r07p8x12.fsf@BLaptop.bootlin.com> (raw)
In-Reply-To: <20241014193528.1896905-2-robh@kernel.org>
"Rob Herring (Arm)" <robh@kernel.org> writes:
> While "phy-names" is allowed for sata-port nodes, the names used aren't
> documented and are incorrect ("sata-phy" is what's documented). The name
> for a single entry is fairly useless, so just drop the property.
>
> Signed-off-by: Rob Herring (Arm) <robh@kernel.org>
Applied on mvebu/dt64
Thanks,
Gregory
> ---
> Cc: Frank Wunderlich <linux@fw-web.de>
>
> There's also this 2 year old patch fixing other SATA errors[1] which
> was never picked up. :(
>
> [1] https://lore.kernel.org/linux-arm-kernel/20220311210357.222830-3-linux@fw-web.de/
>
> arch/arm64/boot/dts/marvell/armada-7040-db.dts | 1 -
> arch/arm64/boot/dts/marvell/armada-7040-mochabin.dts | 2 --
> arch/arm64/boot/dts/marvell/armada-8040-clearfog-gt-8k.dts | 1 -
> arch/arm64/boot/dts/marvell/armada-8040-db.dts | 2 --
> arch/arm64/boot/dts/marvell/armada-8040-mcbin.dtsi | 1 -
> arch/arm64/boot/dts/marvell/armada-8040-puzzle-m801.dts | 2 --
> 6 files changed, 9 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/marvell/armada-7040-db.dts b/arch/arm64/boot/dts/marvell/armada-7040-db.dts
> index 5e5baf6beea4..1e0ab35cc686 100644
> --- a/arch/arm64/boot/dts/marvell/armada-7040-db.dts
> +++ b/arch/arm64/boot/dts/marvell/armada-7040-db.dts
> @@ -214,7 +214,6 @@ &cp0_sata0 {
>
> sata-port@1 {
> phys = <&cp0_comphy3 1>;
> - phy-names = "cp0-sata0-1-phy";
> };
> };
>
> diff --git a/arch/arm64/boot/dts/marvell/armada-7040-mochabin.dts b/arch/arm64/boot/dts/marvell/armada-7040-mochabin.dts
> index 40b7ee7ead72..7af949092b91 100644
> --- a/arch/arm64/boot/dts/marvell/armada-7040-mochabin.dts
> +++ b/arch/arm64/boot/dts/marvell/armada-7040-mochabin.dts
> @@ -433,13 +433,11 @@ &cp0_sata0 {
> /* 7 + 12 SATA connector (J24) */
> sata-port@0 {
> phys = <&cp0_comphy2 0>;
> - phy-names = "cp0-sata0-0-phy";
> };
>
> /* M.2-2250 B-key (J39) */
> sata-port@1 {
> phys = <&cp0_comphy3 1>;
> - phy-names = "cp0-sata0-1-phy";
> };
> };
>
> diff --git a/arch/arm64/boot/dts/marvell/armada-8040-clearfog-gt-8k.dts b/arch/arm64/boot/dts/marvell/armada-8040-clearfog-gt-8k.dts
> index 67892f0d2863..7005a32a6e1e 100644
> --- a/arch/arm64/boot/dts/marvell/armada-8040-clearfog-gt-8k.dts
> +++ b/arch/arm64/boot/dts/marvell/armada-8040-clearfog-gt-8k.dts
> @@ -475,7 +475,6 @@ &cp1_sata0 {
>
> sata-port@1 {
> phys = <&cp1_comphy0 1>;
> - phy-names = "cp1-sata0-1-phy";
> };
> };
>
> diff --git a/arch/arm64/boot/dts/marvell/armada-8040-db.dts b/arch/arm64/boot/dts/marvell/armada-8040-db.dts
> index 92897bd7e6cf..2ec19d364e62 100644
> --- a/arch/arm64/boot/dts/marvell/armada-8040-db.dts
> +++ b/arch/arm64/boot/dts/marvell/armada-8040-db.dts
> @@ -145,11 +145,9 @@ &cp0_sata0 {
>
> sata-port@0 {
> phys = <&cp0_comphy1 0>;
> - phy-names = "cp0-sata0-0-phy";
> };
> sata-port@1 {
> phys = <&cp0_comphy3 1>;
> - phy-names = "cp0-sata0-1-phy";
> };
> };
>
> diff --git a/arch/arm64/boot/dts/marvell/armada-8040-mcbin.dtsi b/arch/arm64/boot/dts/marvell/armada-8040-mcbin.dtsi
> index c864df9ec84d..e88ff5b179c8 100644
> --- a/arch/arm64/boot/dts/marvell/armada-8040-mcbin.dtsi
> +++ b/arch/arm64/boot/dts/marvell/armada-8040-mcbin.dtsi
> @@ -245,7 +245,6 @@ &cp0_sata0 {
> /* CPM Lane 5 - U29 */
> sata-port@1 {
> phys = <&cp0_comphy5 1>;
> - phy-names = "cp0-sata0-1-phy";
> };
> };
>
> diff --git a/arch/arm64/boot/dts/marvell/armada-8040-puzzle-m801.dts b/arch/arm64/boot/dts/marvell/armada-8040-puzzle-m801.dts
> index 42a60f3dd5d1..3e5e0651ce68 100644
> --- a/arch/arm64/boot/dts/marvell/armada-8040-puzzle-m801.dts
> +++ b/arch/arm64/boot/dts/marvell/armada-8040-puzzle-m801.dts
> @@ -408,12 +408,10 @@ &cp0_sata0 {
>
> sata-port@0 {
> phys = <&cp0_comphy2 0>;
> - phy-names = "cp0-sata0-0-phy";
> };
>
> sata-port@1 {
> phys = <&cp0_comphy5 1>;
> - phy-names = "cp0-sata0-1-phy";
> };
> };
>
> --
> 2.45.2
>
--
Grégory CLEMENT, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
next prev parent reply other threads:[~2024-11-05 17:07 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-14 19:35 [PATCH] arm64: dts: marvell: Drop undocumented SATA phy names Rob Herring (Arm)
2024-11-04 13:22 ` Rob Herring
2024-11-05 16:28 ` Gregory CLEMENT [this message]
2024-11-06 18:33 ` Frank Wunderlich
2024-11-06 18:39 ` Rob Herring
2024-11-06 21:17 ` Frank Wunderlich (linux)
2024-11-06 21:52 ` Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87r07p8x12.fsf@BLaptop.bootlin.com \
--to=gregory.clement@bootlin.com \
--cc=andrew@lunn.ch \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=linux@fw-web.de \
--cc=robh@kernel.org \
--cc=sebastian.hesselbarth@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.