From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 791D0C3DA64 for ; Thu, 1 Aug 2024 12:56:43 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 23FB310E159; Thu, 1 Aug 2024 12:56:43 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=intel.com header.i=@intel.com header.b="S350bHDL"; dkim-atps=neutral Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.17]) by gabe.freedesktop.org (Postfix) with ESMTPS id 286C210E159; Thu, 1 Aug 2024 12:56:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1722517002; x=1754053002; h=from:to:cc:subject:in-reply-to:references:date: message-id:mime-version; bh=cCXdHEpMz9c2bBq26e32ONp/13OtXkPy15MjuY9WCkY=; b=S350bHDLCALibHu806Ki72S3tMPy9uH9x0sR5jJs1bUAoIkdbfIuIKaD JhZt1D2CMwk7Krydhc8jFnyW4VxgiSKXc93TUsrw2VxJn30HgJeyUypVT n+5Nj/VxGxfNbRlRNum+Ej6X6aaRdeLAma3+Ov/cmqXIcO7Q3M6KKVERk IoDwkL+CuxANL9FBIzdfwvO4+t/6+PK6L0s4CZzdQrYmH8eTUZ2ID7pV8 vEozyNKxFMSpNvFMpVlOru7wgn2Cs7vGcNPrIUBGBiItAERffSoGnF48p GPz524CaawXrhdg+vtSUOK83tepVVq9ZVtzGY3r9QZAD5hA59ZJn/oq12 g==; X-CSE-ConnectionGUID: aTc+9iRDTJ2i46att0oLHA== X-CSE-MsgGUID: VPMsPkPNQyOYFflPwi5YUw== X-IronPort-AV: E=McAfee;i="6700,10204,11151"; a="20587016" X-IronPort-AV: E=Sophos;i="6.09,254,1716274800"; d="scan'208";a="20587016" Received: from orviesa001.jf.intel.com ([10.64.159.141]) by orvoesa109.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 01 Aug 2024 05:56:28 -0700 X-CSE-ConnectionGUID: g/fx4tHuQmCjbMW5J9x36A== X-CSE-MsgGUID: fy/vpjVBR5ybMhSyxQ4pqQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.09,254,1716274800"; d="scan'208";a="92554780" Received: from jnikula-mobl4.fi.intel.com (HELO localhost) ([10.237.66.160]) by smtpauth.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 01 Aug 2024 05:56:25 -0700 From: Jani Nikula To: Thomas Zimmermann , Xaver Hugl , Mario Limonciello Cc: Leo Li , amd-gfx@lists.freedesktop.org, Simon Ser , Harry Wentland , dri-devel@lists.freedesktop.org, Sean Paul Subject: Re: [PATCH v3 2/2] drm/amd: Add power_saving_policy drm property to eDP connectors In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo References: <20240606020404.210989-1-mario.limonciello@amd.com> <20240606020404.210989-3-mario.limonciello@amd.com> <87wml0v2vv.fsf@intel.com> Date: Thu, 01 Aug 2024 15:56:21 +0300 Message-ID: <87r0b8v1u2.fsf@intel.com> MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: amd-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Discussion list for AMD gfx List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: amd-gfx-bounces@lists.freedesktop.org Sender: "amd-gfx" On Thu, 01 Aug 2024, Thomas Zimmermann wrote: > Hi > > Am 01.08.24 um 14:33 schrieb Jani Nikula: >> On Mon, 01 Jul 2024, Xaver Hugl wrote: >>> Am Do., 20. Juni 2024 um 22:22 Uhr schrieb Xaver Hugl : >>>> Merging can only happen once a real world userspace application has >>>> implemented support for it. I'll try to do that sometime next week in >>>> KWin >>> Here's the promised implementation: >>> https://invent.kde.org/plasma/kwin/-/merge_requests/6028 >> The requirement is that the userspace patches must be reviewed and ready >> for merging into a suitable and canonical upstream project. >> >> Are they? > > I already saw this series in today's PR for drm-misc-next. :/ Exactly what triggered the question! BR, Jani. > > Best regards > Thomas > >> >> >> BR, >> Jani. >> >> >>> In testing with the patches on top of kernel 6.9.6, setting the >>> property to `Require color accuracy` makes the sysfs file correctly >>> report "Device or resource busy" when trying to change the power >>> saving level, but setting the property to zero doesn't really work. >>> Once KWin sets the property to zero, changing the power saving level >>> "works" but the screen blanks for a moment (might just be a single >>> frame) and reading from the file returns zero again, with the visuals >>> and backlight level unchanged as well. -- Jani Nikula, Intel