From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 2D7A8C54798 for ; Tue, 27 Feb 2024 16:44:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-ID:Date:References :In-Reply-To:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=HKESwdVZrPLdeTJ4WYmBCZpZSqkdxOO6cI/mPmW7Ar4=; b=d2XXNTIqaWAfOK PT81mWfUX3Ab5SxwQsMjYESbdGPmcFFmshM+OnUx1HMTcJxjcMJABkTMvdat9xWhAUX9TbppVHeul /qGgaMLv8AbFmGdPSrPC0QooDHsau2/n7kq9ppcf3DoSXwadD9U+Zjj29/wY92Dc0XNXKA7P30pvA hBTwMxrx1AxoLnyd0t4GI4CoaiRv1nXFJJyKLC6UUqIEyV/jNvvG2ZxMBdH/BwKj+JWakAb/rxxej +uf7Hc2ZFaQvS03VHNh7Eh8pTOnWkyOgm/ZyW9c08M5wHE2uBHPGBcT0aFkKigF0DLTQ5hQpL3NNm RgpjCe5l0Wvxub8MFyVQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rf0Yr-000000062Rt-1zaI; Tue, 27 Feb 2024 16:44:09 +0000 Received: from relay7-d.mail.gandi.net ([217.70.183.200]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rf0Yo-000000062Qd-3mmf for linux-arm-kernel@lists.infradead.org; Tue, 27 Feb 2024 16:44:08 +0000 Received: by mail.gandi.net (Postfix) with ESMTPSA id D3F6A20002; Tue, 27 Feb 2024 16:44:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1709052245; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=76mZ13DHESmZTVSHEaVoshFTsFCTogrCRWvywDtKTWE=; b=RGuGLMKlcnyRzk7Ze4to/gJfeKNYw9LJvr5cm5DiUHmlR2n3X0/rk93nu7DP00MOxMrZ8m jxiv6bMj7wrMRgzFRmkmSZveRWikAa6pqdL0Sr+yoEBoGFy38VoW9wJIYDbTyXs2xZ2kVa 7Qty6dttcX32k+zkRIbjaYFPunVj23pEd7w5IonQDcZ9TpVqbNPVrX/QGFM4pMYDu6roVd XbGjLrZS8G8XWaMBj4FFXY5U6XlNeUyi3vA6jKlildBe10In8ry5Okluvap9TGck09eXZU 82QKnp9AmhLzhmMhy1nx1hcVYlojf67M4gTi6GwEnE32TkdG/ukdoZV8s293bA== From: Gregory CLEMENT To: Uwe =?utf-8?Q?Kleine-K=C3=B6nig?= , Thomas Gleixner Cc: Andrew Lunn , Sebastian Hesselbarth , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, kernel@pengutronix.de Subject: Re: [PATCH 07/13] irqchip/mvebu-pic: Convert to platform remove callback returning void In-Reply-To: References: Date: Tue, 27 Feb 2024 17:44:04 +0100 Message-ID: <87r0gxj1rf.fsf@BL-laptop> MIME-Version: 1.0 X-GND-Sasl: gregory.clement@bootlin.com X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240227_084407_092562_194871F9 X-CRM114-Status: GOOD ( 20.91 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org VXdlIEtsZWluZS1Lw7ZuaWcgPHUua2xlaW5lLWtvZW5pZ0BwZW5ndXRyb25peC5kZT4gd3JpdGVz OgoKPiBUaGUgLnJlbW92ZSgpIGNhbGxiYWNrIGZvciBhIHBsYXRmb3JtIGRyaXZlciByZXR1cm5z IGFuIGludCB3aGljaCBtYWtlcwo+IG1hbnkgZHJpdmVyIGF1dGhvcnMgd3JvbmdseSBhc3N1bWUg aXQncyBwb3NzaWJsZSB0byBkbyBlcnJvciBoYW5kbGluZyBieQo+IHJldHVybmluZyBhbiBlcnJv ciBjb2RlLiBIb3dldmVyIHRoZSB2YWx1ZSByZXR1cm5lZCBpcyBpZ25vcmVkIChhcGFydAo+IGZy b20gZW1pdHRpbmcgYSB3YXJuaW5nKSBhbmQgdGhpcyB0eXBpY2FsbHkgcmVzdWx0cyBpbiByZXNv dXJjZSBsZWFrcy4KPgo+IFRvIGltcHJvdmUgaGVyZSB0aGVyZSBpcyBhIHF1ZXN0IHRvIG1ha2Ug dGhlIHJlbW92ZSBjYWxsYmFjayByZXR1cm4KPiB2b2lkLiBJbiB0aGUgZmlyc3Qgc3RlcCBvZiB0 aGlzIHF1ZXN0IGFsbCBkcml2ZXJzIGFyZSBjb252ZXJ0ZWQgdG8KPiAucmVtb3ZlX25ldygpLCB3 aGljaCBhbHJlYWR5IHJldHVybnMgdm9pZC4gRXZlbnR1YWxseSBhZnRlciBhbGwgZHJpdmVycwo+ IGFyZSBjb252ZXJ0ZWQsIC5yZW1vdmVfbmV3KCkgd2lsbCBiZSByZW5hbWVkIHRvIC5yZW1vdmUo KS4KPgo+IFRyaXZpYWxseSBjb252ZXJ0IHRoaXMgZHJpdmVyIGZyb20gYWx3YXlzIHJldHVybmlu ZyB6ZXJvIGluIHRoZSByZW1vdmUKPiBjYWxsYmFjayB0byB0aGUgdm9pZCByZXR1cm5pbmcgdmFy aWFudC4KPgo+IFNpZ25lZC1vZmYtYnk6IFV3ZSBLbGVpbmUtS8O2bmlnIDx1LmtsZWluZS1rb2Vu aWdAcGVuZ3V0cm9uaXguZGU+CgpBY2tlZC1ieTogR3JlZ29yeSBDTEVNRU5UIDxncmVnb3J5LmNs ZW1lbnRAYm9vdGxpbi5jb20+CgpUaGFua3MsCgpHcmVnb3J5Cj4gLS0tCj4gIGRyaXZlcnMvaXJx Y2hpcC9pcnEtbXZlYnUtcGljLmMgfCA2ICsrLS0tLQo+ICAxIGZpbGUgY2hhbmdlZCwgMiBpbnNl cnRpb25zKCspLCA0IGRlbGV0aW9ucygtKQo+Cj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvaXJxY2hp cC9pcnEtbXZlYnUtcGljLmMgYi9kcml2ZXJzL2lycWNoaXAvaXJxLW12ZWJ1LXBpYy5jCj4gaW5k ZXggZWYzZDM2NDZjY2MyLi41N2UzZjk5YjYxZjUgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9pcnFj aGlwL2lycS1tdmVidS1waWMuYwo+ICsrKyBiL2RyaXZlcnMvaXJxY2hpcC9pcnEtbXZlYnUtcGlj LmMKPiBAQCAtMTY3LDE0ICsxNjcsMTIgQEAgc3RhdGljIGludCBtdmVidV9waWNfcHJvYmUoc3Ry dWN0IHBsYXRmb3JtX2RldmljZSAqcGRldikKPiAgCXJldHVybiAwOwo+ICB9Cj4gIAo+IC1zdGF0 aWMgaW50IG12ZWJ1X3BpY19yZW1vdmUoc3RydWN0IHBsYXRmb3JtX2RldmljZSAqcGRldikKPiAr c3RhdGljIHZvaWQgbXZlYnVfcGljX3JlbW92ZShzdHJ1Y3QgcGxhdGZvcm1fZGV2aWNlICpwZGV2 KQo+ICB7Cj4gIAlzdHJ1Y3QgbXZlYnVfcGljICpwaWMgPSBwbGF0Zm9ybV9nZXRfZHJ2ZGF0YShw ZGV2KTsKPiAgCj4gIAlvbl9lYWNoX2NwdShtdmVidV9waWNfZGlzYWJsZV9wZXJjcHVfaXJxLCBw aWMsIDEpOwo+ICAJaXJxX2RvbWFpbl9yZW1vdmUocGljLT5kb21haW4pOwo+IC0KPiAtCXJldHVy biAwOwo+ICB9Cj4gIAo+ICBzdGF0aWMgY29uc3Qgc3RydWN0IG9mX2RldmljZV9pZCBtdmVidV9w aWNfb2ZfbWF0Y2hbXSA9IHsKPiBAQCAtMTg1LDcgKzE4Myw3IEBAIE1PRFVMRV9ERVZJQ0VfVEFC TEUob2YsIG12ZWJ1X3BpY19vZl9tYXRjaCk7Cj4gIAo+ICBzdGF0aWMgc3RydWN0IHBsYXRmb3Jt X2RyaXZlciBtdmVidV9waWNfZHJpdmVyID0gewo+ICAJLnByb2JlICA9IG12ZWJ1X3BpY19wcm9i ZSwKPiAtCS5yZW1vdmUgPSBtdmVidV9waWNfcmVtb3ZlLAo+ICsJLnJlbW92ZV9uZXcgPSBtdmVi dV9waWNfcmVtb3ZlLAo+ICAJLmRyaXZlciA9IHsKPiAgCQkubmFtZSA9ICJtdmVidS1waWMiLAo+ ICAJCS5vZl9tYXRjaF90YWJsZSA9IG12ZWJ1X3BpY19vZl9tYXRjaCwKPiAtLSAKPiAyLjQyLjAK PgoKLS0gCkdyZWdvcnkgQ2xlbWVudCwgQm9vdGxpbgpFbWJlZGRlZCBMaW51eCBhbmQgS2VybmVs IGVuZ2luZWVyaW5nCmh0dHA6Ly9ib290bGluLmNvbQoKX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX18KbGludXgtYXJtLWtlcm5lbCBtYWlsaW5nIGxpc3QKbGlu dXgtYXJtLWtlcm5lbEBsaXN0cy5pbmZyYWRlYWQub3JnCmh0dHA6Ly9saXN0cy5pbmZyYWRlYWQu b3JnL21haWxtYW4vbGlzdGluZm8vbGludXgtYXJtLWtlcm5lbAo= From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from relay7-d.mail.gandi.net (relay7-d.mail.gandi.net [217.70.183.200]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 40E022C688 for ; Tue, 27 Feb 2024 16:44:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=217.70.183.200 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709052249; cv=none; b=tqslgSv6tDPJB23agl13scL5oQpgDbRZtzxajycMElToYVYDhrQbBLBnIqHCDV2epqr0d16rejEkTbuMFAVdswVD2jFeZfSRSjZBHlGwPDGfllli31J40xh/RAl0Jnq32RLZ4Razf8iuDjDEf7HOs9olYzA0jRrpYAgG7Gr2uKo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709052249; c=relaxed/simple; bh=R5Z1nfb4rp2iS0jTSNix4fLmmprNlcKBtCaKntrzuGY=; h=From:To:Cc:Subject:In-Reply-To:References:Date:Message-ID: MIME-Version:Content-Type; b=rJ2hzydIqVW/bE2Japt0h0q6nORsVQ+l8WYAa7lwEYO+jH4aAR0KhEBPktfhgN8aScEGrVrZFzKQnAIFMR1CEw5K22ERpzwdlvrtpwPyv7s45rmts0n9ts6CQ76gb77MF3vrvuYlmv+NyxA+cL6O8PlueL37gBb5I8SeJhAKTUQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com; spf=pass smtp.mailfrom=bootlin.com; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b=RGuGLMKl; arc=none smtp.client-ip=217.70.183.200 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=bootlin.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b="RGuGLMKl" Received: by mail.gandi.net (Postfix) with ESMTPSA id D3F6A20002; Tue, 27 Feb 2024 16:44:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1709052245; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=76mZ13DHESmZTVSHEaVoshFTsFCTogrCRWvywDtKTWE=; b=RGuGLMKlcnyRzk7Ze4to/gJfeKNYw9LJvr5cm5DiUHmlR2n3X0/rk93nu7DP00MOxMrZ8m jxiv6bMj7wrMRgzFRmkmSZveRWikAa6pqdL0Sr+yoEBoGFy38VoW9wJIYDbTyXs2xZ2kVa 7Qty6dttcX32k+zkRIbjaYFPunVj23pEd7w5IonQDcZ9TpVqbNPVrX/QGFM4pMYDu6roVd XbGjLrZS8G8XWaMBj4FFXY5U6XlNeUyi3vA6jKlildBe10In8ry5Okluvap9TGck09eXZU 82QKnp9AmhLzhmMhy1nx1hcVYlojf67M4gTi6GwEnE32TkdG/ukdoZV8s293bA== From: Gregory CLEMENT To: Uwe =?utf-8?Q?Kleine-K=C3=B6nig?= , Thomas Gleixner Cc: Andrew Lunn , Sebastian Hesselbarth , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, kernel@pengutronix.de Subject: Re: [PATCH 07/13] irqchip/mvebu-pic: Convert to platform remove callback returning void In-Reply-To: References: Date: Tue, 27 Feb 2024 17:44:04 +0100 Message-ID: <87r0gxj1rf.fsf@BL-laptop> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-GND-Sasl: gregory.clement@bootlin.com Uwe Kleine-K=C3=B6nig writes: > The .remove() callback for a platform driver returns an int which makes > many driver authors wrongly assume it's possible to do error handling by > returning an error code. However the value returned is ignored (apart > from emitting a warning) and this typically results in resource leaks. > > To improve here there is a quest to make the remove callback return > void. In the first step of this quest all drivers are converted to > .remove_new(), which already returns void. Eventually after all drivers > are converted, .remove_new() will be renamed to .remove(). > > Trivially convert this driver from always returning zero in the remove > callback to the void returning variant. > > Signed-off-by: Uwe Kleine-K=C3=B6nig Acked-by: Gregory CLEMENT Thanks, Gregory > --- > drivers/irqchip/irq-mvebu-pic.c | 6 ++---- > 1 file changed, 2 insertions(+), 4 deletions(-) > > diff --git a/drivers/irqchip/irq-mvebu-pic.c b/drivers/irqchip/irq-mvebu-= pic.c > index ef3d3646ccc2..57e3f99b61f5 100644 > --- a/drivers/irqchip/irq-mvebu-pic.c > +++ b/drivers/irqchip/irq-mvebu-pic.c > @@ -167,14 +167,12 @@ static int mvebu_pic_probe(struct platform_device *= pdev) > return 0; > } >=20=20 > -static int mvebu_pic_remove(struct platform_device *pdev) > +static void mvebu_pic_remove(struct platform_device *pdev) > { > struct mvebu_pic *pic =3D platform_get_drvdata(pdev); >=20=20 > on_each_cpu(mvebu_pic_disable_percpu_irq, pic, 1); > irq_domain_remove(pic->domain); > - > - return 0; > } >=20=20 > static const struct of_device_id mvebu_pic_of_match[] =3D { > @@ -185,7 +183,7 @@ MODULE_DEVICE_TABLE(of, mvebu_pic_of_match); >=20=20 > static struct platform_driver mvebu_pic_driver =3D { > .probe =3D mvebu_pic_probe, > - .remove =3D mvebu_pic_remove, > + .remove_new =3D mvebu_pic_remove, > .driver =3D { > .name =3D "mvebu-pic", > .of_match_table =3D mvebu_pic_of_match, > --=20 > 2.42.0 > --=20 Gregory Clement, Bootlin Embedded Linux and Kernel engineering http://bootlin.com