From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from draig.lan ([85.9.250.243]) by smtp.gmail.com with ESMTPSA id b5-20020a5d4d85000000b00337d5aa55cdsm10350822wru.53.2024.01.22.01.50.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 22 Jan 2024 01:50:18 -0800 (PST) Received: from draig (localhost [IPv6:::1]) by draig.lan (Postfix) with ESMTP id 76C505F7AE; Mon, 22 Jan 2024 09:50:17 +0000 (GMT) From: =?utf-8?Q?Alex_Benn=C3=A9e?= To: Jan Kiszka Cc: Peter Maydell , qemu-arm@nongnu.org, qemu-devel@nongnu.org Subject: Re: [PATCH] hw/arm/musicpal: Convert to qemu_add_kbd_event_handler() In-Reply-To: <9dff82f7-d997-4092-8b5a-cd21963826da@web.de> (Jan Kiszka's message of "Sun, 21 Jan 2024 17:24:31 +0100") References: <20231103182750.855577-1-peter.maydell@linaro.org> <871qadh8g8.fsf@draig.linaro.org> <9dff82f7-d997-4092-8b5a-cd21963826da@web.de> User-Agent: mu4e 1.11.27; emacs 29.1 Date: Mon, 22 Jan 2024 09:50:17 +0000 Message-ID: <87r0i9ofxi.fsf@draig.linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-TUID: 3JEp9A3W+fi4 Jan Kiszka writes: > On 19.01.24 12:24, Alex Benn=C3=A9e wrote: >> Peter Maydell writes: >> >>> Convert the musicpal key input device to use >>> qemu_add_kbd_event_handler(). This lets us simplify it because we no >>> longer need to track whether we're in the middle of a PS/2 multibyte >>> key sequence. >> >> Well the key input all works as intended and looks good to me. I'm a >> little disappointed I couldn't get audio working on the musicpal machine >> but that is not a problem for this patch. >> >> Tested-by: Alex Benn=C3=A9e >> Reviewed-by: Alex Benn=C3=A9e >> > > Looks good to me as well, all keys still work fine. > > No idea what's the issue with sound, though. I think I haven't run the > whole stuff in a decade or so, had to search for all the pieces first of > all again. The webradio service original behind this stopped their > operations, at least for this device, but manually entered favorits > still work on the real device - I still have one, though that is > starting to get some issues as well. I navigated through the favourites and after pressing some keys it seems to indicate there was a stream of some sort (or at least a bitrate was reported ;-). The main issue I was having with sound was with pipewire - this would eventually generate a lot of warning messages because input devices are created but I guess the model wasn't draining the input buffers so eventually we get: qemu: 0x7f1490259500: overrun write:5859188 filled:5842804 + size:940 > m= ax:4194304 qemu: 0x7f14902680a0: overrun write:5860128 filled:5843744 + size:940 > m= ax:4194304 qemu: 0x7f1490259500: overrun write:5861068 filled:5844684 + size:940 > m= ax:4194304 qemu: 0x7f14902680a0: overrun write:5862008 filled:5845624 + size:940 > m= ax:4194304 Is your image just a hacked up version of the original firmware or something we have source for? I guess there was never a rockbox port for the device? > > Thanks, > Jan --=20 Alex Benn=C3=A9e Virtualisation Tech Lead @ Linaro