From: Juan Quintela <quintela@redhat.com>
To: marcandre.lureau@redhat.com
Cc: qemu-devel@nongnu.org, Kevin Wolf <kwolf@redhat.com>,
"Michael S. Tsirkin" <mst@redhat.com>,
Fabiano Rosas <farosas@suse.de>, John Snow <jsnow@redhat.com>,
Hanna Reitz <hreitz@redhat.com>,
Leonardo Bras <leobras@redhat.com>,
Samuel Thibault <samuel.thibault@ens-lyon.org>,
qemu-block@nongnu.org, Peter Xu <peterx@redhat.com>,
Jason Wang <jasowang@redhat.com>
Subject: Re: [PATCH v2 3/9] net/slirp: use different IDs for each instance
Date: Tue, 24 Oct 2023 11:26:08 +0200 [thread overview]
Message-ID: <87r0lk1idr.fsf@secure.mitica> (raw)
In-Reply-To: <20231024084043.2926316-4-marcandre.lureau@redhat.com> (marcandre lureau's message of "Tue, 24 Oct 2023 12:40:37 +0400")
marcandre.lureau@redhat.com wrote:
> From: Marc-André Lureau <marcandre.lureau@redhat.com>
>
> Using always 0, QEMU will end up loading the same instance, even if
> multiple have been saved.
>
> Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
Similar (but different) fix on next Migration PULL request.
Later, Juan.
> ---
> net/slirp.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/net/slirp.c b/net/slirp.c
> index c33b3e02e7..af1451b60f 100644
> --- a/net/slirp.c
> +++ b/net/slirp.c
> @@ -47,6 +47,7 @@
> #include "util.h"
> #include "migration/register.h"
> #include "migration/qemu-file-types.h"
> +#include "migration/vmstate.h"
>
> static int get_str_sep(char *buf, int buf_size, const char **pp, int sep)
> {
> @@ -659,7 +660,7 @@ static int net_slirp_init(NetClientState *peer, const char *model,
> * specific version?
> */
> g_assert(slirp_state_version() == 4);
> - register_savevm_live("slirp", 0, slirp_state_version(),
> + register_savevm_live("slirp", VMSTATE_INSTANCE_ID_ANY, slirp_state_version(),
> &savevm_slirp_state, s->slirp);
>
> s->poll_notifier.notify = net_slirp_poll_notify;
next prev parent reply other threads:[~2023-10-24 9:27 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-24 8:40 [PATCH v2 0/9] RFC: migration: check required entries and sections are loaded marcandre.lureau
2023-10-24 8:40 ` [PATCH v2 1/9] block/fdc: 'phase' is not needed on load marcandre.lureau
2023-10-24 8:40 ` [PATCH v2 2/9] virtio: make endian_needed() work during loading marcandre.lureau
2023-10-24 8:40 ` [PATCH v2 3/9] net/slirp: use different IDs for each instance marcandre.lureau
2023-10-24 9:26 ` Juan Quintela [this message]
2023-10-24 8:40 ` [PATCH v2 4/9] migration: rename vmstate_save_needed->vmstate_section_needed marcandre.lureau
2023-10-24 10:35 ` Juan Quintela
2023-10-24 8:40 ` [PATCH v2 5/9] migration: check required subsections are loaded, once marcandre.lureau
2023-10-24 10:41 ` Juan Quintela
2023-10-24 20:10 ` Peter Xu
2023-10-24 8:40 ` [PATCH v2 6/9] migration: check required entries " marcandre.lureau
2023-10-24 10:44 ` Juan Quintela
2023-10-24 8:40 ` [PATCH v2 7/9] migration: set file error on subsection loading marcandre.lureau
2023-10-24 9:27 ` Juan Quintela
2023-10-24 8:40 ` [PATCH v2 8/9] test-vmstate: add some subsection tests marcandre.lureau
2023-10-24 10:45 ` Juan Quintela
2023-10-24 8:40 ` [PATCH v2 9/9] docs/migration: reflect the changes about needed subsections marcandre.lureau
2023-10-24 10:47 ` Juan Quintela
2023-10-24 10:58 ` Marc-André Lureau
2023-10-24 11:08 ` Juan Quintela
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87r0lk1idr.fsf@secure.mitica \
--to=quintela@redhat.com \
--cc=farosas@suse.de \
--cc=hreitz@redhat.com \
--cc=jasowang@redhat.com \
--cc=jsnow@redhat.com \
--cc=kwolf@redhat.com \
--cc=leobras@redhat.com \
--cc=marcandre.lureau@redhat.com \
--cc=mst@redhat.com \
--cc=peterx@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=samuel.thibault@ens-lyon.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.