From: Juan Quintela <quintela@redhat.com>
To: Steve Sistare <steven.sistare@oracle.com>
Cc: qemu-devel@nongnu.org, Peter Xu <peterx@redhat.com>,
Fabiano Rosas <farosas@suse.de>,
Leonardo Bras <leobras@redhat.com>
Subject: Re: [PATCH V5] migration: simplify blockers
Date: Wed, 18 Oct 2023 15:53:38 +0200 [thread overview]
Message-ID: <87r0ls82al.fsf@secure.mitica> (raw)
In-Reply-To: <1697634216-84215-1-git-send-email-steven.sistare@oracle.com> (Steve Sistare's message of "Wed, 18 Oct 2023 06:03:36 -0700")
Steve Sistare <steven.sistare@oracle.com> wrote:
> Modify migrate_add_blocker and migrate_del_blocker to take an Error **
> reason. This allows migration to own the Error object, so that if
> an error occurs in migrate_add_blocker, migration code can free the Error
> and clear the client handle, simplifying client code. It also simplifies
> the migrate_del_blocker call site.
>
> In addition, this is a pre-requisite for a proposed future patch that would
> add a mode argument to migration requests to support live update, and
> maintain a list of blockers for each mode. A blocker may apply to a single
> mode or to multiple modes, and passing Error** will allow one Error object
> to be registered for multiple modes.
>
> No functional change.
>
> Signed-off-by: Steve Sistare <steven.sistare@oracle.com>
> Tested-by: Michael Galaxy <mgalaxy@akamai.com>
> Reviewed-by: Michael Galaxy <mgalaxy@akamai.com>
> Reviewed-by: Peter Xu <peterx@redhat.com>
Reviewed-by: Juan Quintela <quintela@redhat.com>
Something weird happened with your rebase:
(next *|AM 1/1)$ find . -name "*rej"
./block/vpc.c.rej
./block/qcow.c.rej
./block/parallels.c.rej
./block/vdi.c.rej
(next *|AM 1/1)$
trivial to fix, so I did it.
queued.
next prev parent reply other threads:[~2023-10-18 13:54 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-18 13:03 [PATCH V5] migration: simplify blockers Steve Sistare
2023-10-18 13:07 ` Steven Sistare
2023-10-18 13:53 ` Juan Quintela [this message]
2023-10-18 13:59 ` Steven Sistare
2023-10-18 17:48 ` Steven Sistare
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87r0ls82al.fsf@secure.mitica \
--to=quintela@redhat.com \
--cc=farosas@suse.de \
--cc=leobras@redhat.com \
--cc=peterx@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=steven.sistare@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.