From: Juan Quintela <quintela@redhat.com>
To: Fabiano Rosas <farosas@suse.de>
Cc: qemu-devel@nongnu.org, "Peter Xu" <peterx@redhat.com>,
"Steve Sistare" <steven.sistare@oracle.com>,
"Daniel P . Berrangé" <berrange@redhat.com>,
"Leonardo Bras" <leobras@redhat.com>
Subject: Re: [PATCH v5 4/6] migration: Set migration status early in incoming side
Date: Wed, 04 Oct 2023 16:12:54 +0200 [thread overview]
Message-ID: <87r0ma1no9.fsf@secure.mitica> (raw)
In-Reply-To: <20230712190742.22294-5-farosas@suse.de> (Fabiano Rosas's message of "Wed, 12 Jul 2023 16:07:40 -0300")
Fabiano Rosas <farosas@suse.de> wrote:
> We are sending a migration event of MIGRATION_STATUS_SETUP at
> qemu_start_incoming_migration but never actually setting the state.
>
> This creates a window between qmp_migrate_incoming and
> process_incoming_migration_co where the migration status is still
> MIGRATION_STATUS_NONE. Calling query-migrate during this time will
> return an empty response even though the incoming migration command
> has already been issued.
>
> Commit 7cf1fe6d68 ("migration: Add migration events on target side")
> has added support to the 'events' capability to the incoming part of
> migration, but chose to send the SETUP event without setting the
> state. I'm assuming this was a mistake.
>
> This introduces a change in behavior, any QMP client waiting for the
> SETUP event will hang, unless it has previously enabled the 'events'
> capability. Having the capability enabled is sufficient to continue to
> receive the event.
>
> Reviewed-by: Peter Xu <peterx@redhat.com>
> Signed-off-by: Fabiano Rosas <farosas@suse.de>
Reviewed-by: Juan Quintela <quintela@redhat.com>
next prev parent reply other threads:[~2023-10-04 14:13 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-12 19:07 [PATCH v5 0/6] migration: Test the new "file:" migration Fabiano Rosas
2023-07-12 19:07 ` [PATCH v5 1/6] tests/qtest: migration: Expose migrate_set_capability Fabiano Rosas
2023-07-12 19:07 ` [PATCH v5 2/6] tests/qtest: migration: Add migrate_incoming_qmp helper Fabiano Rosas
2023-10-04 14:11 ` Juan Quintela
2023-07-12 19:07 ` [PATCH v5 3/6] tests/qtest: migration: Use migrate_incoming_qmp where appropriate Fabiano Rosas
2023-07-12 19:07 ` [PATCH v5 4/6] migration: Set migration status early in incoming side Fabiano Rosas
2023-10-04 14:12 ` Juan Quintela [this message]
2023-07-12 19:07 ` [PATCH v5 5/6] tests/qtest: migration: Add support for negative testing of qmp_migrate Fabiano Rosas
2023-07-12 19:07 ` [PATCH v5 6/6] tests/qtest: migration-test: Add tests for file-based migration Fabiano Rosas
2023-07-19 20:08 ` Peter Xu
2023-08-22 12:04 ` [PATCH v5 0/6] migration: Test the new "file:" migration Claudio Fontana
2023-10-04 14:16 ` Juan Quintela
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87r0ma1no9.fsf@secure.mitica \
--to=quintela@redhat.com \
--cc=berrange@redhat.com \
--cc=farosas@suse.de \
--cc=leobras@redhat.com \
--cc=peterx@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=steven.sistare@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.