From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B4A6FC001DB for ; Tue, 8 Aug 2023 12:47:11 +0000 (UTC) Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 6999582C; Tue, 8 Aug 2023 14:46:18 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 6999582C DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1691498828; bh=w96gP7iQMzR5PdnPKJ7fBjxhaIsU7w7UVQuqY/6tbYs=; h=Date:From:To:Cc:Subject:In-Reply-To:References:List-Id: List-Archive:List-Help:List-Owner:List-Post:List-Subscribe: List-Unsubscribe:From; b=FM0eE9Bso/6qsbu9xlSudNMrAd6+5aVqYcePSepUcaTInkc3CTTdVlC+rkoX/+IO/ 06wIiOFyqET4CPZG0OWZl/M6v1IUEbTZvh48MDrC4rwqlKZNXzvqgdklywLj4ZOTtT l5e3RT3/rg9ecjyIax4d4nHe0oACrCA1yFtc3qKk= Received: by alsa1.perex.cz (Postfix, from userid 50401) id 79C3AF80549; Tue, 8 Aug 2023 14:45:48 +0200 (CEST) Received: from mailman-core.alsa-project.org (mailman-core.alsa-project.org [10.254.200.10]) by alsa1.perex.cz (Postfix) with ESMTP id BED9AF80534; Tue, 8 Aug 2023 14:45:47 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 491F8F80534; Tue, 8 Aug 2023 14:45:44 +0200 (CEST) Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 955A5F800FE for ; Tue, 8 Aug 2023 14:45:35 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 955A5F800FE Authentication-Results: alsa1.perex.cz; dkim=pass (1024-bit key, unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=h+LJD6xt; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=6FFEp/Qp Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 7C8AE2249A; Tue, 8 Aug 2023 12:45:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1691498734; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=9rSG2TNU59Si5m6bljaLKJEJPmpsQdVWsYgo9RPk8Vs=; b=h+LJD6xtmsMgoKzXIYajVr2dasHn2amUpZS78uy35MwyA6LFc+YHFErJpRUR9hbjdxIWQa YJ9XVnbfCsYZKIo3i86BgphvWqG0C5/h9NiOhAdaQ2SXWsUsrAugo8LQ/pn6VFbX5fq90R C1dLXUHAj8aPgfgIUsWpMkTn4GWV+eE= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1691498734; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=9rSG2TNU59Si5m6bljaLKJEJPmpsQdVWsYgo9RPk8Vs=; b=6FFEp/Qp+ZGEym7OH90haRpGWAMBMY6R3VWqQ057Pu9vyE/e4JQ8CpO41gU4SmqFVfGQFc jF3wg/4I+zhosZAg== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 53ABD139D1; Tue, 8 Aug 2023 12:45:34 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id zoV6E+440mR/AgAAMHmgww (envelope-from ); Tue, 08 Aug 2023 12:45:34 +0000 Date: Tue, 08 Aug 2023 14:45:33 +0200 Message-ID: <87r0odhfde.wl-tiwai@suse.de> From: Takashi Iwai To: Ivan Orlov Cc: perex@perex.cz, tiwai@suse.com, alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 1/2] ALSA: pcmtest: Move buffer iterator initialization to prepare callback In-Reply-To: <20230804110740.9867-1-ivan.orlov0322@gmail.com> References: <20230804110740.9867-1-ivan.orlov0322@gmail.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) Emacs/27.2 Mule/6.0 MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII Message-ID-Hash: 6JRD77ICTN6AIBEGPN5X7KGJ3HBAWDMT X-Message-ID-Hash: 6JRD77ICTN6AIBEGPN5X7KGJ3HBAWDMT X-MailFrom: tiwai@suse.de X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-alsa-devel.alsa-project.org-0; header-match-alsa-devel.alsa-project.org-1; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.8 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Fri, 04 Aug 2023 13:07:39 +0200, Ivan Orlov wrote: > > Trigger callback is not the best place for buffer iterator > initialization, so move it out to the prepare callback, where it > have to be. > > Minor enhancement: remove blank line. > > Signed-off-by: Ivan Orlov > --- > V1 -> V2: > - Split changes in the patch into two different patches Thanks, applied both patches now. Takashi