All of lore.kernel.org
 help / color / mirror / Atom feed
From: Takashi Iwai <tiwai@suse.de>
To: Oswald Buddenhagen <oswald.buddenhagen@gmx.de>
Cc: alsa-devel@alsa-project.org, Jaroslav Kysela <perex@perex.cz>
Subject: Re: [PATCH 1/2] ALSA: emu10k1: fix synthesizer sample playback position and caching
Date: Thu, 18 May 2023 16:57:07 +0200	[thread overview]
Message-ID: <87r0rdhem4.wl-tiwai@suse.de> (raw)
In-Reply-To: <20230518140339.3722308-1-oswald.buddenhagen@gmx.de>

On Thu, 18 May 2023 16:03:38 +0200,
Oswald Buddenhagen wrote:
> 
> Compensate for the cache delay, and actually populate the cache.
> Without these, the playback would start with garbage (which would be
> (mostly?) masqueraded by the attack phase).
> 
> Unlike for the PCM voices, this doesn't try to compensate for the
> interpolator read-ahead, because it's pointless to be super-exact here.
> 
> Note that this code is probably still broken for particularly short
> samples, because we ignore the loop-related parts of CCR. But I'm not
> going to reverse-engineer that now ...
> 
> Signed-off-by: Oswald Buddenhagen <oswald.buddenhagen@gmx.de>

Applied both patches now.  Thanks.


Takashi

      parent reply	other threads:[~2023-05-18 14:58 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-05-18 14:03 [PATCH 1/2] ALSA: emu10k1: fix synthesizer sample playback position and caching Oswald Buddenhagen
2023-05-18 14:03 ` [PATCH 2/2] ALSA: emu10k1: fix terminating synthesizer voices Oswald Buddenhagen
2023-05-18 14:57 ` Takashi Iwai [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87r0rdhem4.wl-tiwai@suse.de \
    --to=tiwai@suse.de \
    --cc=alsa-devel@alsa-project.org \
    --cc=oswald.buddenhagen@gmx.de \
    --cc=perex@perex.cz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.