From: Ritesh Harjani (IBM) <ritesh.list@gmail.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: Christoph Hellwig <hch@infradead.org>,
linux-fsdevel@vger.kernel.org, linux-ext4@vger.kernel.org,
Jan Kara <jack@suse.cz>, "Darrick J . Wong" <djwong@kernel.org>,
Ojaswin Mujoo <ojaswin@linux.ibm.com>
Subject: Re: [RFCv2 5/8] ext2: Move direct-io to use iomap
Date: Wed, 12 Apr 2023 19:33:51 +0530 [thread overview]
Message-ID: <87r0spyz7c.fsf@doe.com> (raw)
In-Reply-To: <ZDaZfuq+wi5KKRfs@infradead.org>
Christoph Hellwig <hch@infradead.org> writes:
> On Tue, Apr 11, 2023 at 08:51:24PM +0530, Ritesh Harjani wrote:
>> >> + if ((flags & IOMAP_WRITE) && (offset + length > i_size_read(inode)))
>> >
>> > No need for the second set of inner braces here either.
>>
>> It's just avoids any confusion this way.
>
> Does it? Except for some really weird places it is very unusual in
> the kernel. To me it really does add confusion.
Ok, In that case, will change it.
Thanks for the review!
-ritesh
next prev parent reply other threads:[~2023-04-12 14:04 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-11 5:21 [RFCv2 0/8] ext2: DIO to use iomap Ritesh Harjani (IBM)
2023-04-11 5:21 ` [RFCv2 1/8] ext2/dax: Fix ext2_setsize when len is page aligned Ritesh Harjani (IBM)
2023-04-11 14:29 ` Darrick J. Wong
2023-04-11 5:21 ` [RFCv2 2/8] libfs: Add __generic_file_fsync_nolock implementation Ritesh Harjani (IBM)
2023-04-11 5:27 ` Christoph Hellwig
2023-04-11 12:33 ` Matthew Wilcox
2023-04-11 15:12 ` Ritesh Harjani
2023-04-12 11:43 ` Christoph Hellwig
2023-04-12 14:02 ` Ritesh Harjani
2023-04-13 9:51 ` Christian Brauner
2023-04-11 5:21 ` [RFCv2 3/8] ext4: Use " Ritesh Harjani (IBM)
2023-04-11 5:21 ` [RFCv2 4/8] ext2: " Ritesh Harjani (IBM)
2023-04-11 5:21 ` [RFCv2 5/8] ext2: Move direct-io to use iomap Ritesh Harjani (IBM)
2023-04-11 5:46 ` Christoph Hellwig
2023-04-11 15:21 ` Ritesh Harjani
2023-04-12 11:43 ` Christoph Hellwig
2023-04-12 14:03 ` Ritesh Harjani [this message]
2023-04-11 5:21 ` [RFCv2 6/8] iomap: Remove IOMAP_DIO_NOSYNC unused dio flag Ritesh Harjani (IBM)
2023-04-11 5:27 ` Christoph Hellwig
2023-04-11 5:21 ` [RFCv2 7/8] fs.h: Add IOCB_STRINGS for use in trace points Ritesh Harjani (IBM)
2023-04-11 5:38 ` Christoph Hellwig
2023-04-11 5:21 ` [RFCv2 8/8] ext2: Add direct-io " Ritesh Harjani (IBM)
2023-04-11 5:38 ` Christoph Hellwig
2023-04-11 14:34 ` Darrick J. Wong
2023-04-11 15:11 ` Ritesh Harjani
2023-04-12 11:44 ` Christoph Hellwig
2023-04-12 14:07 ` Ritesh Harjani
2023-04-11 8:59 ` kernel test robot
2023-04-11 12:23 ` kernel test robot
2023-04-11 12:44 ` kernel test robot
2023-04-11 13:15 ` kernel test robot
2023-04-12 11:45 ` [RFCv2 0/8] ext2: DIO to use iomap Jan Kara
2023-04-12 14:10 ` Ritesh Harjani
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87r0spyz7c.fsf@doe.com \
--to=ritesh.list@gmail.com \
--cc=djwong@kernel.org \
--cc=hch@infradead.org \
--cc=jack@suse.cz \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=ojaswin@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.