From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D2497C636CC for ; Thu, 16 Feb 2023 17:56:09 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 2C8D710E344; Thu, 16 Feb 2023 17:56:09 +0000 (UTC) Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by gabe.freedesktop.org (Postfix) with ESMTPS id 45B6610E16E for ; Thu, 16 Feb 2023 17:56:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1676570167; x=1708106167; h=date:message-id:from:to:cc:subject:in-reply-to: references:mime-version; bh=FE1I2Ay+jqOIDkDNH/riVl1+l3KjZRNpQmV7KwMs7zw=; b=dDoMD3Yy5PeJ+aBgwcidxjxvyG7e2s5NFA7iqp1J006zhHVMArAVa49I cIYw1HDI+k7ux6AM5ROe4/exYGQeoJAUcACouBmeZGuX5n/LBVWtLXzUZ cwdHCZ15PLNMfnjXQYWTjpszHlzXVOrSCwBynekbU/3FahrMBlzsATWCY L3mtym9WXm4B1RSeA6El7Eg2/Updt+Ig1xKysA2SO6CZw+8F1khnwYCly ZTvVYQMoIaxsaoerOA7ifdL3G6tiYKDpbDQJwyJHVwPJ04UbBrF9phr5q ivEFMrQFJt2dOaSWYi78pGb1Mjt6a562hCLJh7zixqauwclimkhiMDZRe Q==; X-IronPort-AV: E=McAfee;i="6500,9779,10623"; a="311417556" X-IronPort-AV: E=Sophos;i="5.97,302,1669104000"; d="scan'208";a="311417556" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 16 Feb 2023 09:56:06 -0800 X-IronPort-AV: E=McAfee;i="6500,9779,10623"; a="700602040" X-IronPort-AV: E=Sophos;i="5.97,302,1669104000"; d="scan'208";a="700602040" Received: from adixit-mobl.amr.corp.intel.com (HELO adixit-arch.intel.com) ([10.209.69.178]) by orsmga008-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 16 Feb 2023 09:56:05 -0800 Date: Thu, 16 Feb 2023 09:55:57 -0800 Message-ID: <87r0upmr4i.wl-ashutosh.dixit@intel.com> From: "Dixit, Ashutosh" To: Jani Nikula In-Reply-To: <87lekx2895.fsf@intel.com> References: <20230215005419.2100887-1-umesh.nerlige.ramappa@intel.com> <20230215005419.2100887-6-umesh.nerlige.ramappa@intel.com> <87lekx2895.fsf@intel.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?ISO-8859-4?Q?Goj=F2?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/28.2 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII Subject: Re: [Intel-gfx] [PATCH 5/9] drm/i915/perf: Group engines into respective OA groups X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Lionel G Landwerlin , intel-gfx@lists.freedesktop.org Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" On Thu, 16 Feb 2023 02:51:34 -0800, Jani Nikula wrote: > > > +static int oa_init_gt(struct intel_gt *gt) > > +{ > > + u32 num_groups = __num_perf_groups_per_gt(gt); > > + struct intel_engine_cs *engine; > > + struct i915_perf_group *g; > > + intel_engine_mask_t tmp; > > + > > + g = kcalloc(num_groups, sizeof(*g), GFP_KERNEL); > > + if (drm_WARN_ON(>->i915->drm, !g)) > > + return -ENOMEM; > > No warnings or messages on -ENOMEM is standard policy. Hmm I think this is the only error for which this code is failing the probe. So if we are not going to fail the probe, we should at least allow a WARN_ON? Exception proves the rule?