From: "Alex Bennée" <alex.bennee@linaro.org>
To: Thomas Huth <thuth@redhat.com>
Cc: "Daniel P. Berrangé" <berrange@redhat.com>,
"Paolo Bonzini" <pbonzini@redhat.com>,
"Richard Henderson" <richard.henderson@linaro.org>,
"Peter Maydell" <peter.maydell@linaro.org>,
"Philippe Mathieu-Daudé" <philmd@linaro.org>,
qemu-devel@nongnu.org, "Laurent Vivier" <lvivier@redhat.com>
Subject: Re: float tests are too verbose (was: [PATCH v2] tests/qtest/qom-test: Do not print tested properties by default)
Date: Wed, 18 Jan 2023 15:51:36 +0000 [thread overview]
Message-ID: <87r0vrzvjd.fsf@linaro.org> (raw)
In-Reply-To: <e4fb93c6-a28d-b45c-5a7d-48d0ae33b994@redhat.com>
Thomas Huth <thuth@redhat.com> writes:
> On 17/01/2023 11.44, Daniel P. Berrangé wrote:
> ...
>> And what i think is test float being overly verbose
>> >> Testing f16_le_quiet
>> 46464 tests total.
>> 10000
>> 20000
>> 30000
>> 40000
>> 46464 tests performed.
>> Could be written as
>> >> Testing f16_le_quiet: 46464 tests total .... OK
>> (one '.' for each 10,000 tests run, before final 'OK' is printed)
>
> Unfortunately, the float tests are included via a git submodule, so
> the source code is not under our direct control here ... has anybody a
> good idea how to get this tackled best?
It is under our control. It is a lightly patched version of the
downstream testfloat package so we can patch it some more.
That said reducing 5 lines to one is hardly a massive reduction. If we
just stopped passing V=1 you would get:
➜ make check-softfloat
GIT ui/keycodemapdb meson tests/fp/berkeley-testfloat-3 tests/fp/berkeley-softfloat-3 dtc roms/SLOF
[1/1] Generating qemu-version.h with a custom command (wrapped by meson to capture output)
/usr/bin/python3 -B /home/alex/lsrc/qemu.git/meson/meson.py test --no-rebuild -t 0 --num-processes 1 --print-errorlogs --suite softfloat
1/17 qemu:softfloat+softfloat-conv / fp-test-float-to-float OK 0.02s
2/17 qemu:softfloat+softfloat-conv / fp-test-int-to-float OK 0.01s
3/17 qemu:softfloat+softfloat-conv / fp-test-uint-to-float OK 0.01s
4/17 qemu:softfloat+softfloat-conv / fp-test-float-to-int OK 0.02s
5/17 qemu:softfloat+softfloat-conv / fp-test-float-to-uint OK 0.01s
6/17 qemu:softfloat+softfloat-conv / fp-test-round-to-integer OK 0.01s
7/17 qemu:softfloat+softfloat-compare / fp-test-eq_signaling OK 0.05s
8/17 qemu:softfloat+softfloat-compare / fp-test-le OK 0.05s
9/17 qemu:softfloat+softfloat-compare / fp-test-le_quiet OK 0.05s
10/17 qemu:softfloat+softfloat-compare / fp-test-lt_quiet OK 0.05s
11/17 qemu:softfloat+softfloat-ops / fp-test-add OK 0.58s
12/17 qemu:softfloat+softfloat-ops / fp-test-sub OK 0.59s
13/17 qemu:softfloat+softfloat-ops / fp-test-mul OK 2.83s
14/17 qemu:softfloat+softfloat-ops / fp-test-div OK 2.11s
15/17 qemu:softfloat+softfloat-ops / fp-test-rem OK 1.27s
16/17 qemu:softfloat+softfloat-ops / fp-test-sqrt OK 0.03s
17/17 qemu:softfloat+softfloat-ops / fp-test-log2 OK 0.02s
Ok: 17
Expected Fail: 0
Fail: 0
Unexpected Pass: 0
Skipped: 0
Timeout: 0
Full log written to /home/alex/lsrc/qemu.git/builds/all/meson-logs/testlog.txt
with the testlog being:
wc -l meson-logs/testlog.txt
2553 meson-logs/testlog.txt
>
> Thomas
--
Alex Bennée
Virtualisation Tech Lead @ Linaro
prev parent reply other threads:[~2023-01-18 15:56 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-15 15:30 [PATCH v2] tests/qtest/qom-test: Do not print tested properties by default Thomas Huth
2023-01-16 13:55 ` Philippe Mathieu-Daudé
2023-01-16 16:55 ` Peter Maydell
2023-01-17 10:23 ` Peter Maydell
2023-01-17 10:32 ` Thomas Huth
2023-01-17 10:44 ` Daniel P. Berrangé
2023-01-17 11:16 ` Peter Maydell
2023-01-17 12:02 ` Daniel P. Berrangé
2023-01-17 12:22 ` Peter Maydell
2023-01-17 12:26 ` Daniel P. Berrangé
2023-01-18 12:55 ` Thomas Huth
2023-01-18 12:57 ` Daniel P. Berrangé
2023-01-18 13:09 ` float tests are too verbose (was: [PATCH v2] tests/qtest/qom-test: Do not print tested properties by default) Thomas Huth
2023-01-18 15:51 ` Alex Bennée [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87r0vrzvjd.fsf@linaro.org \
--to=alex.bennee@linaro.org \
--cc=berrange@redhat.com \
--cc=lvivier@redhat.com \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=philmd@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=richard.henderson@linaro.org \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.