From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 1207AC4332F for ; Mon, 28 Nov 2022 00:10:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-ID:Date:References :In-Reply-To:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=e26mVyItUEvG3Y1x/JWm+g8PeJEtuF+i3jNp5wiETwk=; b=Ftw5PCESmo2YXH /TVdSEh/77YBpWPs9KoJTu3osBFzYZQ8WoQ0cd3d7DQOI8+CLaxCXPRu3zo1IsfIbs+NbdHU0YBl+ PJWlQSxvGPzSet6xbXiuAJBsj6a1a3R/z17HncN4TsdyA46BXLwVpD8NNL+CeQS3OMM7hNhOW6iwl gQ9f+IOdLC9TmfmadDlWUSvp2qglDLabKGYjhbvCPywg7sHt0061ij7MrO7SXLzZsDtgYCik/Wj7D Fe9qnCcfsbtTm3PrEf4U6dfIX0Nrz5UOu66/Fwqsc3ydCShG5caw6OOwycUEyJmAwBXg+tAPBH74o d3uJ8qiEueWr9GEI3qbA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1ozRig-00EKlS-69; Mon, 28 Nov 2022 00:09:58 +0000 Received: from relay10.mail.gandi.net ([217.70.178.230]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1ozRic-00EKjo-AQ for linux-arm-kernel@lists.infradead.org; Mon, 28 Nov 2022 00:09:56 +0000 Received: (Authenticated sender: gregory.clement@bootlin.com) by mail.gandi.net (Postfix) with ESMTPSA id 37AF8240003; Mon, 28 Nov 2022 00:09:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1669594190; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Ybv7gENJyTR/kPaS82sTWfCOIaSg+Tq6OBZhSLuHKXA=; b=llmc7EBnLW8lgY9XCNhvhM0+Pl61OQNJmuJkiTvIU/1fAK4M6Rdcu62Hcom6lmpQSTkwpN ugdvWtf/XgKM4CZUjiXnOfqNu6SQJFohqnP2mYSXiA8gJNZwbsY9aISVf+D8AqU4vPS0SU XsWVMycjXX/owT7ckT7kTfXAUGWWasJbOASke6qaok1uHzPHqNegJ5icIa3aeoRIyRhzX1 A8lVPFuh+WeaSCiNU7C3MNjAG2Rk2XehcZsKfGZ2I3nd8O8SGn3gyYOAAr/hc+gsgXmF07 ojAu9cwke8iDOT1q9IkmWDDDAW+iapV2AyI+zYPjqOFiVniXb4Am/pfwmoI5AQ== From: Gregory CLEMENT To: Pierre Gondois , linux-kernel@vger.kernel.org Cc: pierre.gondois@arm.com, Rob.Herring@arm.com, Rob Herring , Krzysztof Kozlowski , Andrew Lunn , Sebastian Hesselbarth , Vadym Kochan , Chris Packham , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH 10/20] arm64: dts: Update cache properties for marvell In-Reply-To: <20221031092020.532456-1-pierre.gondois@arm.com> References: <20221031092020.532456-1-pierre.gondois@arm.com> Date: Mon, 28 Nov 2022 01:09:48 +0100 Message-ID: <87r0xo7xdf.fsf@BL-laptop> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20221127_160954_647455_EAD9C72F X-CRM114-Status: GOOD ( 12.94 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Pierre Gondois writes: > The DeviceTree Specification v0.3 specifies that the cache node > 'compatible' and 'cache-level' properties are 'required'. Cf. > s3.8 Multi-level and Shared Cache Nodes > > The recently added init_of_cache_level() function checks > these properties. Add them if missing. > > Signed-off-by: Pierre Gondois Applied on mvebu/dt64 Thanks, Gregory > --- > arch/arm64/boot/dts/marvell/ac5-98dx25xx.dtsi | 1 + > arch/arm64/boot/dts/marvell/armada-ap806-dual.dtsi | 1 + > arch/arm64/boot/dts/marvell/armada-ap806-quad.dtsi | 2 ++ > arch/arm64/boot/dts/marvell/armada-ap807-quad.dtsi | 2 ++ > 4 files changed, 6 insertions(+) > > diff --git a/arch/arm64/boot/dts/marvell/ac5-98dx25xx.dtsi b/arch/arm64/boot/dts/marvell/ac5-98dx25xx.dtsi > index 80b44c7df56a..d4770acec6ac 100644 > --- a/arch/arm64/boot/dts/marvell/ac5-98dx25xx.dtsi > +++ b/arch/arm64/boot/dts/marvell/ac5-98dx25xx.dtsi > @@ -49,6 +49,7 @@ cpu1: cpu@1 { > > l2: l2-cache { > compatible = "cache"; > + cache-level = <2>; > }; > }; > > diff --git a/arch/arm64/boot/dts/marvell/armada-ap806-dual.dtsi b/arch/arm64/boot/dts/marvell/armada-ap806-dual.dtsi > index fcab5173fe67..990f70303fe6 100644 > --- a/arch/arm64/boot/dts/marvell/armada-ap806-dual.dtsi > +++ b/arch/arm64/boot/dts/marvell/armada-ap806-dual.dtsi > @@ -51,6 +51,7 @@ l2: l2-cache { > cache-size = <0x80000>; > cache-line-size = <64>; > cache-sets = <512>; > + cache-level = <2>; > }; > }; > > diff --git a/arch/arm64/boot/dts/marvell/armada-ap806-quad.dtsi b/arch/arm64/boot/dts/marvell/armada-ap806-quad.dtsi > index 3db427122f9e..a7b8e001cc9c 100644 > --- a/arch/arm64/boot/dts/marvell/armada-ap806-quad.dtsi > +++ b/arch/arm64/boot/dts/marvell/armada-ap806-quad.dtsi > @@ -81,6 +81,7 @@ l2_0: l2-cache0 { > cache-size = <0x80000>; > cache-line-size = <64>; > cache-sets = <512>; > + cache-level = <2>; > }; > > l2_1: l2-cache1 { > @@ -88,6 +89,7 @@ l2_1: l2-cache1 { > cache-size = <0x80000>; > cache-line-size = <64>; > cache-sets = <512>; > + cache-level = <2>; > }; > }; > }; > diff --git a/arch/arm64/boot/dts/marvell/armada-ap807-quad.dtsi b/arch/arm64/boot/dts/marvell/armada-ap807-quad.dtsi > index 68782f161f12..7740098fd108 100644 > --- a/arch/arm64/boot/dts/marvell/armada-ap807-quad.dtsi > +++ b/arch/arm64/boot/dts/marvell/armada-ap807-quad.dtsi > @@ -81,6 +81,7 @@ l2_0: l2-cache0 { > cache-size = <0x80000>; > cache-line-size = <64>; > cache-sets = <512>; > + cache-level = <2>; > }; > > l2_1: l2-cache1 { > @@ -88,6 +89,7 @@ l2_1: l2-cache1 { > cache-size = <0x80000>; > cache-line-size = <64>; > cache-sets = <512>; > + cache-level = <2>; > }; > }; > }; > -- > 2.25.1 > -- Gregory Clement, Bootlin Embedded Linux and Kernel engineering http://bootlin.com _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 88A53C4332F for ; Mon, 28 Nov 2022 00:09:56 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229515AbiK1AJz (ORCPT ); Sun, 27 Nov 2022 19:09:55 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48866 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229509AbiK1AJz (ORCPT ); Sun, 27 Nov 2022 19:09:55 -0500 Received: from relay10.mail.gandi.net (relay10.mail.gandi.net [217.70.178.230]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2577B1006F; Sun, 27 Nov 2022 16:09:51 -0800 (PST) Received: (Authenticated sender: gregory.clement@bootlin.com) by mail.gandi.net (Postfix) with ESMTPSA id 37AF8240003; Mon, 28 Nov 2022 00:09:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1669594190; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Ybv7gENJyTR/kPaS82sTWfCOIaSg+Tq6OBZhSLuHKXA=; b=llmc7EBnLW8lgY9XCNhvhM0+Pl61OQNJmuJkiTvIU/1fAK4M6Rdcu62Hcom6lmpQSTkwpN ugdvWtf/XgKM4CZUjiXnOfqNu6SQJFohqnP2mYSXiA8gJNZwbsY9aISVf+D8AqU4vPS0SU XsWVMycjXX/owT7ckT7kTfXAUGWWasJbOASke6qaok1uHzPHqNegJ5icIa3aeoRIyRhzX1 A8lVPFuh+WeaSCiNU7C3MNjAG2Rk2XehcZsKfGZ2I3nd8O8SGn3gyYOAAr/hc+gsgXmF07 ojAu9cwke8iDOT1q9IkmWDDDAW+iapV2AyI+zYPjqOFiVniXb4Am/pfwmoI5AQ== From: Gregory CLEMENT To: Pierre Gondois , linux-kernel@vger.kernel.org Cc: pierre.gondois@arm.com, Rob.Herring@arm.com, Rob Herring , Krzysztof Kozlowski , Andrew Lunn , Sebastian Hesselbarth , Vadym Kochan , Chris Packham , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH 10/20] arm64: dts: Update cache properties for marvell In-Reply-To: <20221031092020.532456-1-pierre.gondois@arm.com> References: <20221031092020.532456-1-pierre.gondois@arm.com> Date: Mon, 28 Nov 2022 01:09:48 +0100 Message-ID: <87r0xo7xdf.fsf@BL-laptop> MIME-Version: 1.0 Content-Type: text/plain Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org Pierre Gondois writes: > The DeviceTree Specification v0.3 specifies that the cache node > 'compatible' and 'cache-level' properties are 'required'. Cf. > s3.8 Multi-level and Shared Cache Nodes > > The recently added init_of_cache_level() function checks > these properties. Add them if missing. > > Signed-off-by: Pierre Gondois Applied on mvebu/dt64 Thanks, Gregory > --- > arch/arm64/boot/dts/marvell/ac5-98dx25xx.dtsi | 1 + > arch/arm64/boot/dts/marvell/armada-ap806-dual.dtsi | 1 + > arch/arm64/boot/dts/marvell/armada-ap806-quad.dtsi | 2 ++ > arch/arm64/boot/dts/marvell/armada-ap807-quad.dtsi | 2 ++ > 4 files changed, 6 insertions(+) > > diff --git a/arch/arm64/boot/dts/marvell/ac5-98dx25xx.dtsi b/arch/arm64/boot/dts/marvell/ac5-98dx25xx.dtsi > index 80b44c7df56a..d4770acec6ac 100644 > --- a/arch/arm64/boot/dts/marvell/ac5-98dx25xx.dtsi > +++ b/arch/arm64/boot/dts/marvell/ac5-98dx25xx.dtsi > @@ -49,6 +49,7 @@ cpu1: cpu@1 { > > l2: l2-cache { > compatible = "cache"; > + cache-level = <2>; > }; > }; > > diff --git a/arch/arm64/boot/dts/marvell/armada-ap806-dual.dtsi b/arch/arm64/boot/dts/marvell/armada-ap806-dual.dtsi > index fcab5173fe67..990f70303fe6 100644 > --- a/arch/arm64/boot/dts/marvell/armada-ap806-dual.dtsi > +++ b/arch/arm64/boot/dts/marvell/armada-ap806-dual.dtsi > @@ -51,6 +51,7 @@ l2: l2-cache { > cache-size = <0x80000>; > cache-line-size = <64>; > cache-sets = <512>; > + cache-level = <2>; > }; > }; > > diff --git a/arch/arm64/boot/dts/marvell/armada-ap806-quad.dtsi b/arch/arm64/boot/dts/marvell/armada-ap806-quad.dtsi > index 3db427122f9e..a7b8e001cc9c 100644 > --- a/arch/arm64/boot/dts/marvell/armada-ap806-quad.dtsi > +++ b/arch/arm64/boot/dts/marvell/armada-ap806-quad.dtsi > @@ -81,6 +81,7 @@ l2_0: l2-cache0 { > cache-size = <0x80000>; > cache-line-size = <64>; > cache-sets = <512>; > + cache-level = <2>; > }; > > l2_1: l2-cache1 { > @@ -88,6 +89,7 @@ l2_1: l2-cache1 { > cache-size = <0x80000>; > cache-line-size = <64>; > cache-sets = <512>; > + cache-level = <2>; > }; > }; > }; > diff --git a/arch/arm64/boot/dts/marvell/armada-ap807-quad.dtsi b/arch/arm64/boot/dts/marvell/armada-ap807-quad.dtsi > index 68782f161f12..7740098fd108 100644 > --- a/arch/arm64/boot/dts/marvell/armada-ap807-quad.dtsi > +++ b/arch/arm64/boot/dts/marvell/armada-ap807-quad.dtsi > @@ -81,6 +81,7 @@ l2_0: l2-cache0 { > cache-size = <0x80000>; > cache-line-size = <64>; > cache-sets = <512>; > + cache-level = <2>; > }; > > l2_1: l2-cache1 { > @@ -88,6 +89,7 @@ l2_1: l2-cache1 { > cache-size = <0x80000>; > cache-line-size = <64>; > cache-sets = <512>; > + cache-level = <2>; > }; > }; > }; > -- > 2.25.1 > -- Gregory Clement, Bootlin Embedded Linux and Kernel engineering http://bootlin.com