From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 27CEEC433FE for ; Wed, 9 Nov 2022 10:36:53 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 20CCB10E541; Wed, 9 Nov 2022 10:36:52 +0000 (UTC) Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by gabe.freedesktop.org (Postfix) with ESMTPS id 77D4410E541 for ; Wed, 9 Nov 2022 10:36:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1667990209; x=1699526209; h=from:to:subject:in-reply-to:references:date:message-id: mime-version; bh=Rewm5LrsI+2tII5lDoDAmHQpnQwMT2jj2/AyygbuXKM=; b=VA6F7k1VreWItZ6V0LXMp9JU2opSwMvCDvVrVLiJDx4lAPZ8VLouGrJ6 nojBDX++6yJWzg1tvI2L4wdMxfw0li+XF+wiUxIc18++2/1sw3OaEdVsS CeyydTkiKU6jip8CvRuyx1QVmRpriCElTX6Cg4Fv7YanaaL6AZEUaF1TW okwlsDOlMyB+PuIlTyAPDRGxQEqUCWDNsHlHdZj1nSSFHiL32cBg/SAq5 QtCisoSX3kNf0a61VtUZK+S6tx/+7PKB3HP8glq1goFl9SfNkpO9BoHR8 sYC3+uZ3WS8bts16qRggA57I4easPiZcj6rGZkkaYYWqFhqGqnD9L7owN A==; X-IronPort-AV: E=McAfee;i="6500,9779,10525"; a="290661928" X-IronPort-AV: E=Sophos;i="5.96,150,1665471600"; d="scan'208";a="290661928" Received: from orsmga003.jf.intel.com ([10.7.209.27]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 09 Nov 2022 02:36:48 -0800 X-IronPort-AV: E=McAfee;i="6500,9779,10525"; a="587722640" X-IronPort-AV: E=Sophos;i="5.96,150,1665471600"; d="scan'208";a="587722640" Received: from skorobko-mobl2.ccr.corp.intel.com (HELO localhost) ([10.252.15.56]) by orsmga003-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 09 Nov 2022 02:36:47 -0800 From: Jani Nikula To: Nischal Varide , intel-gfx@lists.freedesktop.org, nischal.varide@intel.com In-Reply-To: <20221109040324.17675-1-nischal.varide@intel.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo References: <20221109040324.17675-1-nischal.varide@intel.com> Date: Wed, 09 Nov 2022 12:36:44 +0200 Message-ID: <87r0yc76tf.fsf@intel.com> MIME-Version: 1.0 Content-Type: text/plain Subject: Re: [Intel-gfx] [PATCH] drm/i915/display: mode clock check related to max dotclk frequency X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" On Wed, 09 Nov 2022, Nischal Varide wrote: > A check on mode->clock to see if is greater than i915->max_dotclk_freq > or greater than 2 * (i915_max_dotclk_freq) in case of big-joiner and > return an -EINVAL in both the cases The commit message should explain *why* the change is being done. > > Signed-off-by: Nischal Varide > --- > drivers/gpu/drm/i915/display/intel_dp.c | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/drivers/gpu/drm/i915/display/intel_dp.c b/drivers/gpu/drm/i915/display/intel_dp.c > index 7400d6b4c587..813f4c369dda 100644 > --- a/drivers/gpu/drm/i915/display/intel_dp.c > +++ b/drivers/gpu/drm/i915/display/intel_dp.c > @@ -995,6 +995,10 @@ intel_dp_mode_valid(struct drm_connector *_connector, > bigjoiner = true; > max_dotclk *= 2; > } > + > + if (mode->clock > max_dotclk) > + return -EINVAL; > + The return type of this function is enum drm_mode_status, which indicates the reason for rejecting the mode. It's not a negative error code. Near the top of the function we have "target_clock = mode->clock;" making the above identical to the check we already have below. Apart from the incorrect return code. What are you trying to do? BR, Jani. > if (target_clock > max_dotclk) > return MODE_CLOCK_HIGH; -- Jani Nikula, Intel Open Source Graphics Center