From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id E6E9AC54EE9 for ; Sat, 17 Sep 2022 09:08:14 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229505AbiIQJIL (ORCPT ); Sat, 17 Sep 2022 05:08:11 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52610 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229633AbiIQJIJ (ORCPT ); Sat, 17 Sep 2022 05:08:09 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9153624967 for ; Sat, 17 Sep 2022 02:08:08 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id BF1E1B80D17 for ; Sat, 17 Sep 2022 09:08:06 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 48B08C433D6; Sat, 17 Sep 2022 09:08:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1663405685; bh=ZGkhUkWuk8O6FGtDo+ewloUu7qTFPamdLWHiwslNMJA=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=QNIPTr2at0/GdE15O+S2UO8yNVvBVal+rfgDYKEJyb/h58FQnOtll6mZv+QY8shNV A4//TfMQZ47MOKWYOoLLfjAzUzI3z4hHYFh3OrGwUdzBj68DvhHSFzFFgNnKC1YFt2 3rfHsJzGCewyuOxcLJ1AKIf8ChyVOnypLso0wD3i/vnfbZ+sowqaV8PnIySYMITD2b +hc4aDDYYdQQnfP+MSsj21bP9zBripdxfiTcY+nK1z67slRK3T8kGj07LWFUGg9fDS SA623+rAtZKR+XE2zlUT59cUAgELH0Zf/7Z4A0gqLcyES9quyV9gtqBlpueRhGrX9N kUoaSiTEfK8ig== Received: from 185-176-101-241.host.sccbroadband.ie ([185.176.101.241] helo=wait-a-minute.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1oZTly-00AlYk-PG; Sat, 17 Sep 2022 10:08:03 +0100 Date: Sat, 17 Sep 2022 10:05:59 +0100 Message-ID: <87r10al6a0.wl-maz@kernel.org> From: Marc Zyngier To: Lorenzo Pieralisi Cc: Marek =?UTF-8?B?QmVow7pu?= , Lorenzo Pieralisi , Bjorn Helgaas , Krzysztof =?UTF-8?B?V2lsY3p5xYRza2k=?= , pali@kernel.org, linux-pci@vger.kernel.org, linux-arm-kernel@lists.infradead.org, tglx@linutronix.de Subject: Re: [PATCH 03/11] PCI: aardvark: Add support for DLLSC and hotplug interrupt In-Reply-To: References: <20220818135140.5996-1-kabel@kernel.org> <20220818135140.5996-4-kabel@kernel.org> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/27.1 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-SA-Exim-Connect-IP: 185.176.101.241 X-SA-Exim-Rcpt-To: lpieralisi@kernel.org, kabel@kernel.org, lorenzo.pieralisi@arm.com, helgaas@kernel.org, kw@linux.com, pali@kernel.org, linux-pci@vger.kernel.org, linux-arm-kernel@lists.infradead.org, tglx@linutronix.de X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false Precedence: bulk List-ID: X-Mailing-List: linux-pci@vger.kernel.org Hi Lorenzo, On Fri, 09 Sep 2022 15:57:11 +0100, Lorenzo Pieralisi wrote: >=20 > [+Marc, Thomas - I can't merge this code without them reviewing it, > I am not sure at all you can mix the timer/IRQ code the way you do] >=20 > On Thu, Aug 18, 2022 at 03:51:32PM +0200, Marek Beh=C3=BAn wrote: > > From: Pali Roh=C3=A1r > >=20 > > Add support for Data Link Layer State Change in the emulated slot > > registers and hotplug interrupt via the emulated root bridge. > >=20 > > This is mainly useful for when an error causes link down event. With > > this change, drivers can try recovery. > >=20 > > Link down state change can be implemented because Aardvark supports Link > > Down event interrupt. Use it for signaling that Data Link Layer Link is > > not active anymore via Hot-Plug Interrupt on emulated root bridge. > >=20 > > Link up interrupt is not available on Aardvark, but we check for whether > > link is up in the advk_pcie_link_up() function. By triggering Hot-Plug > > Interrupt from this function we achieve Link up event, so long as the > > function is called (which it is after probe and when rescanning). > > Although it is not ideal, it is better than nothing. >=20 > So before even coming to the code review: this patch does two things. >=20 > 1) It adds support for handling the Link down state > 2) It adds some code to emulate a Link-up event >=20 > Now, for (2). IIUC you are adding code to make sure that an HP > event is triggered if advk_pcie_link_up() is called and it > detects a Link-down->Link-up transition, that has to be notified > through an HP event. >=20 > If that's correct, you have to explain to me please what this is > actually achieving and a specific scenario where we want this to be > implemented, in fine details; then we add it to the commit log. >=20 > That aside, the interaction of the timer and the IRQ domain code > must be reviewed by Marc and Thomas to make sure this is not > a gross violation of the respective subsystems usage. I don't see anything being a "gross violation" here, at least from an interrupt subsystem perspective. In a way, this is synthesising an interrupt on the back of some other event, and as long as the context is somehow appropriate (something that looks like an interrupt when pretending there is one), this should be OK. Other subsystems such as i2c GPIO expanders do similar things. The one thing I'm dubious about is the frequency of the timer. Asking for a poll of the link every jiffy is bound to be expensive, and it would be good to relax this as much as possible, specially on low-end HW such as this, where every cycle counts. It is always going to be a "best effort" thing, and the commit message doesn't say what's the actual grace period to handle this (the spec probably has one). I guess this patch could do with being split between handling link down and link up events, but that's for you to decide. Thanks, M. --=20 Without deviation from the norm, progress is not possible. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 61029C54EE9 for ; Sat, 17 Sep 2022 09:09:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Subject:Cc:To:From:Message-ID:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=vhl0B5rU7AkF8WDQLaW5zpGVInj3PjQ74Zu5rwkrrCY=; b=OF2gzLBqeHdH3l JdKec+8U2hmoKLgJKo377ZLson0fo3Cz4AsTSQ4OTRXmw7xHwlsNm3AIHj25Skw+63+jGQIBkDcU3 blt6iB2mbShAVeKt6SSp+WmnAo98FWj6tRkWy1kyC5dlc8cO6TEdRK/3ujhvgXUKxSIEMRjpmsd/U WfaZLXAN1raNXC89Sl/xF1WZaiCDs0wM83mFf+nV5bLN0qUPXuHqkD4IjKaWL4BJ1wx86vm27H/qP kAJa0p2sEowyPca43+OtsuEY7yUGrS5XUdNdhbTTU+RSTxFOWmDI9NMdjnW2zbi1ynDqWC8yUMJF3 lPb6vAR4BIl30Zph/VkA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oZTo6-004mlq-57; Sat, 17 Sep 2022 09:08:14 +0000 Received: from ams.source.kernel.org ([145.40.68.75]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1oZTo1-004mj5-SB for linux-arm-kernel@lists.infradead.org; Sat, 17 Sep 2022 09:08:11 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id A92ADB80D13; Sat, 17 Sep 2022 09:08:06 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 48B08C433D6; Sat, 17 Sep 2022 09:08:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1663405685; bh=ZGkhUkWuk8O6FGtDo+ewloUu7qTFPamdLWHiwslNMJA=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=QNIPTr2at0/GdE15O+S2UO8yNVvBVal+rfgDYKEJyb/h58FQnOtll6mZv+QY8shNV A4//TfMQZ47MOKWYOoLLfjAzUzI3z4hHYFh3OrGwUdzBj68DvhHSFzFFgNnKC1YFt2 3rfHsJzGCewyuOxcLJ1AKIf8ChyVOnypLso0wD3i/vnfbZ+sowqaV8PnIySYMITD2b +hc4aDDYYdQQnfP+MSsj21bP9zBripdxfiTcY+nK1z67slRK3T8kGj07LWFUGg9fDS SA623+rAtZKR+XE2zlUT59cUAgELH0Zf/7Z4A0gqLcyES9quyV9gtqBlpueRhGrX9N kUoaSiTEfK8ig== Received: from 185-176-101-241.host.sccbroadband.ie ([185.176.101.241] helo=wait-a-minute.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1oZTly-00AlYk-PG; Sat, 17 Sep 2022 10:08:03 +0100 Date: Sat, 17 Sep 2022 10:05:59 +0100 Message-ID: <87r10al6a0.wl-maz@kernel.org> From: Marc Zyngier To: Lorenzo Pieralisi Cc: Marek =?UTF-8?B?QmVow7pu?= , Lorenzo Pieralisi , Bjorn Helgaas , Krzysztof =?UTF-8?B?V2lsY3p5xYRza2k=?= , pali@kernel.org, linux-pci@vger.kernel.org, linux-arm-kernel@lists.infradead.org, tglx@linutronix.de Subject: Re: [PATCH 03/11] PCI: aardvark: Add support for DLLSC and hotplug interrupt In-Reply-To: References: <20220818135140.5996-1-kabel@kernel.org> <20220818135140.5996-4-kabel@kernel.org> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/27.1 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") X-SA-Exim-Connect-IP: 185.176.101.241 X-SA-Exim-Rcpt-To: lpieralisi@kernel.org, kabel@kernel.org, lorenzo.pieralisi@arm.com, helgaas@kernel.org, kw@linux.com, pali@kernel.org, linux-pci@vger.kernel.org, linux-arm-kernel@lists.infradead.org, tglx@linutronix.de X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220917_020810_248860_E01A4A32 X-CRM114-Status: GOOD ( 33.99 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org SGkgTG9yZW56bywKCk9uIEZyaSwgMDkgU2VwIDIwMjIgMTU6NTc6MTEgKzAxMDAsCkxvcmVuem8g UGllcmFsaXNpIDxscGllcmFsaXNpQGtlcm5lbC5vcmc+IHdyb3RlOgo+IAo+IFsrTWFyYywgVGhv bWFzIC0gSSBjYW4ndCBtZXJnZSB0aGlzIGNvZGUgd2l0aG91dCB0aGVtIHJldmlld2luZyBpdCwK PiBJIGFtIG5vdCBzdXJlIGF0IGFsbCB5b3UgY2FuIG1peCB0aGUgdGltZXIvSVJRIGNvZGUgdGhl IHdheSB5b3UgZG9dCj4gCj4gT24gVGh1LCBBdWcgMTgsIDIwMjIgYXQgMDM6NTE6MzJQTSArMDIw MCwgTWFyZWsgQmVow7puIHdyb3RlOgo+ID4gRnJvbTogUGFsaSBSb2jDoXIgPHBhbGlAa2VybmVs Lm9yZz4KPiA+IAo+ID4gQWRkIHN1cHBvcnQgZm9yIERhdGEgTGluayBMYXllciBTdGF0ZSBDaGFu Z2UgaW4gdGhlIGVtdWxhdGVkIHNsb3QKPiA+IHJlZ2lzdGVycyBhbmQgaG90cGx1ZyBpbnRlcnJ1 cHQgdmlhIHRoZSBlbXVsYXRlZCByb290IGJyaWRnZS4KPiA+IAo+ID4gVGhpcyBpcyBtYWlubHkg dXNlZnVsIGZvciB3aGVuIGFuIGVycm9yIGNhdXNlcyBsaW5rIGRvd24gZXZlbnQuIFdpdGgKPiA+ IHRoaXMgY2hhbmdlLCBkcml2ZXJzIGNhbiB0cnkgcmVjb3ZlcnkuCj4gPiAKPiA+IExpbmsgZG93 biBzdGF0ZSBjaGFuZ2UgY2FuIGJlIGltcGxlbWVudGVkIGJlY2F1c2UgQWFyZHZhcmsgc3VwcG9y dHMgTGluawo+ID4gRG93biBldmVudCBpbnRlcnJ1cHQuIFVzZSBpdCBmb3Igc2lnbmFsaW5nIHRo YXQgRGF0YSBMaW5rIExheWVyIExpbmsgaXMKPiA+IG5vdCBhY3RpdmUgYW55bW9yZSB2aWEgSG90 LVBsdWcgSW50ZXJydXB0IG9uIGVtdWxhdGVkIHJvb3QgYnJpZGdlLgo+ID4gCj4gPiBMaW5rIHVw IGludGVycnVwdCBpcyBub3QgYXZhaWxhYmxlIG9uIEFhcmR2YXJrLCBidXQgd2UgY2hlY2sgZm9y IHdoZXRoZXIKPiA+IGxpbmsgaXMgdXAgaW4gdGhlIGFkdmtfcGNpZV9saW5rX3VwKCkgZnVuY3Rp b24uIEJ5IHRyaWdnZXJpbmcgSG90LVBsdWcKPiA+IEludGVycnVwdCBmcm9tIHRoaXMgZnVuY3Rp b24gd2UgYWNoaWV2ZSBMaW5rIHVwIGV2ZW50LCBzbyBsb25nIGFzIHRoZQo+ID4gZnVuY3Rpb24g aXMgY2FsbGVkICh3aGljaCBpdCBpcyBhZnRlciBwcm9iZSBhbmQgd2hlbiByZXNjYW5uaW5nKS4K PiA+IEFsdGhvdWdoIGl0IGlzIG5vdCBpZGVhbCwgaXQgaXMgYmV0dGVyIHRoYW4gbm90aGluZy4K PiAKPiBTbyBiZWZvcmUgZXZlbiBjb21pbmcgdG8gdGhlIGNvZGUgcmV2aWV3OiB0aGlzIHBhdGNo IGRvZXMgdHdvIHRoaW5ncy4KPiAKPiAxKSBJdCBhZGRzIHN1cHBvcnQgZm9yIGhhbmRsaW5nIHRo ZSBMaW5rIGRvd24gc3RhdGUKPiAyKSBJdCBhZGRzIHNvbWUgY29kZSB0byBlbXVsYXRlIGEgTGlu ay11cCBldmVudAo+IAo+IE5vdywgZm9yICgyKS4gSUlVQyB5b3UgYXJlIGFkZGluZyBjb2RlIHRv IG1ha2Ugc3VyZSB0aGF0IGFuIEhQCj4gZXZlbnQgaXMgdHJpZ2dlcmVkIGlmIGFkdmtfcGNpZV9s aW5rX3VwKCkgaXMgY2FsbGVkIGFuZCBpdAo+IGRldGVjdHMgYSBMaW5rLWRvd24tPkxpbmstdXAg dHJhbnNpdGlvbiwgdGhhdCBoYXMgdG8gYmUgbm90aWZpZWQKPiB0aHJvdWdoIGFuIEhQIGV2ZW50 Lgo+IAo+IElmIHRoYXQncyBjb3JyZWN0LCB5b3UgaGF2ZSB0byBleHBsYWluIHRvIG1lIHBsZWFz ZSB3aGF0IHRoaXMgaXMKPiBhY3R1YWxseSBhY2hpZXZpbmcgYW5kIGEgc3BlY2lmaWMgc2NlbmFy aW8gd2hlcmUgd2Ugd2FudCB0aGlzIHRvIGJlCj4gaW1wbGVtZW50ZWQsIGluIGZpbmUgZGV0YWls czsgdGhlbiB3ZSBhZGQgaXQgdG8gdGhlIGNvbW1pdCBsb2cuCj4gCj4gVGhhdCBhc2lkZSwgdGhl IGludGVyYWN0aW9uIG9mIHRoZSB0aW1lciBhbmQgdGhlIElSUSBkb21haW4gY29kZQo+IG11c3Qg YmUgcmV2aWV3ZWQgYnkgTWFyYyBhbmQgVGhvbWFzIHRvIG1ha2Ugc3VyZSB0aGlzIGlzIG5vdAo+ IGEgZ3Jvc3MgdmlvbGF0aW9uIG9mIHRoZSByZXNwZWN0aXZlIHN1YnN5c3RlbXMgdXNhZ2UuCgpJ IGRvbid0IHNlZSBhbnl0aGluZyBiZWluZyBhICJncm9zcyB2aW9sYXRpb24iIGhlcmUsIGF0IGxl YXN0IGZyb20gYW4KaW50ZXJydXB0IHN1YnN5c3RlbSBwZXJzcGVjdGl2ZS4gSW4gYSB3YXksIHRo aXMgaXMgc3ludGhlc2lzaW5nIGFuCmludGVycnVwdCBvbiB0aGUgYmFjayBvZiBzb21lIG90aGVy IGV2ZW50LCBhbmQgYXMgbG9uZyBhcyB0aGUgY29udGV4dAppcyBzb21laG93IGFwcHJvcHJpYXRl IChzb21ldGhpbmcgdGhhdCBsb29rcyBsaWtlIGFuIGludGVycnVwdCB3aGVuCnByZXRlbmRpbmcg dGhlcmUgaXMgb25lKSwgdGhpcyBzaG91bGQgYmUgT0suIE90aGVyIHN1YnN5c3RlbXMgc3VjaCBh cwppMmMgR1BJTyBleHBhbmRlcnMgZG8gc2ltaWxhciB0aGluZ3MuCgpUaGUgb25lIHRoaW5nIEkn bSBkdWJpb3VzIGFib3V0IGlzIHRoZSBmcmVxdWVuY3kgb2YgdGhlIHRpbWVyLiBBc2tpbmcKZm9y IGEgcG9sbCBvZiB0aGUgbGluayBldmVyeSBqaWZmeSBpcyBib3VuZCB0byBiZSBleHBlbnNpdmUs IGFuZCBpdAp3b3VsZCBiZSBnb29kIHRvIHJlbGF4IHRoaXMgYXMgbXVjaCBhcyBwb3NzaWJsZSwg c3BlY2lhbGx5IG9uIGxvdy1lbmQKSFcgc3VjaCBhcyB0aGlzLCB3aGVyZSBldmVyeSBjeWNsZSBj b3VudHMuIEl0IGlzIGFsd2F5cyBnb2luZyB0byBiZSBhCiJiZXN0IGVmZm9ydCIgdGhpbmcsIGFu ZCB0aGUgY29tbWl0IG1lc3NhZ2UgZG9lc24ndCBzYXkgd2hhdCdzIHRoZQphY3R1YWwgZ3JhY2Ug cGVyaW9kIHRvIGhhbmRsZSB0aGlzICh0aGUgc3BlYyBwcm9iYWJseSBoYXMgb25lKS4KCkkgZ3Vl c3MgdGhpcyBwYXRjaCBjb3VsZCBkbyB3aXRoIGJlaW5nIHNwbGl0IGJldHdlZW4gaGFuZGxpbmcg bGluawpkb3duIGFuZCBsaW5rIHVwIGV2ZW50cywgYnV0IHRoYXQncyBmb3IgeW91IHRvIGRlY2lk ZS4KClRoYW5rcywKCglNLgoKLS0gCldpdGhvdXQgZGV2aWF0aW9uIGZyb20gdGhlIG5vcm0sIHBy b2dyZXNzIGlzIG5vdCBwb3NzaWJsZS4KCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fCmxpbnV4LWFybS1rZXJuZWwgbWFpbGluZyBsaXN0CmxpbnV4LWFybS1r ZXJuZWxAbGlzdHMuaW5mcmFkZWFkLm9yZwpodHRwOi8vbGlzdHMuaW5mcmFkZWFkLm9yZy9tYWls bWFuL2xpc3RpbmZvL2xpbnV4LWFybS1rZXJuZWwK