From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 0256DECAAD8 for ; Fri, 16 Sep 2022 09:41:23 +0000 (UTC) Received: from localhost ([::1]:42818 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oZ7qc-0005J4-6e for qemu-devel@archiver.kernel.org; Fri, 16 Sep 2022 05:41:22 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:41090) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oZ7lI-0003Gh-MC for qemu-devel@nongnu.org; Fri, 16 Sep 2022 05:35:57 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]:26516) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oZ7lE-0004CS-Ft for qemu-devel@nongnu.org; Fri, 16 Sep 2022 05:35:51 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1663320946; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=lzT/Q7oACC0xhlN/tJ0jDRdSu0qSwDh3E/xC/hcfPWY=; b=GPN1Ktuqw8dboB5S2rbAKVb14KJ2E4qNyy69/dlBepQWbqi8Je5+I9iJ54q8qo8oWtQojX TUGMlTWSL48zmo9pxn3uhx99jHlDysAtGrMQ0WLo3d2pE9+ic5VaApKlG8XwoUNPum9egD 37XjeIkb/NWYMQQXY0oPxX3vdhxPA8s= Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-376-pQuzFqoxP0qVFCUrMKHNWQ-1; Fri, 16 Sep 2022 05:35:43 -0400 X-MC-Unique: pQuzFqoxP0qVFCUrMKHNWQ-1 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.rdu2.redhat.com [10.11.54.4]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 52C393C01E1A; Fri, 16 Sep 2022 09:35:43 +0000 (UTC) Received: from blackfin.pond.sub.org (unknown [10.39.192.163]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 0C51A2086F60; Fri, 16 Sep 2022 09:35:43 +0000 (UTC) Received: by blackfin.pond.sub.org (Postfix, from userid 1000) id BCD2021E6900; Fri, 16 Sep 2022 11:35:40 +0200 (CEST) From: Markus Armbruster To: Ani Sinha Cc: Daniel P. =?utf-8?Q?Berrang=C3=A9?= , Igor Mammedov , "Michael S . Tsirkin" , eblake@redhat.com, jsnow@redhat.com, michael.roth@amd.com, qemu-devel@nongnu.org Subject: Re: [PATCH 06/27] qapi acpi: Elide redundant has_FOO in generated C References: <20220915204317.3766007-1-armbru@redhat.com> <20220915204317.3766007-7-armbru@redhat.com> <87illnenpv.fsf@pond.sub.org> Date: Fri, 16 Sep 2022 11:35:40 +0200 In-Reply-To: (Ani Sinha's message of "Fri, 16 Sep 2022 14:15:24 +0530") Message-ID: <87r10bd5lf.fsf@pond.sub.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 3.1 on 10.11.54.4 Received-SPF: pass client-ip=170.10.133.124; envelope-from=armbru@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" Ani Sinha writes: > On Fri, Sep 16, 2022 at 14:08 Daniel P. Berrang=C3=A9 > wrote: > >> On Fri, Sep 16, 2022 at 01:51:14PM +0530, Ani Sinha wrote: >> > On Fri, Sep 16, 2022 at 1:48 PM Markus Armbruster = wrote: >> > > >> > > Ani Sinha writes: >> > > >> > > > On Fri, Sep 16, 2022 at 2:13 AM Markus Armbruster wrote: >> > > >> >> > > >> The has_FOO for pointer-valued FOO are redundant, except for arra= ys. >> > > >> They are also a nuisance to work with. Recent commit "qapi: Star= t to >> > > >> elide redundant has_FOO in generated C" >> > > > >> > > > Commit is referenced using ("commit hea= der") >> > > >> > > Apply my patches in your tree, and your hashes will differ from mine. >> > > Hashes can serve as stable reference only when we git-fetch patches,= not >> > > when we git-send-email then. >> > >> > Has the referenced patch not been pushed upstream already? I thought >> > it was and hence was asking for the reference. >> >> Err, it is just a few patches earlier in this very series you're >> looking at. > > > Hmm ok. It=E2=80=99s missing from my inbox. Probably was not CC=E2=80=99d= to me. Yes. I'm sorry for the confusion!