From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AAAFE368 for ; Wed, 3 Aug 2022 07:20:15 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 54930C433D6; Wed, 3 Aug 2022 07:20:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1659511215; bh=8V1+O6tpf7JZgcnyYVZj42/dq24jisoCqFMvzapxHQI=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=O68PkUMwhkTqY+YWcymrBSP7EsvcKweWdR1THR6k7BSdNHCFcvovq8PH0pkxGh79e PnFxTTtRBg0ukAPy3pmbkywE2BHH1lR3fOEd95Cn3mCZEbTMs7vYRJzSdmrQol9uQI 7Lpt7BHd8p7NAzOMgyHiJ7ufUDyf/CDkiqkNFjFjKj53qP9nbxVKMp1qwpzMDQ06Ff p++h12WVTTk7GE6ozPsvumiyufbnmrPP5Fe3eqBgjv6OAWVKHv7x46hl39HH378G2E Ex+dCkv2DSlAfYVRS2VFqwIvBT9ZCpQ8CKaTKdBBRgEhMg5fJ4WkDwdWZ5PkeinzU6 tmRpM4gS7pDjg== Received: from ip-185-104-136-29.ptr.icomera.net ([185.104.136.29] helo=wait-a-minute.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1oJ8ft-000gmz-5p; Wed, 03 Aug 2022 08:20:13 +0100 Date: Wed, 03 Aug 2022 08:20:14 +0100 Message-ID: <87r11xbxox.wl-maz@kernel.org> From: Marc Zyngier To: Huacai Chen Cc: Thomas Gleixner , loongarch@lists.linux.dev, linux-kernel@vger.kernel.org, Xuefeng Li , Huacai Chen , Jiaxun Yang Subject: Re: [PATCH 1/2] irqchip/loongson-eiointc: Check hwirq overflow In-Reply-To: <20220803042728.3230346-1-chenhuacai@loongson.cn> References: <20220803042728.3230346-1-chenhuacai@loongson.cn> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/27.1 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) Precedence: bulk X-Mailing-List: loongarch@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII X-SA-Exim-Connect-IP: 185.104.136.29 X-SA-Exim-Rcpt-To: chenhuacai@loongson.cn, tglx@linutronix.de, loongarch@lists.linux.dev, linux-kernel@vger.kernel.org, lixuefeng@loongson.cn, chenhuacai@gmail.com, jiaxun.yang@flygoat.com X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false On Wed, 03 Aug 2022 05:27:27 +0100, Huacai Chen wrote: > > Check hwirq overflow when allocate irq in eiointc domain. > > Signed-off-by: Huacai Chen > --- > drivers/irqchip/irq-loongson-eiointc.c | 7 +++++-- > 1 file changed, 5 insertions(+), 2 deletions(-) > > diff --git a/drivers/irqchip/irq-loongson-eiointc.c b/drivers/irqchip/irq-loongson-eiointc.c > index 80d8ca6f2d46..f8060e58ee06 100644 > --- a/drivers/irqchip/irq-loongson-eiointc.c > +++ b/drivers/irqchip/irq-loongson-eiointc.c > @@ -241,8 +241,11 @@ static int eiointc_domain_alloc(struct irq_domain *domain, unsigned int virq, > struct eiointc *priv = domain->host_data; > > ret = irq_domain_translate_onecell(domain, arg, &hwirq, &type); > - if (ret) > - return ret; > + if (ret < 0) > + return -EINVAL; > + > + if (hwirq >= IOCSR_EXTIOI_VECTOR_NUM) > + return -EINVAL; How can this happen? Also, you're allocating a *range*. Surely the upper boundary should matter too? And for the umpteenth time, please add a cover letter when sending multiple patches. This is a hard requirement for me. Thanks, M. -- Without deviation from the norm, progress is not possible.