From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8D98DC43334 for ; Thu, 21 Jul 2022 13:32:48 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229639AbiGUNcr (ORCPT ); Thu, 21 Jul 2022 09:32:47 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41444 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229462AbiGUNcq (ORCPT ); Thu, 21 Jul 2022 09:32:46 -0400 Received: from mail-wr1-x42a.google.com (mail-wr1-x42a.google.com [IPv6:2a00:1450:4864:20::42a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4CB4D5E81C for ; Thu, 21 Jul 2022 06:32:44 -0700 (PDT) Received: by mail-wr1-x42a.google.com with SMTP id d16so2278637wrv.10 for ; Thu, 21 Jul 2022 06:32:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20210112.gappssmtp.com; s=20210112; h=from:to:cc:subject:in-reply-to:references:date:message-id :mime-version; bh=YiChl6swvjdNJt4BL7PNpumaZjt7l2oeMRF/EgqNKOU=; b=KJ71mRTHjcMfVwNP//9xcFCcC1OBo4d3n+D7jV0IXQn0jU0RVFvVjC+UzZNv1hTdkp rbmJXMz0Cu6ENMhNmXpJjh3tMTUGkoMJXCiFqjpV7/C65puZDUJoXZaTu+INoXqWSzQt XUc7JDuo4yVxIUSYpe+yCYeirNvHEtCeW/+w7Ke0TDXVFJCe59VOt3CvLZjPYtPna3kv 7JRi9aSPPvzaLaeaz/Zc2688kIV6P75gNSkAQxx87aI1yH5KD+XIMBgq2Qt3RXa7Gnme gON1/dS8zJBUQfAmwgwfxiEkOblleELw+kE41VyCRsu+jBdKgnJqFMWPDifbHFHFV5V8 4PAA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:in-reply-to:references:date :message-id:mime-version; bh=YiChl6swvjdNJt4BL7PNpumaZjt7l2oeMRF/EgqNKOU=; b=G1buQi+QtNrhXZGrhthA+ajqztG1QKOp8F+HAiddoQf1fWCazuF8dF26Xn4VhyOhFj 3Ia2IH86JKtT+RKRzRe7Di9/CBtJYyiGlyYeOFRSGRPq+4wo29aA3q7eZxIWj5twesMr 1bTnOKIFNwn4OAt0FnU2T2600l6UX81dXzgEtt2J4j66rtuobRf+ZxLYV2Hsu8iwgzCl 34C0YJL1RXqApzFUVy8t9HCwa47zb3lIi/2StPI1NNkt12kT4g4w3z/0uNgFuHXcCj0b eQF4BKZME6BEyd2iP7/CpG2gef7g//gIap/JKovKfc45wm9UueEzT+vLXku29z/40LRL eC5g== X-Gm-Message-State: AJIora/nSk5tGHnjnXpKfi/OLCCZnYVqviSPvRVgLVTCNDJjA352h6Fl ZE2Ag6O2b21FwGzJhmzhS+72wQ== X-Google-Smtp-Source: AGRyM1sl5Re6/quP4ss/24GJdvjVTANw3tDDCmdmbHWbEAkcAXG92PF0UHBuWneayHvdT1EvhLLaHQ== X-Received: by 2002:a05:6000:1a88:b0:21d:aa97:cb16 with SMTP id f8-20020a0560001a8800b0021daa97cb16mr35374955wry.97.1658410362731; Thu, 21 Jul 2022 06:32:42 -0700 (PDT) Received: from localhost ([82.66.159.240]) by smtp.gmail.com with ESMTPSA id o15-20020a05600c510f00b003a30fbde91dsm6560975wms.20.2022.07.21.06.32.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 21 Jul 2022 06:32:42 -0700 (PDT) From: Mattijs Korpershoek To: Krzysztof Kozlowski , Rob Herring , Krzysztof Kozlowski , Dmitry Torokhov , Matthias Brugger Cc: linux-kernel@vger.kernel.org, linux-input@vger.kernel.org, Fabien Parent , devicetree@vger.kernel.org, linux-mediatek@lists.infradead.org, Fabien Parent , linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v1 3/6] dt-bindings: mediatek,mt6779-keypad: add mediatek,double-keys In-Reply-To: <98ec7967-d007-46d7-ef54-aa41426b5f9f@linaro.org> References: <20220720-mt8183-keypad-v1-0-ef9fc29dbff4@baylibre.com> <20220720-mt8183-keypad-v1-3-ef9fc29dbff4@baylibre.com> <98ec7967-d007-46d7-ef54-aa41426b5f9f@linaro.org> Date: Thu, 21 Jul 2022 15:32:41 +0200 Message-ID: <87r12eh9qe.fsf@baylibre.com> MIME-Version: 1.0 Content-Type: text/plain Precedence: bulk List-ID: X-Mailing-List: linux-input@vger.kernel.org On Wed, Jul 20, 2022 at 19:26, Krzysztof Kozlowski wrote: > On 20/07/2022 16:48, Mattijs Korpershoek wrote: >> MediaTek keypad has 2 modes of detecting key events: >> - single key: each (row, column) can detect one key >> - double key: each (row, column) is a group of 2 keys >> >> Currently, only single key detection is supported (by default) >> Add an optional property, mediatek,double-keys to support double >> key detection. > > You focus here on driver implementation and behavior, but should rather > focus on hardware, like - in such setup two keys are physically wired to > one (row,column) pin. Understood. Will reword in v2 to reflect that this is hardware description, not a software feature. > >> >> Double key support exists to minimize cost, since it reduces the number >> of pins required for physical keys. >> >> Signed-off-by: Mattijs Korpershoek >> >> diff --git a/Documentation/devicetree/bindings/input/mediatek,mt6779-keypad.yaml b/Documentation/devicetree/bindings/input/mediatek,mt6779-keypad.yaml >> index ca8ae40a73f7..03c9555849e5 100644 >> --- a/Documentation/devicetree/bindings/input/mediatek,mt6779-keypad.yaml >> +++ b/Documentation/devicetree/bindings/input/mediatek,mt6779-keypad.yaml >> @@ -49,6 +49,12 @@ properties: >> maximum: 256 >> default: 16 >> >> + mediatek,double-keys: > > Do you think there could be another MT keypad version with triple-keys? Of all the SoC's i've worked on (MT8167, MT8183, MT8365, MT8195) I've never seen a "triple-keys" keypad. > >> + description: | >> + use double key matrix instead of single key >> + when set, each (row,column) is a group that can detect 2 keys >> + type: boolean >> + >> required: >> - compatible >> - reg >> > > > Best regards, > Krzysztof From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 517F7C433EF for ; Thu, 21 Jul 2022 13:38:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-ID:Date:References :In-Reply-To:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=sUT4Cos8P5XsC/FJWRTgcOk8snsbi09iIDWhTbzDqDg=; b=DhUNNFlKWN8jdk 3eHG7vZMiFfDq2i3gvL5oZGrwKjjDDoBe2rinttDvSj0NMSli1r63UButhvPfqM8u5kMArMEUsAvm s7Om801Z6edh2VXovW0rf1SlfDMxOeLc7juIV62iyhryffFkhdiM4At1vbsHkEfOgagsizF0WA1Dk RgeJl6+pj7YpUTgYhFymfhkmLAduJjcfHr79UhgKG/RmboY+k7pw6EBi2jexwqs7m6O3C2oCCxAwQ HUcH9oQg9wOwsbSMRKgu/nS5JeVozZFD2Ifq/hxzMOR4x8nwbLeHNZaNtDUxhnuKgLPRe9fgeXPek W26CJx6jyDCZp8oYQYmA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oEWMo-00782a-W2; Thu, 21 Jul 2022 13:37:28 +0000 Received: from mail-wr1-x42a.google.com ([2a00:1450:4864:20::42a]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1oEWIH-0074pu-K1 for linux-arm-kernel@lists.infradead.org; Thu, 21 Jul 2022 13:32:48 +0000 Received: by mail-wr1-x42a.google.com with SMTP id u5so2304651wrm.4 for ; Thu, 21 Jul 2022 06:32:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20210112.gappssmtp.com; s=20210112; h=from:to:cc:subject:in-reply-to:references:date:message-id :mime-version; bh=YiChl6swvjdNJt4BL7PNpumaZjt7l2oeMRF/EgqNKOU=; b=KJ71mRTHjcMfVwNP//9xcFCcC1OBo4d3n+D7jV0IXQn0jU0RVFvVjC+UzZNv1hTdkp rbmJXMz0Cu6ENMhNmXpJjh3tMTUGkoMJXCiFqjpV7/C65puZDUJoXZaTu+INoXqWSzQt XUc7JDuo4yVxIUSYpe+yCYeirNvHEtCeW/+w7Ke0TDXVFJCe59VOt3CvLZjPYtPna3kv 7JRi9aSPPvzaLaeaz/Zc2688kIV6P75gNSkAQxx87aI1yH5KD+XIMBgq2Qt3RXa7Gnme gON1/dS8zJBUQfAmwgwfxiEkOblleELw+kE41VyCRsu+jBdKgnJqFMWPDifbHFHFV5V8 4PAA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:in-reply-to:references:date :message-id:mime-version; bh=YiChl6swvjdNJt4BL7PNpumaZjt7l2oeMRF/EgqNKOU=; b=QckPU7Oz8a0P58FYX4Ygyw0cKb5z5fvd3rD1Ly0nuZVqbYiZElYSXs1ZMFJseUnjgi uIVez7qSmOJqxNva3vBy/Hey1suQ0aoeME/Mxl17iLE+acxMjoSPnNf+kgtzKLfwBEjt WXsxBh1O2a3mU3CfBTHGt+mV4GU26ZAdD91+cZeYhliY4onMIZemaYh+ETTZuWafakHk 5DIThgenoSsPJosMUtb5WdvxIVUk0HcuYoUTbEUbgwHO+LjAefwlYoDx85ycz67e3ao1 yB/SZQJlQntsRPIE1W84AefusgpAOi1unCOusf4qIRpd19yctPJ8dkWf86LErVPhE1Dj 4B9g== X-Gm-Message-State: AJIora+yAB7P3+bdv7Mj1jqrLeUq3YImOvIKdO2nw/2XHjk+0vmfK4NN 90bK7iIgV1ipnpRBy4XmObNmkA== X-Google-Smtp-Source: AGRyM1sl5Re6/quP4ss/24GJdvjVTANw3tDDCmdmbHWbEAkcAXG92PF0UHBuWneayHvdT1EvhLLaHQ== X-Received: by 2002:a05:6000:1a88:b0:21d:aa97:cb16 with SMTP id f8-20020a0560001a8800b0021daa97cb16mr35374955wry.97.1658410362731; Thu, 21 Jul 2022 06:32:42 -0700 (PDT) Received: from localhost ([82.66.159.240]) by smtp.gmail.com with ESMTPSA id o15-20020a05600c510f00b003a30fbde91dsm6560975wms.20.2022.07.21.06.32.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 21 Jul 2022 06:32:42 -0700 (PDT) From: Mattijs Korpershoek To: Krzysztof Kozlowski , Rob Herring , Krzysztof Kozlowski , Dmitry Torokhov , Matthias Brugger Cc: linux-kernel@vger.kernel.org, linux-input@vger.kernel.org, Fabien Parent , devicetree@vger.kernel.org, linux-mediatek@lists.infradead.org, Fabien Parent , linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v1 3/6] dt-bindings: mediatek,mt6779-keypad: add mediatek,double-keys In-Reply-To: <98ec7967-d007-46d7-ef54-aa41426b5f9f@linaro.org> References: <20220720-mt8183-keypad-v1-0-ef9fc29dbff4@baylibre.com> <20220720-mt8183-keypad-v1-3-ef9fc29dbff4@baylibre.com> <98ec7967-d007-46d7-ef54-aa41426b5f9f@linaro.org> Date: Thu, 21 Jul 2022 15:32:41 +0200 Message-ID: <87r12eh9qe.fsf@baylibre.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220721_063245_706083_1B9F9BDE X-CRM114-Status: GOOD ( 16.17 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Jul 20, 2022 at 19:26, Krzysztof Kozlowski wrote: > On 20/07/2022 16:48, Mattijs Korpershoek wrote: >> MediaTek keypad has 2 modes of detecting key events: >> - single key: each (row, column) can detect one key >> - double key: each (row, column) is a group of 2 keys >> >> Currently, only single key detection is supported (by default) >> Add an optional property, mediatek,double-keys to support double >> key detection. > > You focus here on driver implementation and behavior, but should rather > focus on hardware, like - in such setup two keys are physically wired to > one (row,column) pin. Understood. Will reword in v2 to reflect that this is hardware description, not a software feature. > >> >> Double key support exists to minimize cost, since it reduces the number >> of pins required for physical keys. >> >> Signed-off-by: Mattijs Korpershoek >> >> diff --git a/Documentation/devicetree/bindings/input/mediatek,mt6779-keypad.yaml b/Documentation/devicetree/bindings/input/mediatek,mt6779-keypad.yaml >> index ca8ae40a73f7..03c9555849e5 100644 >> --- a/Documentation/devicetree/bindings/input/mediatek,mt6779-keypad.yaml >> +++ b/Documentation/devicetree/bindings/input/mediatek,mt6779-keypad.yaml >> @@ -49,6 +49,12 @@ properties: >> maximum: 256 >> default: 16 >> >> + mediatek,double-keys: > > Do you think there could be another MT keypad version with triple-keys? Of all the SoC's i've worked on (MT8167, MT8183, MT8365, MT8195) I've never seen a "triple-keys" keypad. > >> + description: | >> + use double key matrix instead of single key >> + when set, each (row,column) is a group that can detect 2 keys >> + type: boolean >> + >> required: >> - compatible >> - reg >> > > > Best regards, > Krzysztof _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel