From: Markus Armbruster <armbru@redhat.com>
To: "Philippe Mathieu-Daudé" <philippe.mathieu.daude@gmail.com>
Cc: qemu-devel@nongnu.org, "Daniel P. Berrangé" <berrange@redhat.com>,
qemu-trivial@nongnu.org, "Paolo Bonzini" <pbonzini@redhat.com>,
"Eduardo Habkost" <eduardo@habkost.net>,
"Philippe Mathieu-Daudé" <f4bug@amsat.org>
Subject: Re: [PATCH] qom/object: Remove circular include dependency
Date: Mon, 09 May 2022 11:52:50 +0200 [thread overview]
Message-ID: <87r153av7x.fsf@pond.sub.org> (raw)
In-Reply-To: <20220509084659.52076-1-philippe.mathieu.daude@gmail.com> ("Philippe Mathieu-Daudé"'s message of "Mon, 9 May 2022 10:46:59 +0200")
Philippe Mathieu-Daudé <philippe.mathieu.daude@gmail.com> writes:
> From: Philippe Mathieu-Daudé <f4bug@amsat.org>
>
> "qom/object.h" doesn't need to include itself.
>
> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
> ---
> include/qom/object.h | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/include/qom/object.h b/include/qom/object.h
> index 5f3d5b5bf5..ef7258a5e1 100644
> --- a/include/qom/object.h
> +++ b/include/qom/object.h
> @@ -16,7 +16,6 @@
>
> #include "qapi/qapi-builtin-types.h"
> #include "qemu/module.h"
> -#include "qom/object.h"
>
> struct TypeImpl;
> typedef struct TypeImpl *Type;
I figure this is scripts/codeconverter/converter.py's doing, in commit
db1015e92e "Move QOM typedefs and add missing includes". Probably not
worth fixing there. Possibly worth mentioning in the commit message.
Reviewed-by: Markus Armbruster <armbru@redhat.com>
next prev parent reply other threads:[~2022-05-09 9:53 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-09 8:46 [PATCH] qom/object: Remove circular include dependency Philippe Mathieu-Daudé
2022-05-09 9:36 ` Damien Hedde
2022-05-09 9:41 ` Peter Maydell
2022-05-09 12:44 ` Philippe Mathieu-Daudé
2022-05-09 12:44 ` Philippe Mathieu-Daudé via
2022-05-09 12:46 ` Peter Maydell
2022-05-09 9:52 ` Markus Armbruster [this message]
2022-06-28 8:54 ` Laurent Vivier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87r153av7x.fsf@pond.sub.org \
--to=armbru@redhat.com \
--cc=berrange@redhat.com \
--cc=eduardo@habkost.net \
--cc=f4bug@amsat.org \
--cc=pbonzini@redhat.com \
--cc=philippe.mathieu.daude@gmail.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.