From: Markus Armbruster <armbru@redhat.com>
To: David Hildenbrand <david@redhat.com>
Cc: ani@anisinha.ca, imammedo@redhat.com, qemu-devel@nongnu.org,
mst@redhat.com
Subject: Re: [PATCH] hw/mem/pc-dimm: Fix error message if no slots were defined some more
Date: Tue, 22 Feb 2022 17:15:57 +0100 [thread overview]
Message-ID: <87r17uj2rm.fsf@pond.sub.org> (raw)
In-Reply-To: <ef91857f-e343-580e-3f3c-d5e36c078e25@redhat.com> (David Hildenbrand's message of "Tue, 22 Feb 2022 16:24:40 +0100")
David Hildenbrand <david@redhat.com> writes:
> On 22.02.22 16:22, Markus Armbruster wrote:
>> The error message added in commit 3ff333effa "pc-dimm: fix error
>> messages if no slots were defined" is misleading:
>>
>> $ qemu-system-x86_64 -object memory-backend-file,id=mem1,size=1M,mem-path=1G.img -device pc-dimm,id=dimm1,memdev=mem1
>> qemu-system-x86_64: -device pc-dimm,id=dimm1,memdev=mem1: no slots where allocated, please specify the 'slots' option
>> $ qemu-system-x86_64 -object memory-backend-file,id=mem1,size=1M,mem-path=1G.img -device pc-dimm,id=dimm1,memdev=mem1,slots=0
>> qemu-system-x86_64: -device pc-dimm,id=dimm1,memdev=mem1,slots=0: Property 'pc-dimm.slots' not found
>>
>> The property it called 'slot', not 'slots'. With that fixed, we get
>> another bad error message:
>>
>> $ qemu-system-x86_64 -object memory-backend-file,id=mem1,size=1M,mem-path=1G.img -device pc-dimm,id=dimm1,memdev=mem1,slot=0
>> qemu-system-x86_64: -device pc-dimm,id=dimm1,memdev=mem1,slot=0: invalid slot number 0, valid range is [0-18446744073709551615]
>>
>> Left for another day.
>>
>
> We're referring to the "-m 2g,maxmem=8g,slots=5" slots parameter. And I
> agree that we can make that clearer somehow :)
Aha!
So this patch actually moves us sideways rather than forward. Please
ignore it.
A patch that moves us forward would be nice :)
prev parent reply other threads:[~2022-02-22 16:37 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-22 15:22 [PATCH] hw/mem/pc-dimm: Fix error message if no slots were defined some more Markus Armbruster
2022-02-22 15:24 ` David Hildenbrand
2022-02-22 16:15 ` Markus Armbruster [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87r17uj2rm.fsf@pond.sub.org \
--to=armbru@redhat.com \
--cc=ani@anisinha.ca \
--cc=david@redhat.com \
--cc=imammedo@redhat.com \
--cc=mst@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.