From mboxrd@z Thu Jan 1 00:00:00 1970 From: Marc Zyngier Date: Wed, 17 Nov 2021 18:11:35 +0000 Subject: [PATCH v3 02/12] KVM: Add Makefile.kvm for common files, use it for x86 In-Reply-To: <20211117174003.297096-3-dwmw2@infradead.org> References: <20211117174003.297096-1-dwmw2@infradead.org> <20211117174003.297096-3-dwmw2@infradead.org> Message-ID: <87r1be7iug.wl-maz@kernel.org> List-Id: To: kvm-riscv@lists.infradead.org MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit On Wed, 17 Nov 2021 17:39:53 +0000, David Woodhouse wrote: > > From: David Woodhouse > > Splitting kvm_main.c out into smaller and better-organized files is > slightly non-trivial when it involves editing a bunch of per-arch > KVM makefiles. Provide virt/kvm/Makefile.kvm for them to include. > > Signed-off-by: David Woodhouse > --- > arch/x86/kvm/Makefile | 7 +------ > virt/kvm/Makefile.kvm | 13 +++++++++++++ > 2 files changed, 14 insertions(+), 6 deletions(-) > create mode 100644 virt/kvm/Makefile.kvm > > diff --git a/arch/x86/kvm/Makefile b/arch/x86/kvm/Makefile > index 75dfd27b6e8a..30f244b64523 100644 > --- a/arch/x86/kvm/Makefile > +++ b/arch/x86/kvm/Makefile > @@ -7,12 +7,7 @@ ifeq ($(CONFIG_FRAME_POINTER),y) > OBJECT_FILES_NON_STANDARD_vmenter.o := y > endif > > -KVM := ../../../virt/kvm > - > -kvm-y += $(KVM)/kvm_main.o $(KVM)/coalesced_mmio.o \ > - $(KVM)/eventfd.o $(KVM)/irqchip.o $(KVM)/vfio.o \ > - $(KVM)/dirty_ring.o $(KVM)/binary_stats.o > -kvm-$(CONFIG_KVM_ASYNC_PF) += $(KVM)/async_pf.o > +include $(srctree)/virt/kvm/Makefile.kvm > > kvm-y += x86.o emulate.o i8259.o irq.o lapic.o \ > i8254.o ioapic.o irq_comm.o cpuid.o pmu.o mtrr.o \ > diff --git a/virt/kvm/Makefile.kvm b/virt/kvm/Makefile.kvm > new file mode 100644 > index 000000000000..ffdcad3cc97a > --- /dev/null > +++ b/virt/kvm/Makefile.kvm > @@ -0,0 +1,13 @@ > +# SPDX-License-Identifier: GPL-2.0 > +# > +# Makefile for Kernel-based Virtual Machine module > +# > + > +KVM ?= ../../../virt/kvm > + > +kvm-y := $(KVM)/kvm_main.o $(KVM)/eventfd.o $(KVM)/binary_stats.o > +kvm-$(CONFIG_KVM_VFIO) += $(KVM)/vfio.o > +kvm-$(CONFIG_KVM_MMIO) += $(KVM)/coalesced_mmio.o > +kvm-$(CONFIG_KVM_ASYNC_PF) += $(KVM)/async_pf.o > +kvm-$(CONFIG_HAVE_KVM_IRQ_ROUTING) += $(KVM)/irqchip.o > +kvm-$(CONFIG_HAVE_KVM_DIRTY_RING) += $(KVM)/dirty_ring.o Acked-by: Marc Zyngier M. -- Without deviation from the norm, progress is not possible. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8AF31C43219 for ; Wed, 17 Nov 2021 18:11:43 +0000 (UTC) Received: from mm01.cs.columbia.edu (mm01.cs.columbia.edu [128.59.11.253]) by mail.kernel.org (Postfix) with ESMTP id 2ADB861BD4 for ; Wed, 17 Nov 2021 18:11:43 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 2ADB861BD4 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.cs.columbia.edu Received: from localhost (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id C43DF4B1B3; Wed, 17 Nov 2021 13:11:42 -0500 (EST) X-Virus-Scanned: at lists.cs.columbia.edu Received: from mm01.cs.columbia.edu ([127.0.0.1]) by localhost (mm01.cs.columbia.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id cpO2eA4ik6cN; Wed, 17 Nov 2021 13:11:41 -0500 (EST) Received: from mm01.cs.columbia.edu (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id 53FF44B187; Wed, 17 Nov 2021 13:11:41 -0500 (EST) Received: from localhost (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id 1556C4B133 for ; Wed, 17 Nov 2021 13:11:41 -0500 (EST) X-Virus-Scanned: at lists.cs.columbia.edu Received: from mm01.cs.columbia.edu ([127.0.0.1]) by localhost (mm01.cs.columbia.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id xTfP4eL+-h99 for ; Wed, 17 Nov 2021 13:11:39 -0500 (EST) Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by mm01.cs.columbia.edu (Postfix) with ESMTPS id 62E40407ED for ; Wed, 17 Nov 2021 13:11:39 -0500 (EST) Received: from disco-boy.misterjones.org (disco-boy.misterjones.org [51.254.78.96]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id D333B61AFF; Wed, 17 Nov 2021 18:11:37 +0000 (UTC) Received: from sofa.misterjones.org ([185.219.108.64] helo=why.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1mnPPD-0069Au-Oo; Wed, 17 Nov 2021 18:11:35 +0000 Date: Wed, 17 Nov 2021 18:11:35 +0000 Message-ID: <87r1be7iug.wl-maz@kernel.org> From: Marc Zyngier To: David Woodhouse Subject: Re: [PATCH v3 02/12] KVM: Add Makefile.kvm for common files, use it for x86 In-Reply-To: <20211117174003.297096-3-dwmw2@infradead.org> References: <20211117174003.297096-1-dwmw2@infradead.org> <20211117174003.297096-3-dwmw2@infradead.org> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/27.1 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") X-SA-Exim-Connect-IP: 185.219.108.64 X-SA-Exim-Rcpt-To: dwmw2@infradead.org, pbonzini@redhat.com, kvm@vger.kernel.org, boris.ostrovsky@oracle.com, joao.m.martins@oracle.com, jmattson@google.com, wanpengli@tencent.com, seanjc@google.com, vkuznets@redhat.com, mtosatti@redhat.com, joro@8bytes.org, karahmed@amazon.com, james.morse@arm.com, alexandru.elisei@arm.com, suzuki.poulose@arm.com, catalin.marinas@arm.com, will@kernel.org, chenhuacai@kernel.org, aleksandar.qemu.devel@gmail.com, mpe@ellerman.id.au, benh@kernel.crashing.org, anup.patel@wdc.com, borntraeger@de.ibm.com, kvmarm@lists.cs.columbia.edu, linux-arm-kernel@lists.infradead.org, linux-mips@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, kvm-riscv@lists.infradead.org, linux-s390@vger.kernel.org X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false Cc: Anup Patel , "wanpengli @ tencent . com" , kvm , Benjamin Herrenschmidt , Joao Martins , Will Deacon , kvmarm@lists.cs.columbia.edu, linux-s390@vger.kernel.org, Michael Ellerman , "joro @ 8bytes . org" , Huacai Chen , Christian Borntraeger , Aleksandar Markovic , karahmed@amazon.com, Catalin Marinas , Boris Ostrovsky , linux-arm-kernel , "jmattson @ google . com" , "mtosatti @ redhat . com" , linux-mips@vger.kernel.org, kvm-riscv@lists.infradead.org, Paolo Bonzini , "vkuznets @ redhat . com" , linuxppc-dev@lists.ozlabs.org X-BeenThere: kvmarm@lists.cs.columbia.edu X-Mailman-Version: 2.1.14 Precedence: list List-Id: Where KVM/ARM decisions are made List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: kvmarm-bounces@lists.cs.columbia.edu Sender: kvmarm-bounces@lists.cs.columbia.edu On Wed, 17 Nov 2021 17:39:53 +0000, David Woodhouse wrote: > > From: David Woodhouse > > Splitting kvm_main.c out into smaller and better-organized files is > slightly non-trivial when it involves editing a bunch of per-arch > KVM makefiles. Provide virt/kvm/Makefile.kvm for them to include. > > Signed-off-by: David Woodhouse > --- > arch/x86/kvm/Makefile | 7 +------ > virt/kvm/Makefile.kvm | 13 +++++++++++++ > 2 files changed, 14 insertions(+), 6 deletions(-) > create mode 100644 virt/kvm/Makefile.kvm > > diff --git a/arch/x86/kvm/Makefile b/arch/x86/kvm/Makefile > index 75dfd27b6e8a..30f244b64523 100644 > --- a/arch/x86/kvm/Makefile > +++ b/arch/x86/kvm/Makefile > @@ -7,12 +7,7 @@ ifeq ($(CONFIG_FRAME_POINTER),y) > OBJECT_FILES_NON_STANDARD_vmenter.o := y > endif > > -KVM := ../../../virt/kvm > - > -kvm-y += $(KVM)/kvm_main.o $(KVM)/coalesced_mmio.o \ > - $(KVM)/eventfd.o $(KVM)/irqchip.o $(KVM)/vfio.o \ > - $(KVM)/dirty_ring.o $(KVM)/binary_stats.o > -kvm-$(CONFIG_KVM_ASYNC_PF) += $(KVM)/async_pf.o > +include $(srctree)/virt/kvm/Makefile.kvm > > kvm-y += x86.o emulate.o i8259.o irq.o lapic.o \ > i8254.o ioapic.o irq_comm.o cpuid.o pmu.o mtrr.o \ > diff --git a/virt/kvm/Makefile.kvm b/virt/kvm/Makefile.kvm > new file mode 100644 > index 000000000000..ffdcad3cc97a > --- /dev/null > +++ b/virt/kvm/Makefile.kvm > @@ -0,0 +1,13 @@ > +# SPDX-License-Identifier: GPL-2.0 > +# > +# Makefile for Kernel-based Virtual Machine module > +# > + > +KVM ?= ../../../virt/kvm > + > +kvm-y := $(KVM)/kvm_main.o $(KVM)/eventfd.o $(KVM)/binary_stats.o > +kvm-$(CONFIG_KVM_VFIO) += $(KVM)/vfio.o > +kvm-$(CONFIG_KVM_MMIO) += $(KVM)/coalesced_mmio.o > +kvm-$(CONFIG_KVM_ASYNC_PF) += $(KVM)/async_pf.o > +kvm-$(CONFIG_HAVE_KVM_IRQ_ROUTING) += $(KVM)/irqchip.o > +kvm-$(CONFIG_HAVE_KVM_DIRTY_RING) += $(KVM)/dirty_ring.o Acked-by: Marc Zyngier M. -- Without deviation from the norm, progress is not possible. _______________________________________________ kvmarm mailing list kvmarm@lists.cs.columbia.edu https://lists.cs.columbia.edu/mailman/listinfo/kvmarm From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3FA78C433FE for ; Wed, 17 Nov 2021 18:11:41 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 2558261BD3 for ; Wed, 17 Nov 2021 18:11:41 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239873AbhKQSOi (ORCPT ); Wed, 17 Nov 2021 13:14:38 -0500 Received: from mail.kernel.org ([198.145.29.99]:53002 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238747AbhKQSOg (ORCPT ); Wed, 17 Nov 2021 13:14:36 -0500 Received: from disco-boy.misterjones.org (disco-boy.misterjones.org [51.254.78.96]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id D333B61AFF; Wed, 17 Nov 2021 18:11:37 +0000 (UTC) Received: from sofa.misterjones.org ([185.219.108.64] helo=why.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1mnPPD-0069Au-Oo; Wed, 17 Nov 2021 18:11:35 +0000 Date: Wed, 17 Nov 2021 18:11:35 +0000 Message-ID: <87r1be7iug.wl-maz@kernel.org> From: Marc Zyngier To: David Woodhouse Cc: Paolo Bonzini , kvm , Boris Ostrovsky , Joao Martins , "jmattson @ google . com" , "wanpengli @ tencent . com" , "seanjc @ google . com" , "vkuznets @ redhat . com" , "mtosatti @ redhat . com" , "joro @ 8bytes . org" , karahmed@amazon.com, James Morse , Alexandru Elisei , Suzuki K Poulose , Catalin Marinas , Will Deacon , Huacai Chen , Aleksandar Markovic , Michael Ellerman , Benjamin Herrenschmidt , Anup Patel , Christian Borntraeger , kvmarm@lists.cs.columbia.edu, linux-arm-kernel , linux-mips@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, kvm-riscv@lists.infradead.org, linux-s390@vger.kernel.org Subject: Re: [PATCH v3 02/12] KVM: Add Makefile.kvm for common files, use it for x86 In-Reply-To: <20211117174003.297096-3-dwmw2@infradead.org> References: <20211117174003.297096-1-dwmw2@infradead.org> <20211117174003.297096-3-dwmw2@infradead.org> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/27.1 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII X-SA-Exim-Connect-IP: 185.219.108.64 X-SA-Exim-Rcpt-To: dwmw2@infradead.org, pbonzini@redhat.com, kvm@vger.kernel.org, boris.ostrovsky@oracle.com, joao.m.martins@oracle.com, jmattson@google.com, wanpengli@tencent.com, seanjc@google.com, vkuznets@redhat.com, mtosatti@redhat.com, joro@8bytes.org, karahmed@amazon.com, james.morse@arm.com, alexandru.elisei@arm.com, suzuki.poulose@arm.com, catalin.marinas@arm.com, will@kernel.org, chenhuacai@kernel.org, aleksandar.qemu.devel@gmail.com, mpe@ellerman.id.au, benh@kernel.crashing.org, anup.patel@wdc.com, borntraeger@de.ibm.com, kvmarm@lists.cs.columbia.edu, linux-arm-kernel@lists.infradead.org, linux-mips@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, kvm-riscv@lists.infradead.org, linux-s390@vger.kernel.org X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false Precedence: bulk List-ID: X-Mailing-List: linux-mips@vger.kernel.org On Wed, 17 Nov 2021 17:39:53 +0000, David Woodhouse wrote: > > From: David Woodhouse > > Splitting kvm_main.c out into smaller and better-organized files is > slightly non-trivial when it involves editing a bunch of per-arch > KVM makefiles. Provide virt/kvm/Makefile.kvm for them to include. > > Signed-off-by: David Woodhouse > --- > arch/x86/kvm/Makefile | 7 +------ > virt/kvm/Makefile.kvm | 13 +++++++++++++ > 2 files changed, 14 insertions(+), 6 deletions(-) > create mode 100644 virt/kvm/Makefile.kvm > > diff --git a/arch/x86/kvm/Makefile b/arch/x86/kvm/Makefile > index 75dfd27b6e8a..30f244b64523 100644 > --- a/arch/x86/kvm/Makefile > +++ b/arch/x86/kvm/Makefile > @@ -7,12 +7,7 @@ ifeq ($(CONFIG_FRAME_POINTER),y) > OBJECT_FILES_NON_STANDARD_vmenter.o := y > endif > > -KVM := ../../../virt/kvm > - > -kvm-y += $(KVM)/kvm_main.o $(KVM)/coalesced_mmio.o \ > - $(KVM)/eventfd.o $(KVM)/irqchip.o $(KVM)/vfio.o \ > - $(KVM)/dirty_ring.o $(KVM)/binary_stats.o > -kvm-$(CONFIG_KVM_ASYNC_PF) += $(KVM)/async_pf.o > +include $(srctree)/virt/kvm/Makefile.kvm > > kvm-y += x86.o emulate.o i8259.o irq.o lapic.o \ > i8254.o ioapic.o irq_comm.o cpuid.o pmu.o mtrr.o \ > diff --git a/virt/kvm/Makefile.kvm b/virt/kvm/Makefile.kvm > new file mode 100644 > index 000000000000..ffdcad3cc97a > --- /dev/null > +++ b/virt/kvm/Makefile.kvm > @@ -0,0 +1,13 @@ > +# SPDX-License-Identifier: GPL-2.0 > +# > +# Makefile for Kernel-based Virtual Machine module > +# > + > +KVM ?= ../../../virt/kvm > + > +kvm-y := $(KVM)/kvm_main.o $(KVM)/eventfd.o $(KVM)/binary_stats.o > +kvm-$(CONFIG_KVM_VFIO) += $(KVM)/vfio.o > +kvm-$(CONFIG_KVM_MMIO) += $(KVM)/coalesced_mmio.o > +kvm-$(CONFIG_KVM_ASYNC_PF) += $(KVM)/async_pf.o > +kvm-$(CONFIG_HAVE_KVM_IRQ_ROUTING) += $(KVM)/irqchip.o > +kvm-$(CONFIG_HAVE_KVM_DIRTY_RING) += $(KVM)/dirty_ring.o Acked-by: Marc Zyngier M. -- Without deviation from the norm, progress is not possible. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 73D8AC433EF for ; Wed, 17 Nov 2021 18:12:16 +0000 (UTC) Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E587B61BC1 for ; Wed, 17 Nov 2021 18:12:15 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org E587B61BC1 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.ozlabs.org Received: from boromir.ozlabs.org (localhost [IPv6:::1]) by lists.ozlabs.org (Postfix) with ESMTP id 4HvWH24Qkgz3cQg for ; Thu, 18 Nov 2021 05:12:14 +1100 (AEDT) Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=kernel.org (client-ip=198.145.29.99; helo=mail.kernel.org; envelope-from=maz@kernel.org; receiver=) Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4HvWGN2M1bz3c54 for ; Thu, 18 Nov 2021 05:11:40 +1100 (AEDT) Received: from disco-boy.misterjones.org (disco-boy.misterjones.org [51.254.78.96]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id D333B61AFF; Wed, 17 Nov 2021 18:11:37 +0000 (UTC) Received: from sofa.misterjones.org ([185.219.108.64] helo=why.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1mnPPD-0069Au-Oo; Wed, 17 Nov 2021 18:11:35 +0000 Date: Wed, 17 Nov 2021 18:11:35 +0000 Message-ID: <87r1be7iug.wl-maz@kernel.org> From: Marc Zyngier To: David Woodhouse Subject: Re: [PATCH v3 02/12] KVM: Add Makefile.kvm for common files, use it for x86 In-Reply-To: <20211117174003.297096-3-dwmw2@infradead.org> References: <20211117174003.297096-1-dwmw2@infradead.org> <20211117174003.297096-3-dwmw2@infradead.org> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/27.1 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII X-SA-Exim-Connect-IP: 185.219.108.64 X-SA-Exim-Rcpt-To: dwmw2@infradead.org, pbonzini@redhat.com, kvm@vger.kernel.org, boris.ostrovsky@oracle.com, joao.m.martins@oracle.com, jmattson@google.com, wanpengli@tencent.com, seanjc@google.com, vkuznets@redhat.com, mtosatti@redhat.com, joro@8bytes.org, karahmed@amazon.com, james.morse@arm.com, alexandru.elisei@arm.com, suzuki.poulose@arm.com, catalin.marinas@arm.com, will@kernel.org, chenhuacai@kernel.org, aleksandar.qemu.devel@gmail.com, mpe@ellerman.id.au, benh@kernel.crashing.org, anup.patel@wdc.com, borntraeger@de.ibm.com, kvmarm@lists.cs.columbia.edu, linux-arm-kernel@lists.infradead.org, linux-mips@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, kvm-riscv@lists.infradead.org, linux-s390@vger.kernel.org X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Anup Patel , "wanpengli @ tencent . com" , kvm , Joao Martins , Will Deacon , kvmarm@lists.cs.columbia.edu, linux-s390@vger.kernel.org, "joro @ 8bytes . org" , Huacai Chen , Christian Borntraeger , Aleksandar Markovic , karahmed@amazon.com, Catalin Marinas , Suzuki K Poulose , Boris Ostrovsky , Alexandru Elisei , linux-arm-kernel , "jmattson @ google . com" , "seanjc @ google . com" , "mtosatti @ redhat . com" , linux-mips@vger.kernel.org, James Morse , kvm-riscv@lists.infradead.org, Paolo Bonzini , "vkuznets @ redhat . com" , linuxppc-dev@lists.ozlabs.org Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" On Wed, 17 Nov 2021 17:39:53 +0000, David Woodhouse wrote: > > From: David Woodhouse > > Splitting kvm_main.c out into smaller and better-organized files is > slightly non-trivial when it involves editing a bunch of per-arch > KVM makefiles. Provide virt/kvm/Makefile.kvm for them to include. > > Signed-off-by: David Woodhouse > --- > arch/x86/kvm/Makefile | 7 +------ > virt/kvm/Makefile.kvm | 13 +++++++++++++ > 2 files changed, 14 insertions(+), 6 deletions(-) > create mode 100644 virt/kvm/Makefile.kvm > > diff --git a/arch/x86/kvm/Makefile b/arch/x86/kvm/Makefile > index 75dfd27b6e8a..30f244b64523 100644 > --- a/arch/x86/kvm/Makefile > +++ b/arch/x86/kvm/Makefile > @@ -7,12 +7,7 @@ ifeq ($(CONFIG_FRAME_POINTER),y) > OBJECT_FILES_NON_STANDARD_vmenter.o := y > endif > > -KVM := ../../../virt/kvm > - > -kvm-y += $(KVM)/kvm_main.o $(KVM)/coalesced_mmio.o \ > - $(KVM)/eventfd.o $(KVM)/irqchip.o $(KVM)/vfio.o \ > - $(KVM)/dirty_ring.o $(KVM)/binary_stats.o > -kvm-$(CONFIG_KVM_ASYNC_PF) += $(KVM)/async_pf.o > +include $(srctree)/virt/kvm/Makefile.kvm > > kvm-y += x86.o emulate.o i8259.o irq.o lapic.o \ > i8254.o ioapic.o irq_comm.o cpuid.o pmu.o mtrr.o \ > diff --git a/virt/kvm/Makefile.kvm b/virt/kvm/Makefile.kvm > new file mode 100644 > index 000000000000..ffdcad3cc97a > --- /dev/null > +++ b/virt/kvm/Makefile.kvm > @@ -0,0 +1,13 @@ > +# SPDX-License-Identifier: GPL-2.0 > +# > +# Makefile for Kernel-based Virtual Machine module > +# > + > +KVM ?= ../../../virt/kvm > + > +kvm-y := $(KVM)/kvm_main.o $(KVM)/eventfd.o $(KVM)/binary_stats.o > +kvm-$(CONFIG_KVM_VFIO) += $(KVM)/vfio.o > +kvm-$(CONFIG_KVM_MMIO) += $(KVM)/coalesced_mmio.o > +kvm-$(CONFIG_KVM_ASYNC_PF) += $(KVM)/async_pf.o > +kvm-$(CONFIG_HAVE_KVM_IRQ_ROUTING) += $(KVM)/irqchip.o > +kvm-$(CONFIG_HAVE_KVM_DIRTY_RING) += $(KVM)/dirty_ring.o Acked-by: Marc Zyngier M. -- Without deviation from the norm, progress is not possible. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D635EC433F5 for ; Wed, 17 Nov 2021 18:12:58 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A0F3F61AFF for ; Wed, 17 Nov 2021 18:12:58 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org A0F3F61AFF Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Subject:Cc:To:From:Message-ID:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=FgOuloFr4//yjTVkNolQPuWEbZQAOju/MpjjuqHeQ4g=; b=NbZ9Tdct46Eav6 BR1Qd0HdeUuNJI1nLSZ091sY+VCuPlp01svaWv7Kq/dlLfML1pORbOOOJb8TG8nwukEXb5xTagpxY N+9vqedu+9WYLqKRbbhSCqoxpcGxw5j/RAfOt59FKrjjWYPbY6sbJwrJZvrPctm6PZxpMj6uMOLFw lsq/YPYc1FK1BG9NHFMTasyfyzfoyOIvwgk+joRIImKCsuCF1y6asz9fOyfwLFUk2pWXESkrIh/EZ gnHDXvrUYUihLalsGpOPt8seN+Kmygto45rFOiHEtrJvEPxT0Dsz6HQYM8MttHLLZ6LExjXdYnsiZ 28i7NvugwohfS/dHwWTg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mnPPL-00648Q-GY; Wed, 17 Nov 2021 18:11:43 +0000 Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mnPPG-00646q-43; Wed, 17 Nov 2021 18:11:39 +0000 Received: from disco-boy.misterjones.org (disco-boy.misterjones.org [51.254.78.96]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id D333B61AFF; Wed, 17 Nov 2021 18:11:37 +0000 (UTC) Received: from sofa.misterjones.org ([185.219.108.64] helo=why.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1mnPPD-0069Au-Oo; Wed, 17 Nov 2021 18:11:35 +0000 Date: Wed, 17 Nov 2021 18:11:35 +0000 Message-ID: <87r1be7iug.wl-maz@kernel.org> From: Marc Zyngier To: David Woodhouse Cc: Paolo Bonzini , kvm , Boris Ostrovsky , Joao Martins , "jmattson @ google . com" , "wanpengli @ tencent . com" , "seanjc @ google . com" , "vkuznets @ redhat . com" , "mtosatti @ redhat . com" , "joro @ 8bytes . org" , karahmed@amazon.com, James Morse , Alexandru Elisei , Suzuki K Poulose , Catalin Marinas , Will Deacon , Huacai Chen , Aleksandar Markovic , Michael Ellerman , Benjamin Herrenschmidt , Anup Patel , Christian Borntraeger , kvmarm@lists.cs.columbia.edu, linux-arm-kernel , linux-mips@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, kvm-riscv@lists.infradead.org, linux-s390@vger.kernel.org Subject: Re: [PATCH v3 02/12] KVM: Add Makefile.kvm for common files, use it for x86 In-Reply-To: <20211117174003.297096-3-dwmw2@infradead.org> References: <20211117174003.297096-1-dwmw2@infradead.org> <20211117174003.297096-3-dwmw2@infradead.org> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/27.1 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") X-SA-Exim-Connect-IP: 185.219.108.64 X-SA-Exim-Rcpt-To: dwmw2@infradead.org, pbonzini@redhat.com, kvm@vger.kernel.org, boris.ostrovsky@oracle.com, joao.m.martins@oracle.com, jmattson@google.com, wanpengli@tencent.com, seanjc@google.com, vkuznets@redhat.com, mtosatti@redhat.com, joro@8bytes.org, karahmed@amazon.com, james.morse@arm.com, alexandru.elisei@arm.com, suzuki.poulose@arm.com, catalin.marinas@arm.com, will@kernel.org, chenhuacai@kernel.org, aleksandar.qemu.devel@gmail.com, mpe@ellerman.id.au, benh@kernel.crashing.org, anup.patel@wdc.com, borntraeger@de.ibm.com, kvmarm@lists.cs.columbia.edu, linux-arm-kernel@lists.infradead.org, linux-mips@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, kvm-riscv@lists.infradead.org, linux-s390@vger.kernel.org X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211117_101138_238973_A24F7915 X-CRM114-Status: GOOD ( 23.18 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, 17 Nov 2021 17:39:53 +0000, David Woodhouse wrote: > > From: David Woodhouse > > Splitting kvm_main.c out into smaller and better-organized files is > slightly non-trivial when it involves editing a bunch of per-arch > KVM makefiles. Provide virt/kvm/Makefile.kvm for them to include. > > Signed-off-by: David Woodhouse > --- > arch/x86/kvm/Makefile | 7 +------ > virt/kvm/Makefile.kvm | 13 +++++++++++++ > 2 files changed, 14 insertions(+), 6 deletions(-) > create mode 100644 virt/kvm/Makefile.kvm > > diff --git a/arch/x86/kvm/Makefile b/arch/x86/kvm/Makefile > index 75dfd27b6e8a..30f244b64523 100644 > --- a/arch/x86/kvm/Makefile > +++ b/arch/x86/kvm/Makefile > @@ -7,12 +7,7 @@ ifeq ($(CONFIG_FRAME_POINTER),y) > OBJECT_FILES_NON_STANDARD_vmenter.o := y > endif > > -KVM := ../../../virt/kvm > - > -kvm-y += $(KVM)/kvm_main.o $(KVM)/coalesced_mmio.o \ > - $(KVM)/eventfd.o $(KVM)/irqchip.o $(KVM)/vfio.o \ > - $(KVM)/dirty_ring.o $(KVM)/binary_stats.o > -kvm-$(CONFIG_KVM_ASYNC_PF) += $(KVM)/async_pf.o > +include $(srctree)/virt/kvm/Makefile.kvm > > kvm-y += x86.o emulate.o i8259.o irq.o lapic.o \ > i8254.o ioapic.o irq_comm.o cpuid.o pmu.o mtrr.o \ > diff --git a/virt/kvm/Makefile.kvm b/virt/kvm/Makefile.kvm > new file mode 100644 > index 000000000000..ffdcad3cc97a > --- /dev/null > +++ b/virt/kvm/Makefile.kvm > @@ -0,0 +1,13 @@ > +# SPDX-License-Identifier: GPL-2.0 > +# > +# Makefile for Kernel-based Virtual Machine module > +# > + > +KVM ?= ../../../virt/kvm > + > +kvm-y := $(KVM)/kvm_main.o $(KVM)/eventfd.o $(KVM)/binary_stats.o > +kvm-$(CONFIG_KVM_VFIO) += $(KVM)/vfio.o > +kvm-$(CONFIG_KVM_MMIO) += $(KVM)/coalesced_mmio.o > +kvm-$(CONFIG_KVM_ASYNC_PF) += $(KVM)/async_pf.o > +kvm-$(CONFIG_HAVE_KVM_IRQ_ROUTING) += $(KVM)/irqchip.o > +kvm-$(CONFIG_HAVE_KVM_DIRTY_RING) += $(KVM)/dirty_ring.o Acked-by: Marc Zyngier M. -- Without deviation from the norm, progress is not possible. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel