All of lore.kernel.org
 help / color / mirror / Atom feed
From: Markus Armbruster <armbru@redhat.com>
To: huangy81@chinatelecom.cn
Cc: "Philippe Mathieu-Daudé" <philmd@redhat.com>,
	qemu-devel <qemu-devel@nongnu.org>,
	"Dr. David Alan Gilbert" <dgilbert@redhat.com>,
	"Juan Quintela" <quintela@redhat.com>
Subject: Re: [PATCH] docs: fix 'sample-pages' option tag
Date: Mon, 08 Nov 2021 08:06:58 +0100	[thread overview]
Message-ID: <87r1brnn1p.fsf@dusky.pond.sub.org> (raw)
In-Reply-To: <d212ac87ad45dcdd5d3ed85c61fc1fab765aed7e.1636353909.git.huangy81@chinatelecom.cn> (huangy's message of "Mon, 8 Nov 2021 14:51:00 +0800")

huangy81@chinatelecom.cn writes:

> From: Hyman Huang(黄勇) <huangy81@chinatelecom.cn>
>
> commit f78d4ed701 has fixed qemu tag, making 'sample-pages' option tag
> involved by accident, which introduced since 6.1 in commit 7afa08cd8fd.
> revert this line.
>
> Signed-off-by: Hyman Huang(黄勇) <huangy81@chinatelecom.cn>
> ---
>  qapi/migration.json | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/qapi/migration.json b/qapi/migration.json
> index f0aefda..bbfd48c 100644
> --- a/qapi/migration.json
> +++ b/qapi/migration.json
> @@ -1796,7 +1796,7 @@
>  # @calc-time: time in units of second for sample dirty pages
>  #
>  # @sample-pages: page count per GB for sample dirty pages
> -#                the default value is 512 (since 6.2)
> +#                the default value is 512 (since 6.1)
>  #
>  # @mode: mode containing method of calculate dirtyrate includes
>  #        'page-sampling' and 'dirty-ring' (Since 6.2)

Reviewed-by: Markus Armbruster <armbru@redhat.com>



  reply	other threads:[~2021-11-08  7:08 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-11-08  6:51 [PATCH] docs: fix 'sample-pages' option tag huangy81
2021-11-08  7:06 ` Markus Armbruster [this message]
2021-11-09  7:37 ` Juan Quintela

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87r1brnn1p.fsf@dusky.pond.sub.org \
    --to=armbru@redhat.com \
    --cc=dgilbert@redhat.com \
    --cc=huangy81@chinatelecom.cn \
    --cc=philmd@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=quintela@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.