From: Jani Nikula <jani.nikula@linux.intel.com>
To: Javier Martinez Canillas <javierm@redhat.com>,
linux-kernel@vger.kernel.org
Cc: "Pekka Paalanen" <pekka.paalanen@collabora.com>,
"David Airlie" <airlied@linux.ie>,
"Daniel Vetter" <daniel.vetter@ffwll.ch>,
"Michel Dänzer" <michel@daenzer.net>,
"Javier Martinez Canillas" <javierm@redhat.com>,
dri-devel@lists.freedesktop.org,
"Peter Robinson" <pbrobinson@gmail.com>,
"Thomas Zimmermann" <tzimmermann@suse.de>,
"Neal Gompa" <ngompa13@gmail.com>,
intel-gfx@lists.freedesktop.org
Subject: Re: [Intel-gfx] [RESEND PATCH 1/5] drm/i915: Fix comment about modeset parameters
Date: Wed, 03 Nov 2021 15:34:22 +0200 [thread overview]
Message-ID: <87r1bxbbxd.fsf@intel.com> (raw)
In-Reply-To: <20211103122809.1040754-2-javierm@redhat.com>
On Wed, 03 Nov 2021, Javier Martinez Canillas <javierm@redhat.com> wrote:
> The comment mentions that the KMS is enabled by default unless either the
> i915.modeset module parameter or vga_text_mode_force boot option are used.
>
> But the latter does not exist and instead the nomodeset option was meant.
>
> Signed-off-by: Javier Martinez Canillas <javierm@redhat.com>
Thanks for the patch. I've picked this up to drm-intel-next as a
non-functional change independent from the rest of the series.
BR,
Jani.
> ---
>
> drivers/gpu/drm/i915/i915_module.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/i915_module.c b/drivers/gpu/drm/i915/i915_module.c
> index ab2295dd4500..c7507266aa83 100644
> --- a/drivers/gpu/drm/i915/i915_module.c
> +++ b/drivers/gpu/drm/i915/i915_module.c
> @@ -24,8 +24,8 @@ static int i915_check_nomodeset(void)
>
> /*
> * Enable KMS by default, unless explicitly overriden by
> - * either the i915.modeset prarameter or by the
> - * vga_text_mode_force boot option.
> + * either the i915.modeset parameter or by the
> + * nomodeset boot option.
> */
>
> if (i915_modparams.modeset == 0)
--
Jani Nikula, Intel Open Source Graphics Center
WARNING: multiple messages have this Message-ID (diff)
From: Jani Nikula <jani.nikula@linux.intel.com>
To: Javier Martinez Canillas <javierm@redhat.com>,
linux-kernel@vger.kernel.org
Cc: "Pekka Paalanen" <pekka.paalanen@collabora.com>,
"David Airlie" <airlied@linux.ie>,
"Daniel Vetter" <daniel.vetter@ffwll.ch>,
"Michel Dänzer" <michel@daenzer.net>,
"Javier Martinez Canillas" <javierm@redhat.com>,
dri-devel@lists.freedesktop.org,
"Rodrigo Vivi" <rodrigo.vivi@intel.com>,
"Peter Robinson" <pbrobinson@gmail.com>,
"Thomas Zimmermann" <tzimmermann@suse.de>,
"Neal Gompa" <ngompa13@gmail.com>,
intel-gfx@lists.freedesktop.org
Subject: Re: [RESEND PATCH 1/5] drm/i915: Fix comment about modeset parameters
Date: Wed, 03 Nov 2021 15:34:22 +0200 [thread overview]
Message-ID: <87r1bxbbxd.fsf@intel.com> (raw)
In-Reply-To: <20211103122809.1040754-2-javierm@redhat.com>
On Wed, 03 Nov 2021, Javier Martinez Canillas <javierm@redhat.com> wrote:
> The comment mentions that the KMS is enabled by default unless either the
> i915.modeset module parameter or vga_text_mode_force boot option are used.
>
> But the latter does not exist and instead the nomodeset option was meant.
>
> Signed-off-by: Javier Martinez Canillas <javierm@redhat.com>
Thanks for the patch. I've picked this up to drm-intel-next as a
non-functional change independent from the rest of the series.
BR,
Jani.
> ---
>
> drivers/gpu/drm/i915/i915_module.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/i915_module.c b/drivers/gpu/drm/i915/i915_module.c
> index ab2295dd4500..c7507266aa83 100644
> --- a/drivers/gpu/drm/i915/i915_module.c
> +++ b/drivers/gpu/drm/i915/i915_module.c
> @@ -24,8 +24,8 @@ static int i915_check_nomodeset(void)
>
> /*
> * Enable KMS by default, unless explicitly overriden by
> - * either the i915.modeset prarameter or by the
> - * vga_text_mode_force boot option.
> + * either the i915.modeset parameter or by the
> + * nomodeset boot option.
> */
>
> if (i915_modparams.modeset == 0)
--
Jani Nikula, Intel Open Source Graphics Center
WARNING: multiple messages have this Message-ID (diff)
From: Jani Nikula <jani.nikula@linux.intel.com>
To: Javier Martinez Canillas <javierm@redhat.com>,
linux-kernel@vger.kernel.org
Cc: "Peter Robinson" <pbrobinson@gmail.com>,
"Michel Dänzer" <michel@daenzer.net>,
"Thomas Zimmermann" <tzimmermann@suse.de>,
"Pekka Paalanen" <pekka.paalanen@collabora.com>,
"Daniel Vetter" <daniel.vetter@ffwll.ch>,
"Neal Gompa" <ngompa13@gmail.com>,
"Javier Martinez Canillas" <javierm@redhat.com>,
"Daniel Vetter" <daniel@ffwll.ch>,
"David Airlie" <airlied@linux.ie>,
"Joonas Lahtinen" <joonas.lahtinen@linux.intel.com>,
"Rodrigo Vivi" <rodrigo.vivi@intel.com>,
dri-devel@lists.freedesktop.org, intel-gfx@lists.freedesktop.org
Subject: Re: [RESEND PATCH 1/5] drm/i915: Fix comment about modeset parameters
Date: Wed, 03 Nov 2021 15:34:22 +0200 [thread overview]
Message-ID: <87r1bxbbxd.fsf@intel.com> (raw)
In-Reply-To: <20211103122809.1040754-2-javierm@redhat.com>
On Wed, 03 Nov 2021, Javier Martinez Canillas <javierm@redhat.com> wrote:
> The comment mentions that the KMS is enabled by default unless either the
> i915.modeset module parameter or vga_text_mode_force boot option are used.
>
> But the latter does not exist and instead the nomodeset option was meant.
>
> Signed-off-by: Javier Martinez Canillas <javierm@redhat.com>
Thanks for the patch. I've picked this up to drm-intel-next as a
non-functional change independent from the rest of the series.
BR,
Jani.
> ---
>
> drivers/gpu/drm/i915/i915_module.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/i915_module.c b/drivers/gpu/drm/i915/i915_module.c
> index ab2295dd4500..c7507266aa83 100644
> --- a/drivers/gpu/drm/i915/i915_module.c
> +++ b/drivers/gpu/drm/i915/i915_module.c
> @@ -24,8 +24,8 @@ static int i915_check_nomodeset(void)
>
> /*
> * Enable KMS by default, unless explicitly overriden by
> - * either the i915.modeset prarameter or by the
> - * vga_text_mode_force boot option.
> + * either the i915.modeset parameter or by the
> + * nomodeset boot option.
> */
>
> if (i915_modparams.modeset == 0)
--
Jani Nikula, Intel Open Source Graphics Center
next prev parent reply other threads:[~2021-11-03 13:34 UTC|newest]
Thread overview: 63+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-03 12:28 [RESEND PATCH 0/5] Cleanups for the nomodeset kernel command line parameter logic Javier Martinez Canillas
2021-11-03 12:28 ` Javier Martinez Canillas
2021-11-03 12:28 ` [Nouveau] " Javier Martinez Canillas
2021-11-03 12:28 ` Javier Martinez Canillas
2021-11-03 12:28 ` [Intel-gfx] " Javier Martinez Canillas
2021-11-03 12:28 ` [Intel-gfx] [RESEND PATCH 1/5] drm/i915: Fix comment about modeset parameters Javier Martinez Canillas
2021-11-03 12:28 ` Javier Martinez Canillas
2021-11-03 12:28 ` Javier Martinez Canillas
2021-11-03 13:34 ` Jani Nikula [this message]
2021-11-03 13:34 ` Jani Nikula
2021-11-03 13:34 ` Jani Nikula
2021-11-03 12:28 ` [RESEND PATCH 2/5] drm: Move nomodeset kernel parameter handler to the DRM subsystem Javier Martinez Canillas
2021-11-03 12:28 ` Javier Martinez Canillas
2021-11-03 12:28 ` [Nouveau] " Javier Martinez Canillas
2021-11-03 12:28 ` Javier Martinez Canillas
2021-11-03 12:28 ` [Intel-gfx] " Javier Martinez Canillas
2021-11-03 12:41 ` Thomas Zimmermann
2021-11-03 12:41 ` Thomas Zimmermann
2021-11-03 12:41 ` Thomas Zimmermann
2021-11-03 12:41 ` [Nouveau] " Thomas Zimmermann
2021-11-03 12:41 ` Thomas Zimmermann
2021-11-03 12:41 ` [Intel-gfx] " Thomas Zimmermann
2021-11-03 13:06 ` Javier Martinez Canillas
2021-11-03 13:06 ` Javier Martinez Canillas
2021-11-03 13:06 ` [Nouveau] " Javier Martinez Canillas
2021-11-03 13:06 ` Javier Martinez Canillas
2021-11-03 13:06 ` [Intel-gfx] " Javier Martinez Canillas
2021-11-03 12:56 ` Jani Nikula
2021-11-03 12:56 ` Jani Nikula
2021-11-03 12:56 ` Jani Nikula
2021-11-03 12:56 ` [Nouveau] " Jani Nikula
2021-11-03 12:56 ` Jani Nikula
2021-11-03 12:56 ` [Intel-gfx] " Jani Nikula
2021-11-03 13:09 ` Javier Martinez Canillas
2021-11-03 13:09 ` Javier Martinez Canillas
2021-11-03 13:09 ` [Nouveau] " Javier Martinez Canillas
2021-11-03 13:09 ` Javier Martinez Canillas
2021-11-03 13:09 ` [Intel-gfx] " Javier Martinez Canillas
2021-11-03 12:28 ` [RESEND PATCH 3/5] drm: Rename vgacon_text_force() function to drm_modeset_disabled() Javier Martinez Canillas
2021-11-03 12:28 ` Javier Martinez Canillas
2021-11-03 12:28 ` Javier Martinez Canillas
2021-11-03 12:28 ` [Nouveau] " Javier Martinez Canillas
2021-11-03 12:28 ` [Intel-gfx] " Javier Martinez Canillas
2021-11-03 12:57 ` Thomas Zimmermann
2021-11-03 12:57 ` Thomas Zimmermann
2021-11-03 12:57 ` Thomas Zimmermann
2021-11-03 12:57 ` [Nouveau] " Thomas Zimmermann
2021-11-03 12:57 ` [Intel-gfx] " Thomas Zimmermann
2021-11-03 14:28 ` Javier Martinez Canillas
2021-11-03 14:28 ` Javier Martinez Canillas
2021-11-03 14:28 ` [Nouveau] " Javier Martinez Canillas
2021-11-03 14:28 ` [Intel-gfx] " Javier Martinez Canillas
2021-11-03 13:01 ` [RESEND PATCH 0/5] Cleanups for the nomodeset kernel command line parameter logic Thomas Zimmermann
2021-11-03 13:01 ` Thomas Zimmermann
2021-11-03 13:01 ` Thomas Zimmermann
2021-11-03 13:01 ` [Nouveau] " Thomas Zimmermann
2021-11-03 13:01 ` Thomas Zimmermann
2021-11-03 13:01 ` [Intel-gfx] " Thomas Zimmermann
2021-11-03 15:00 ` Javier Martinez Canillas
2021-11-03 15:00 ` Javier Martinez Canillas
2021-11-03 15:00 ` [Nouveau] " Javier Martinez Canillas
2021-11-03 15:00 ` Javier Martinez Canillas
2021-11-03 15:00 ` [Intel-gfx] " Javier Martinez Canillas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87r1bxbbxd.fsf@intel.com \
--to=jani.nikula@linux.intel.com \
--cc=airlied@linux.ie \
--cc=daniel.vetter@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=intel-gfx@lists.freedesktop.org \
--cc=javierm@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=michel@daenzer.net \
--cc=ngompa13@gmail.com \
--cc=pbrobinson@gmail.com \
--cc=pekka.paalanen@collabora.com \
--cc=tzimmermann@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.