From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8CB1FC433F5 for ; Wed, 13 Oct 2021 14:13:27 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 71B9A61105 for ; Wed, 13 Oct 2021 14:13:27 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235927AbhJMOP3 convert rfc822-to-8bit (ORCPT ); Wed, 13 Oct 2021 10:15:29 -0400 Received: from relay3-d.mail.gandi.net ([217.70.183.195]:51981 "EHLO relay3-d.mail.gandi.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231664AbhJMOP3 (ORCPT ); Wed, 13 Oct 2021 10:15:29 -0400 Received: (Authenticated sender: gregory.clement@bootlin.com) by relay3-d.mail.gandi.net (Postfix) with ESMTPSA id 2EA486000F; Wed, 13 Oct 2021 14:13:21 +0000 (UTC) From: Gregory CLEMENT To: Pali =?utf-8?Q?Roh=C3=A1r?= , Michael Turquette , Stephen Boyd , Rob Herring , Greg Kroah-Hartman Cc: Andrew Lunn , Sebastian Hesselbarth , Vladimir Vid , Marek =?utf-8?Q?Beh=C3=BAn?= , linux-clk@vger.kernel.org, linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org Subject: Re: [PATCH v7 5/6] arm64: dts: marvell: armada-37xx: add device node for UART clock and use it In-Reply-To: <20210930095838.28145-6-pali@kernel.org> References: <20210930095838.28145-1-pali@kernel.org> <20210930095838.28145-6-pali@kernel.org> Date: Wed, 13 Oct 2021 16:13:16 +0200 Message-ID: <87r1cpdncz.fsf@BL-laptop> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8BIT Precedence: bulk List-ID: X-Mailing-List: linux-clk@vger.kernel.org Hello Pali, > This change defines DT node for UART clock "marvell,armada-3700-uart-clock" > and use this UART clock as a base clock for all UART devices. > > Signed-off-by: Pali Rohár > > --- > Changes in v6: > * Do not disable uartclk by default > * Rename node to clock-controller@12010 > --- > arch/arm64/boot/dts/marvell/armada-37xx.dtsi | 14 ++++++++++++-- > 1 file changed, 12 insertions(+), 2 deletions(-) > > diff --git a/arch/arm64/boot/dts/marvell/armada-37xx.dtsi b/arch/arm64/boot/dts/marvell/armada-37xx.dtsi > index 9acc5d2b5a00..f9bfe73d8ec2 100644 > --- a/arch/arm64/boot/dts/marvell/armada-37xx.dtsi > +++ b/arch/arm64/boot/dts/marvell/armada-37xx.dtsi > @@ -132,10 +132,20 @@ > reg = <0x11500 0x40>; > }; > > + uartclk: clock-controller@12010 { > + compatible = "marvell,armada-3700-uart-clock"; > + reg = <0x12010 0x4>, <0x12210 0x4>; > + clocks = <&tbg 0>, <&tbg 1>, <&tbg 2>, > + <&tbg 3>, <&xtalclk>; > + clock-names = "TBG-A-P", "TBG-B-P", "TBG-A-S", > + "TBG-B-S", "xtal"; > + #clock-cells = <1>; > + }; > + > uart0: serial@12000 { > compatible = "marvell,armada-3700-uart"; > reg = <0x12000 0x18>; > - clocks = <&xtalclk>; > + clocks = <&uartclk 0>; What happens if we have a new kernel using on old device tree ? Gregory > interrupts = > , > , > @@ -147,7 +157,7 @@ > uart1: serial@12200 { > compatible = "marvell,armada-3700-uart-ext"; > reg = <0x12200 0x30>; > - clocks = <&xtalclk>; > + clocks = <&uartclk 1>; > interrupts = > , > ; > -- > 2.20.1 > -- Gregory Clement, Bootlin Embedded Linux and Kernel engineering http://bootlin.com From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D3AD2C433EF for ; Wed, 13 Oct 2021 14:15:58 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 94BEB610EA for ; Wed, 13 Oct 2021 14:15:58 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 94BEB610EA Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=bootlin.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-ID:Date:References :In-Reply-To:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=M29GjXwpY5ycAdtF9XixXCwsFlKXKkzMPpHUymJNAjo=; b=RKbN5kYTxE+KTK jGUSJgDcVSDAyzSTp2ok2STBaZIMFaw4xSkuWvAME6GHC1uaOXWoX0qdh4G5TsiskpaaEmiW2BWPh PXs7mMki5uaE0w/MR9XKtf/743gg/Bn2fFrD6MUMVED/D2b7Zqk8jzCFxQMwDubGpwQgdBMs+ypmt 7pKXAk2+EWBLLXs67YC5/SfGGDm5CDLxLMP1Yv/IB1j2bhAIon3v5tbPJnXq0Ndefr/DbvzwF2n07 3mwWVu7pXTrWNWJPULK7Npg9LgiCJgVHVwqaZZ1XoZ4PontFGZV8qpu7IhjQncSJTA+11C4/xAc4g 3KIA2lMjo94QMZZeekLQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1maf0i-00H5N1-H1; Wed, 13 Oct 2021 14:13:36 +0000 Received: from relay3-d.mail.gandi.net ([217.70.183.195]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1maf0d-00H5KH-BS for linux-arm-kernel@lists.infradead.org; Wed, 13 Oct 2021 14:13:33 +0000 Received: (Authenticated sender: gregory.clement@bootlin.com) by relay3-d.mail.gandi.net (Postfix) with ESMTPSA id 2EA486000F; Wed, 13 Oct 2021 14:13:21 +0000 (UTC) From: Gregory CLEMENT To: Pali =?utf-8?Q?Roh=C3=A1r?= , Michael Turquette , Stephen Boyd , Rob Herring , Greg Kroah-Hartman Cc: Andrew Lunn , Sebastian Hesselbarth , Vladimir Vid , Marek =?utf-8?Q?Beh=C3=BAn?= , linux-clk@vger.kernel.org, linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org Subject: Re: [PATCH v7 5/6] arm64: dts: marvell: armada-37xx: add device node for UART clock and use it In-Reply-To: <20210930095838.28145-6-pali@kernel.org> References: <20210930095838.28145-1-pali@kernel.org> <20210930095838.28145-6-pali@kernel.org> Date: Wed, 13 Oct 2021 16:13:16 +0200 Message-ID: <87r1cpdncz.fsf@BL-laptop> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211013_071331_562475_157CF7B9 X-CRM114-Status: GOOD ( 14.44 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org SGVsbG8gUGFsaSwKCj4gVGhpcyBjaGFuZ2UgZGVmaW5lcyBEVCBub2RlIGZvciBVQVJUIGNsb2Nr ICJtYXJ2ZWxsLGFybWFkYS0zNzAwLXVhcnQtY2xvY2siCj4gYW5kIHVzZSB0aGlzIFVBUlQgY2xv Y2sgYXMgYSBiYXNlIGNsb2NrIGZvciBhbGwgVUFSVCBkZXZpY2VzLgo+Cj4gU2lnbmVkLW9mZi1i eTogUGFsaSBSb2jDoXIgPHBhbGlAa2VybmVsLm9yZz4KPgo+IC0tLQo+IENoYW5nZXMgaW4gdjY6 Cj4gKiBEbyBub3QgZGlzYWJsZSB1YXJ0Y2xrIGJ5IGRlZmF1bHQKPiAqIFJlbmFtZSBub2RlIHRv IGNsb2NrLWNvbnRyb2xsZXJAMTIwMTAKPiAtLS0KPiAgYXJjaC9hcm02NC9ib290L2R0cy9tYXJ2 ZWxsL2FybWFkYS0zN3h4LmR0c2kgfCAxNCArKysrKysrKysrKystLQo+ICAxIGZpbGUgY2hhbmdl ZCwgMTIgaW5zZXJ0aW9ucygrKSwgMiBkZWxldGlvbnMoLSkKPgo+IGRpZmYgLS1naXQgYS9hcmNo L2FybTY0L2Jvb3QvZHRzL21hcnZlbGwvYXJtYWRhLTM3eHguZHRzaSBiL2FyY2gvYXJtNjQvYm9v dC9kdHMvbWFydmVsbC9hcm1hZGEtMzd4eC5kdHNpCj4gaW5kZXggOWFjYzVkMmI1YTAwLi5mOWJm ZTczZDhlYzIgMTAwNjQ0Cj4gLS0tIGEvYXJjaC9hcm02NC9ib290L2R0cy9tYXJ2ZWxsL2FybWFk YS0zN3h4LmR0c2kKPiArKysgYi9hcmNoL2FybTY0L2Jvb3QvZHRzL21hcnZlbGwvYXJtYWRhLTM3 eHguZHRzaQo+IEBAIC0xMzIsMTAgKzEzMiwyMCBAQAo+ICAJCQkJcmVnID0gPDB4MTE1MDAgMHg0 MD47Cj4gIAkJCX07Cj4gIAo+ICsJCQl1YXJ0Y2xrOiBjbG9jay1jb250cm9sbGVyQDEyMDEwIHsK PiArCQkJCWNvbXBhdGlibGUgPSAibWFydmVsbCxhcm1hZGEtMzcwMC11YXJ0LWNsb2NrIjsKPiAr CQkJCXJlZyA9IDwweDEyMDEwIDB4ND4sIDwweDEyMjEwIDB4ND47Cj4gKwkJCQljbG9ja3MgPSA8 JnRiZyAwPiwgPCZ0YmcgMT4sIDwmdGJnIDI+LAo+ICsJCQkJCTwmdGJnIDM+LCA8Jnh0YWxjbGs+ Owo+ICsJCQkJY2xvY2stbmFtZXMgPSAiVEJHLUEtUCIsICJUQkctQi1QIiwgIlRCRy1BLVMiLAo+ ICsJCQkJCSJUQkctQi1TIiwgInh0YWwiOwo+ICsJCQkJI2Nsb2NrLWNlbGxzID0gPDE+Owo+ICsJ CQl9Owo+ICsKPiAgCQkJdWFydDA6IHNlcmlhbEAxMjAwMCB7Cj4gIAkJCQljb21wYXRpYmxlID0g Im1hcnZlbGwsYXJtYWRhLTM3MDAtdWFydCI7Cj4gIAkJCQlyZWcgPSA8MHgxMjAwMCAweDE4PjsK PiAtCQkJCWNsb2NrcyA9IDwmeHRhbGNsaz47Cj4gKwkJCQljbG9ja3MgPSA8JnVhcnRjbGsgMD47 CgpXaGF0IGhhcHBlbnMgaWYgd2UgaGF2ZSBhIG5ldyBrZXJuZWwgdXNpbmcgb24gb2xkIGRldmlj ZSB0cmVlID8KCkdyZWdvcnkKCj4gIAkJCQlpbnRlcnJ1cHRzID0KPiAgCQkJCTxHSUNfU1BJIDEx IElSUV9UWVBFX0xFVkVMX0hJR0g+LAo+ICAJCQkJPEdJQ19TUEkgMTIgSVJRX1RZUEVfTEVWRUxf SElHSD4sCj4gQEAgLTE0Nyw3ICsxNTcsNyBAQAo+ICAJCQl1YXJ0MTogc2VyaWFsQDEyMjAwIHsK PiAgCQkJCWNvbXBhdGlibGUgPSAibWFydmVsbCxhcm1hZGEtMzcwMC11YXJ0LWV4dCI7Cj4gIAkJ CQlyZWcgPSA8MHgxMjIwMCAweDMwPjsKPiAtCQkJCWNsb2NrcyA9IDwmeHRhbGNsaz47Cj4gKwkJ CQljbG9ja3MgPSA8JnVhcnRjbGsgMT47Cj4gIAkJCQlpbnRlcnJ1cHRzID0KPiAgCQkJCTxHSUNf U1BJIDMwIElSUV9UWVBFX0VER0VfUklTSU5HPiwKPiAgCQkJCTxHSUNfU1BJIDMxIElSUV9UWVBF X0VER0VfUklTSU5HPjsKPiAtLSAKPiAyLjIwLjEKPgoKLS0gCkdyZWdvcnkgQ2xlbWVudCwgQm9v dGxpbgpFbWJlZGRlZCBMaW51eCBhbmQgS2VybmVsIGVuZ2luZWVyaW5nCmh0dHA6Ly9ib290bGlu LmNvbQoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KbGlu dXgtYXJtLWtlcm5lbCBtYWlsaW5nIGxpc3QKbGludXgtYXJtLWtlcm5lbEBsaXN0cy5pbmZyYWRl YWQub3JnCmh0dHA6Ly9saXN0cy5pbmZyYWRlYWQub3JnL21haWxtYW4vbGlzdGluZm8vbGludXgt YXJtLWtlcm5lbAo=