From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7DA1AC433FE for ; Tue, 12 Oct 2021 12:09:42 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 373E061074 for ; Tue, 12 Oct 2021 12:09:42 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 373E061074 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=nongnu.org Received: from localhost ([::1]:33890 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1maGbF-00018T-8V for qemu-devel@archiver.kernel.org; Tue, 12 Oct 2021 08:09:41 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:44660) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1maGZd-0006vQ-RH for qemu-devel@nongnu.org; Tue, 12 Oct 2021 08:08:01 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]:46520) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1maGZY-0008EA-Mi for qemu-devel@nongnu.org; Tue, 12 Oct 2021 08:08:00 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1634040475; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=yJoHrWOdMzNSDrC+7PT+B6790NTPzUSt5busnVrspaM=; b=Wxe2n9Ef5NCbu9NSnVVRaIE6b2da7gZ0IYn/SbPGKdG+D5m6x45KpdAimgJC935oAlODjW L+loWuS8ywo6exUqxcN2kiHpSWShy0TqhftjvdsvhTR4IphGR2G3q1nwDPtCtzllrn92BV haWwaNxJRzIGyRtKSbHtsklM5F1dNf8= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-582-Vbm_xb6wOSifVRPRrVFlnA-1; Tue, 12 Oct 2021 08:06:26 -0400 X-MC-Unique: Vbm_xb6wOSifVRPRrVFlnA-1 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 12A65100CCC6; Tue, 12 Oct 2021 12:06:25 +0000 (UTC) Received: from blackfin.pond.sub.org (ovpn-112-14.ams2.redhat.com [10.36.112.14]) by smtp.corp.redhat.com (Postfix) with ESMTPS id B14281972D; Tue, 12 Oct 2021 12:06:24 +0000 (UTC) Received: by blackfin.pond.sub.org (Postfix, from userid 1000) id 39561113865F; Tue, 12 Oct 2021 14:06:23 +0200 (CEST) From: Markus Armbruster To: Kevin Wolf Subject: Re: [PATCH] qapi: Improve input_type_enum()'s error message References: <20211011131558.3273255-1-armbru@redhat.com> Date: Tue, 12 Oct 2021 14:06:23 +0200 In-Reply-To: (Kevin Wolf's message of "Tue, 12 Oct 2021 13:07:49 +0200") Message-ID: <87r1cq78hs.fsf@dusky.pond.sub.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=armbru@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain Received-SPF: pass client-ip=170.10.133.124; envelope-from=armbru@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -28 X-Spam_score: -2.9 X-Spam_bar: -- X-Spam_report: (-2.9 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.049, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: berrange@redhat.com, ehabkost@redhat.com, michael.roth@amd.com, qemu-devel@nongnu.org, hreitz@redhat.com, pbonzini@redhat.com Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" Kevin Wolf writes: > Am 11.10.2021 um 15:15 hat Markus Armbruster geschrieben: >> The error message claims the parameter is invalid: >> >> $ qemu-system-x86_64 -object qom-type=nonexistent >> qemu-system-x86_64: -object qom-type=nonexistent: Invalid parameter 'nonexistent' >> >> What's wrong is actually the *value* 'nonexistent'. Improve the >> message to >> >> qemu-system-x86_64: -object qom-type=nonexistent: Parameter 'qom-type' does not accept value 'nonexistent' >> >> Signed-off-by: Markus Armbruster >> --- >> qapi/qapi-visit-core.c | 3 ++- >> tests/unit/check-qom-proplist.c | 2 +- >> tests/qemu-iotests/049.out | 6 +++--- >> tests/qemu-iotests/206.out | 2 +- >> tests/qemu-iotests/237.out | 6 +++--- >> tests/qemu-iotests/245 | 2 +- > > Good that you remembered to update iotests cases. I'm afraid there are > two more that need an update. > > 287 contains these lines: > > output=$(_make_test_img -o 'compression_type=zstd' 64M; _cleanup_test_img) > if echo "$output" | grep -q "Invalid parameter 'zstd'"; then > _notrun "ZSTD is disabled" > fi > > Instead of skipping the test case when zstd support is not compiled in, > this test fails now. > > 308 contains a similar check for FUSE support and fails now when FUSE > support is disabled. 287 passes for me. I figure that's because I built with CONFIG_ZSTD. 308 I simply missed. Thanks for your help!