All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Alex Bennée" <alex.bennee@linaro.org>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: "Maydell, Peter" <peter.maydell@linaro.org>,
	Yonggang Luo <luoyonggang@gmail.com>,
	qemu-devel <qemu-devel@nongnu.org>
Subject: Re: [PATCH for 6.1] plugins: do not limit exported symbols if modules are active
Date: Thu, 12 Aug 2021 16:19:16 +0100	[thread overview]
Message-ID: <87r1eyznxd.fsf@linaro.org> (raw)
In-Reply-To: <CABgObfYW2acs4upbm7mjfhGhvK+sSLKNPC4LJUNQF9OGi8xM7g@mail.gmail.com>


Paolo Bonzini <pbonzini@redhat.com> writes:

> Il gio 12 ago 2021, 11:40 Alex Bennée <alex.bennee@linaro.org> ha scritto:
>
>    ERROR: glib-2.56 gmodule-noexport-2.0 is required to compile QEMU
>
>  Should it be gmodule-no-export? Hopefully the different distros aren't
>  packaging different .pc files.
>
> My bad. :( It's correct with the dash.

I've patched it locally and it's sitting in my PR branch:

  https://gitlab.com/stsquad/qemu/-/commits/pr/120821-for-6.1-rc4-1

but it looks like it will have to go via stable unless there is a more
compelling reason to cut an rc4.

>  Does this mean --enable-modules would allow plugins to access more of
>  the API space than we intended in the first place?
>
> Yes, but before it would do so even without --enable-modules due to
> using gmodule and not gmodule-no-export.

OK so it's better now. I wonder if this helps with the Windows usage of
modules?

  Subject: [PATCH v6 0/5] Enable plugin support on msys2/mingw
  Date: Tue, 13 Oct 2020 08:28:01 +0800
  Message-Id: <20201013002806.1447-1-luoyonggang@gmail.com>

I really want to avoid the hand hacking of Youngang's proposed changes
so was surprised that glib hadn't papered over the POSIX/Windows cracks.
However like MacOS I don't have easy access to a Windows developer
system to experiment with.

-- 
Alex Bennée


  reply	other threads:[~2021-08-12 15:25 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-08-11 10:05 [PATCH for 6.1] plugins: do not limit exported symbols if modules are active Paolo Bonzini
2021-08-12  9:36 ` Alex Bennée
2021-08-12 10:45   ` Paolo Bonzini
2021-08-12 15:19     ` Alex Bennée [this message]
  -- strict thread matches above, loose matches on Subject: below --
2021-08-11 10:05 Paolo Bonzini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87r1eyznxd.fsf@linaro.org \
    --to=alex.bennee@linaro.org \
    --cc=luoyonggang@gmail.com \
    --cc=pbonzini@redhat.com \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.