From: Kalle Valo <kvalo@codeaurora.org>
To: Dongliang Mu <mudongliangabcd@gmail.com>
Cc: ath9k-devel@qca.qualcomm.com,
"David S. Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>,
Brooke Basile <brookebasile@gmail.com>,
syzbot+6692c72009680f7c4eb2@syzkaller.appspotmail.com,
linux-wireless@vger.kernel.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ath9k: hif_usb: fix memory leak in ath9k_hif_usb_firmware_cb
Date: Tue, 27 Jul 2021 09:02:21 +0300 [thread overview]
Message-ID: <87r1fkguqa.fsf@codeaurora.org> (raw)
In-Reply-To: <20210709084351.2087311-1-mudongliangabcd@gmail.com> (Dongliang Mu's message of "Fri, 9 Jul 2021 16:43:51 +0800")
Dongliang Mu <mudongliangabcd@gmail.com> writes:
> The commit 03fb92a432ea ("ath9k: hif_usb: fix race condition between
> usb_get_urb() and usb_kill_anchored_urbs()") adds three usb_get_urb
> in ath9k_hif_usb_dealloc_tx_urbs and usb_free_urb.
>
> Fix this bug by adding corresponding usb_free_urb in
> ath9k_hif_usb_dealloc_tx_urbs other and hif_usb_stop.
>
> Reported-by: syzbot+6692c72009680f7c4eb2@syzkaller.appspotmail.com
> Fixes: 03fb92a432ea ("ath9k: hif_usb: fix race condition between usb_get_urb() and usb_kill_anchored_urbs()")
> Signed-off-by: Dongliang Mu <mudongliangabcd@gmail.com>
In the past there have been so many problems with ath9k syzbot fixes
that I have now a hard time trusting them. Can someone review this in
detail, please?
--
https://patchwork.kernel.org/project/linux-wireless/list/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
next prev parent reply other threads:[~2021-07-27 6:02 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-09 8:43 [PATCH] ath9k: hif_usb: fix memory leak in ath9k_hif_usb_firmware_cb Dongliang Mu
2021-07-23 10:12 ` Dongliang Mu
2021-07-27 6:02 ` Kalle Valo [this message]
2021-07-27 7:24 ` Julian Calaby
2021-07-27 12:26 ` Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87r1fkguqa.fsf@codeaurora.org \
--to=kvalo@codeaurora.org \
--cc=ath9k-devel@qca.qualcomm.com \
--cc=brookebasile@gmail.com \
--cc=davem@davemloft.net \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=mudongliangabcd@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=syzbot+6692c72009680f7c4eb2@syzkaller.appspotmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.