From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 90DDFC07E95 for ; Mon, 19 Jul 2021 14:41:09 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 4DAE36112D for ; Mon, 19 Jul 2021 14:41:09 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4DAE36112D Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=intel-gfx-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id DDD5E89C61; Mon, 19 Jul 2021 14:41:08 +0000 (UTC) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by gabe.freedesktop.org (Postfix) with ESMTPS id 4E38F89C61 for ; Mon, 19 Jul 2021 14:41:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1626705666; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=uisns9yt90kWM49tx27JUkXBcrqG48kz/iXIfY6XeUs=; b=Uuvl/dhFiX8LQBZkJdiU5nXqg0xdbarcFKAqxKb3t5UW+NXAx3I4/BIU7nitBQx+/c6FhG 6kjHsUwApCXHnVo0NGKvqBruzrJheegmrpzdWAMcM8iebrkI/npjnDJM3QyVrP3CKgWXMA YM24w94xN1Ciam/wz5QJO9eNIrfqQ6c= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-8-ORcvDXgKME68wDiU7fvhyg-1; Mon, 19 Jul 2021 10:41:03 -0400 X-MC-Unique: ORcvDXgKME68wDiU7fvhyg-1 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 5B6A0804140; Mon, 19 Jul 2021 14:40:58 +0000 (UTC) Received: from localhost (ovpn-112-158.ams2.redhat.com [10.36.112.158]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 9524960918; Mon, 19 Jul 2021 14:40:48 +0000 (UTC) From: Cornelia Huck To: Jason Gunthorpe , David Airlie , Tony Krowiak , Alex Williamson , Christian Borntraeger , Jonathan Corbet , Daniel Vetter , Diana Craciun , dri-devel@lists.freedesktop.org, Eric Auger , Eric Farman , Harald Freudenberger , Vasily Gorbik , Heiko Carstens , intel-gfx@lists.freedesktop.org, intel-gvt-dev@lists.freedesktop.org, Jani Nikula , Jason Herne , Joonas Lahtinen , kvm@vger.kernel.org, Kirti Wankhede , linux-doc@vger.kernel.org, linux-s390@vger.kernel.org, Matthew Rosato , Peter Oberparleiter , Halil Pasic , Rodrigo Vivi , Vineeth Vijayan , Zhenyu Wang , Zhi Wang In-Reply-To: <11-v1-eaf3ccbba33c+1add0-vfio_reflck_jgg@nvidia.com> Organization: Red Hat GmbH References: <11-v1-eaf3ccbba33c+1add0-vfio_reflck_jgg@nvidia.com> User-Agent: Notmuch/0.32.1 (https://notmuchmail.org) Date: Mon, 19 Jul 2021 16:40:47 +0200 Message-ID: <87r1fu9xjk.fsf@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 Subject: Re: [Intel-gfx] [PATCH 11/13] vfio/ap, ccw: Fix open/close when multiple device FDs are open X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Max Gurtovoy , Yishai Hadas , Leon Romanovsky , "Raj, Ashok" , Christoph Hellwig Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" On Wed, Jul 14 2021, Jason Gunthorpe wrote: > The user can open multiple device FDs if it likes, however these open() > functions call vfio_register_notifier() on some device global > state. Calling vfio_register_notifier() twice in will trigger a WARN_ON > from notifier_chain_register() and the first close will wrongly delete the > notifier and more. > > Since these really want the new open/close_device() semantics just change > the functions over. > > Signed-off-by: Jason Gunthorpe > --- > drivers/s390/cio/vfio_ccw_ops.c | 8 ++++---- > drivers/s390/crypto/vfio_ap_ops.c | 8 ++++---- > 2 files changed, 8 insertions(+), 8 deletions(-) Reviewed-by: Cornelia Huck _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 10BBCC07E9D for ; Mon, 19 Jul 2021 14:41:06 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id E058E6113A for ; Mon, 19 Jul 2021 14:41:05 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S240875AbhGSOAZ (ORCPT ); Mon, 19 Jul 2021 10:00:25 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]:53980 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S240754AbhGSOAZ (ORCPT ); Mon, 19 Jul 2021 10:00:25 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1626705664; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=uisns9yt90kWM49tx27JUkXBcrqG48kz/iXIfY6XeUs=; b=JrlQGXK+Kk5sLX++BbUukSdvpL1YEwDearbnWqz3ESdF+rWEDEpBqBCDdMpPquJE2dXz53 kcxb41N4yhIkrLjN+YNUSgl7JYPLvj4Qz3DJiQDvY3vovU7p28Chg03OMrx+cNMO0ZL0Xu OVsMC5Ggjc8DsAA6/eoFnxeY/1JgK7U= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-8-ORcvDXgKME68wDiU7fvhyg-1; Mon, 19 Jul 2021 10:41:03 -0400 X-MC-Unique: ORcvDXgKME68wDiU7fvhyg-1 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 5B6A0804140; Mon, 19 Jul 2021 14:40:58 +0000 (UTC) Received: from localhost (ovpn-112-158.ams2.redhat.com [10.36.112.158]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 9524960918; Mon, 19 Jul 2021 14:40:48 +0000 (UTC) From: Cornelia Huck To: Jason Gunthorpe , David Airlie , Tony Krowiak , Alex Williamson , Christian Borntraeger , Jonathan Corbet , Daniel Vetter , Diana Craciun , dri-devel@lists.freedesktop.org, Eric Auger , Eric Farman , Harald Freudenberger , Vasily Gorbik , Heiko Carstens , intel-gfx@lists.freedesktop.org, intel-gvt-dev@lists.freedesktop.org, Jani Nikula , Jason Herne , Joonas Lahtinen , kvm@vger.kernel.org, Kirti Wankhede , linux-doc@vger.kernel.org, linux-s390@vger.kernel.org, Matthew Rosato , Peter Oberparleiter , Halil Pasic , Rodrigo Vivi , Vineeth Vijayan , Zhenyu Wang , Zhi Wang Cc: "Raj, Ashok" , Christoph Hellwig , Leon Romanovsky , Max Gurtovoy , Yishai Hadas Subject: Re: [PATCH 11/13] vfio/ap,ccw: Fix open/close when multiple device FDs are open In-Reply-To: <11-v1-eaf3ccbba33c+1add0-vfio_reflck_jgg@nvidia.com> Organization: Red Hat GmbH References: <11-v1-eaf3ccbba33c+1add0-vfio_reflck_jgg@nvidia.com> User-Agent: Notmuch/0.32.1 (https://notmuchmail.org) Date: Mon, 19 Jul 2021 16:40:47 +0200 Message-ID: <87r1fu9xjk.fsf@redhat.com> MIME-Version: 1.0 Content-Type: text/plain X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 Precedence: bulk List-ID: X-Mailing-List: linux-doc@vger.kernel.org On Wed, Jul 14 2021, Jason Gunthorpe wrote: > The user can open multiple device FDs if it likes, however these open() > functions call vfio_register_notifier() on some device global > state. Calling vfio_register_notifier() twice in will trigger a WARN_ON > from notifier_chain_register() and the first close will wrongly delete the > notifier and more. > > Since these really want the new open/close_device() semantics just change > the functions over. > > Signed-off-by: Jason Gunthorpe > --- > drivers/s390/cio/vfio_ccw_ops.c | 8 ++++---- > drivers/s390/crypto/vfio_ap_ops.c | 8 ++++---- > 2 files changed, 8 insertions(+), 8 deletions(-) Reviewed-by: Cornelia Huck From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E16F8C12002 for ; Mon, 19 Jul 2021 14:41:06 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A8D416112D for ; Mon, 19 Jul 2021 14:41:06 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A8D416112D Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 3475A89C1C; Mon, 19 Jul 2021 14:41:06 +0000 (UTC) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by gabe.freedesktop.org (Postfix) with ESMTPS id 68B3E89C1C for ; Mon, 19 Jul 2021 14:41:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1626705664; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=uisns9yt90kWM49tx27JUkXBcrqG48kz/iXIfY6XeUs=; b=JrlQGXK+Kk5sLX++BbUukSdvpL1YEwDearbnWqz3ESdF+rWEDEpBqBCDdMpPquJE2dXz53 kcxb41N4yhIkrLjN+YNUSgl7JYPLvj4Qz3DJiQDvY3vovU7p28Chg03OMrx+cNMO0ZL0Xu OVsMC5Ggjc8DsAA6/eoFnxeY/1JgK7U= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-8-ORcvDXgKME68wDiU7fvhyg-1; Mon, 19 Jul 2021 10:41:03 -0400 X-MC-Unique: ORcvDXgKME68wDiU7fvhyg-1 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 5B6A0804140; Mon, 19 Jul 2021 14:40:58 +0000 (UTC) Received: from localhost (ovpn-112-158.ams2.redhat.com [10.36.112.158]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 9524960918; Mon, 19 Jul 2021 14:40:48 +0000 (UTC) From: Cornelia Huck To: Jason Gunthorpe , David Airlie , Tony Krowiak , Alex Williamson , Christian Borntraeger , Jonathan Corbet , Daniel Vetter , Diana Craciun , dri-devel@lists.freedesktop.org, Eric Auger , Eric Farman , Harald Freudenberger , Vasily Gorbik , Heiko Carstens , intel-gfx@lists.freedesktop.org, intel-gvt-dev@lists.freedesktop.org, Jani Nikula , Jason Herne , Joonas Lahtinen , kvm@vger.kernel.org, Kirti Wankhede , linux-doc@vger.kernel.org, linux-s390@vger.kernel.org, Matthew Rosato , Peter Oberparleiter , Halil Pasic , Rodrigo Vivi , Vineeth Vijayan , Zhenyu Wang , Zhi Wang Subject: Re: [PATCH 11/13] vfio/ap,ccw: Fix open/close when multiple device FDs are open In-Reply-To: <11-v1-eaf3ccbba33c+1add0-vfio_reflck_jgg@nvidia.com> Organization: Red Hat GmbH References: <11-v1-eaf3ccbba33c+1add0-vfio_reflck_jgg@nvidia.com> User-Agent: Notmuch/0.32.1 (https://notmuchmail.org) Date: Mon, 19 Jul 2021 16:40:47 +0200 Message-ID: <87r1fu9xjk.fsf@redhat.com> MIME-Version: 1.0 Content-Type: text/plain X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Max Gurtovoy , Yishai Hadas , Leon Romanovsky , "Raj, Ashok" , Christoph Hellwig Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Wed, Jul 14 2021, Jason Gunthorpe wrote: > The user can open multiple device FDs if it likes, however these open() > functions call vfio_register_notifier() on some device global > state. Calling vfio_register_notifier() twice in will trigger a WARN_ON > from notifier_chain_register() and the first close will wrongly delete the > notifier and more. > > Since these really want the new open/close_device() semantics just change > the functions over. > > Signed-off-by: Jason Gunthorpe > --- > drivers/s390/cio/vfio_ccw_ops.c | 8 ++++---- > drivers/s390/crypto/vfio_ap_ops.c | 8 ++++---- > 2 files changed, 8 insertions(+), 8 deletions(-) Reviewed-by: Cornelia Huck