From: "Aurélien Aptel" <aaptel@suse.com>
To: Steve French <smfrench@gmail.com>,
Shyam Prasad N <nspmangalore@gmail.com>
Cc: CIFS <linux-cifs@vger.kernel.org>
Subject: Re: 2 error cases in sid_to_id are ignored
Date: Tue, 22 Jun 2021 12:18:18 +0200 [thread overview]
Message-ID: <87r1guqk2d.fsf@suse.com> (raw)
In-Reply-To: <CAH2r5mu4uEOP4r-KnF+bZGqPjdRwkaZanD1sE_JHuoK=jB_nnA@mail.gmail.com>
Steve French <smfrench@gmail.com> writes:
> Any thoughts on whether it would be better to return the errors, or
> continue the current strategy of simply using the default uid/gid for
> the mount and returning 0 (and removing the two places above where we
> set rc to non zero values, since rc will be overwritten with 0)?
My opinion: I think best-effort would be better, so returning things as
default uid/gid (or possibly root).
Cheers,
--
Aurélien Aptel / SUSE Labs Samba Team
GPG: 1839 CB5F 9F5B FB9B AA97 8C99 03C8 A49B 521B D5D3
SUSE Software Solutions Germany GmbH, Maxfeldstr. 5, 90409 Nürnberg, DE
GF: Felix Imendörffer, Mary Higgins, Sri Rasiah HRB 247165 (AG München)
next prev parent reply other threads:[~2021-06-22 10:18 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-21 20:57 2 error cases in sid_to_id are ignored Steve French
2021-06-22 10:18 ` Aurélien Aptel [this message]
2021-06-22 19:05 ` Steve French
2021-06-22 19:16 ` Steve French
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87r1guqk2d.fsf@suse.com \
--to=aaptel@suse.com \
--cc=linux-cifs@vger.kernel.org \
--cc=nspmangalore@gmail.com \
--cc=smfrench@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.