From: Felipe Balbi <balbi@kernel.org>
To: Michael Grzeschik <m.grzeschik@pengutronix.de>,
linux-usb@vger.kernel.org
Cc: Thinh.Nguyen@synopsys.com, kernel@pengutronix.de
Subject: Re: [PATCH 1/2] dwc3: gadget: fix setting of pending_sgs
Date: Thu, 22 Apr 2021 13:51:38 +0300 [thread overview]
Message-ID: <87r1j2mw1x.fsf@kernel.org> (raw)
In-Reply-To: <20210421204837.4185-2-m.grzeschik@pengutronix.de>
[-- Attachment #1: Type: text/plain, Size: 727 bytes --]
Hi,
(subject format, please prepend 'usb:')
Michael Grzeschik <m.grzeschik@pengutronix.de> writes:
> In the dwc3_prepare_trbs_sg routine, when all data from request was
> handled pending_sgs should be set to the number of mapped sgs that are
^^
,
> not queued up.
>
> Currently the code will result in pending_sgs == queued_sgs. That
> variables value will likely not be zero and break dwc3_prepare_trbs.
^^^^^^^^^
variable's
you say it's 'likely'. Got any minimal reproduction method?
> This patch fixes the setting of the variable to its intended purpose.
>
> Signed-off-by: Michael Grzeschik <m.grzeschik@pengutronix.de>
please add Fixes tag and Cc stable
--
balbi
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 857 bytes --]
next prev parent reply other threads:[~2021-04-22 10:51 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-21 20:48 [PATCH 0/2] usb: dwc3: gadget: fix scatter gather support Michael Grzeschik
2021-04-21 20:48 ` [PATCH 1/2] dwc3: gadget: fix setting of pending_sgs Michael Grzeschik
2021-04-22 10:51 ` Felipe Balbi [this message]
2021-04-22 21:28 ` Thinh Nguyen
2021-04-21 20:48 ` [PATCH 2/2] dwc3: gadget: fix tracking of used sgs in request Michael Grzeschik
2021-04-22 10:56 ` Felipe Balbi
2021-04-22 20:18 ` Michael Grzeschik
2021-04-22 21:28 ` Thinh Nguyen
2021-04-23 6:17 ` Felipe Balbi
[not found] ` <20210423102738.GD6975@pengutronix.de>
2021-04-23 11:15 ` Felipe Balbi
2021-04-23 13:18 ` Michael Grzeschik
2021-04-24 8:16 ` Felipe Balbi
2021-04-24 9:12 ` Michael Grzeschik
2021-04-24 13:43 ` Felipe Balbi
2021-04-24 19:41 ` Thinh Nguyen
2021-04-27 3:18 ` Thinh Nguyen
2021-04-27 20:12 ` Michael Grzeschik
2021-04-28 1:45 ` Thinh Nguyen
2021-04-28 7:37 ` Michael Grzeschik
2021-04-28 23:25 ` Thinh Nguyen
2021-04-29 6:51 ` Michael Grzeschik
2021-04-29 18:15 ` Thinh Nguyen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87r1j2mw1x.fsf@kernel.org \
--to=balbi@kernel.org \
--cc=Thinh.Nguyen@synopsys.com \
--cc=kernel@pengutronix.de \
--cc=linux-usb@vger.kernel.org \
--cc=m.grzeschik@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.