All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Ævar Arnfjörð Bjarmason" <avarab@gmail.com>
To: Bagas Sanjaya <bagasdotme@gmail.com>
Cc: Junio C Hamano <gitster@pobox.com>, Git Users <git@vger.kernel.org>
Subject: Re: [PATCH] CodingGuidelines: remove suggestion to write commands in Perl/SH
Date: Sat, 17 Apr 2021 14:36:00 +0200	[thread overview]
Message-ID: <87r1j91427.fsf@evledraar.gmail.com> (raw)
In-Reply-To: <bcc64c2d-3469-38ab-3234-fa8984a3d0f9@gmail.com>


On Sat, Apr 17 2021, Bagas Sanjaya wrote:

> On 17/04/21 15.43, Ævar Arnfjörð Bjarmason wrote:
>> Since then the consensus changed to having no new such commands unless
>> necessary, and existing ones have been actively migrated to C.
>
> What I implied that when we need to implement new commands, it must
> be directly written in C (steeper learning curve and more tedious
> than implemented in shell script), so I'm against this proposal.

I updated the v2 of this to note that I'm not really proposing anything
new, but just bringing the document in line with reality. For a long
time now we've rejected any new non-C things being imported into the
tree, unless those that fall under the "such as an importer to convert
random-scm-X" language that's still retained in the CodingGuidelines.

I think that even if you or someone else wanted to write a new thing in
Perl or SH we'd want a new way of doing that now anyway,
e.g. git-send-email.perl should really be a helper for a C program
rather than a stand-alone thing.

I.e. even if the main logic is still in the *.perl that code would
really benefit from first doing the command-line parsing etc. in C, so
that it would behave the same as everything else in that regard, ditto
for its config parsing.


  reply	other threads:[~2021-04-17 12:36 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-04-17  8:43 [PATCH] CodingGuidelines: remove suggestion to write commands in Perl/SH Ævar Arnfjörð Bjarmason
2021-04-17  8:53 ` Torsten Bögershausen
2021-04-17 12:17 ` Bagas Sanjaya
2021-04-17 12:36   ` Ævar Arnfjörð Bjarmason [this message]
2021-04-17 20:28     ` brian m. carlson
2021-04-17 21:37       ` Ævar Arnfjörð Bjarmason
2021-04-17 22:10         ` brian m. carlson
2021-04-17 12:31 ` [PATCH v2] " Ævar Arnfjörð Bjarmason
2021-04-17 22:01 ` [PATCH] " Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87r1j91427.fsf@evledraar.gmail.com \
    --to=avarab@gmail.com \
    --cc=bagasdotme@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.