From: Kalle Valo <kvalo@codeaurora.org>
To: Pkshih <pkshih@realtek.com>
Cc: "tony0620emma\@gmail.com" <tony0620emma@gmail.com>,
"linux-wireless\@vger.kernel.org"
<linux-wireless@vger.kernel.org>, DeanKu <ku920601@realtek.com>,
Bernie Huang <phhuang@realtek.com>, Shaofu <shaofu@realtek.com>,
Steven Ting <steventing@realtek.com>,
Kevin Yang <kevin_yang@realtek.com>
Subject: Re: [PATCH 2/7] rtw88: follow the AP basic rates for tx mgmt frame
Date: Mon, 12 Apr 2021 14:46:50 +0300 [thread overview]
Message-ID: <87r1jflo7p.fsf@codeaurora.org> (raw)
In-Reply-To: <632d2ab7679145eab8e1f498b9b12ceb@realtek.com> (pkshih@realtek.com's message of "Mon, 12 Apr 2021 08:11:05 +0000")
Pkshih <pkshih@realtek.com> writes:
>> -----Original Message-----
>> From: kvalo=codeaurora.org@mg.codeaurora.org
>> [mailto:kvalo=codeaurora.org@mg.codeaurora.org] On
>> Behalf Of Kalle Valo
>> Sent: Sunday, April 11, 2021 5:21 PM
>> To: Pkshih
>> Cc: tony0620emma@gmail.com; linux-wireless@vger.kernel.org; DeanKu;
>> Bernie Huang; Shaofu; Steven Ting;
>> Kevin Yang
>> Subject: Re: [PATCH 2/7] rtw88: follow the AP basic rates for tx mgmt frame
>>
>> Ping-Ke Shih <pkshih@realtek.com> wrote:
>>
>> > From: Shao-Fu Cheng <shaofu@realtek.com>
>> >
>> > By default the driver uses the 1M and 6M rate for managemnt frames
>> > in 2G and 5G bands respectively. But when the basic rates is configured
>> > from the mac80211, we need to send the management frames according the
>> > basic rates.
>> >
>> > This commit makes the driver use the lowest basic rates to send
>> > the management frames and a debufs entry to enable/disable force to use
>> > the lowest rate 1M/6M for 2.4G/5G bands.
>> >
>> > obtain current setting
>> > cat /sys/kernel/debug/ieee80211/phyX/rtw88/basic_rates
>> >
>> > force lowest rate:
>> > echo 1 > /sys/kernel/debug/ieee80211/phyX/rtw88/basic_rates
>> >
>> > Signed-off-by: Shao-Fu Cheng <shaofu@realtek.com>
>> > Signed-off-by: Yu-Yen Ting <steventing@realtek.com>
>> > Signed-off-by: Ping-Ke Shih <pkshih@realtek.com>
>>
>> Why is a debugfs interface needed?
>>
>
> By default, driver follows AP's basic rates that may be 24M and above, and
> does association with 24M rate. If AP is far away, it may be hard to communicate
> with 24M rate. Therefore, we add a debugfs to allow driver to send management
> frames with low rate 6M or 1M.
debugfs is for R&D level testing and debugging, not normal user
configuration. To me it looks like something like that should be in
nl80211.
--
https://patchwork.kernel.org/project/linux-wireless/list/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
next prev parent reply other threads:[~2021-04-12 11:47 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-19 5:42 [PATCH 0/7] rtw88: add some fixes and 8822c features Ping-Ke Shih
2021-03-19 5:42 ` [PATCH 1/7] rtw88: add flush hci support Ping-Ke Shih
2021-04-11 9:24 ` Kalle Valo
2021-03-19 5:42 ` [PATCH 2/7] rtw88: follow the AP basic rates for tx mgmt frame Ping-Ke Shih
2021-04-11 9:21 ` Kalle Valo
2021-04-12 8:11 ` Pkshih
2021-04-12 11:46 ` Kalle Valo [this message]
2021-04-15 4:05 ` Pkshih
2021-04-22 3:27 ` Pkshih
2021-05-19 5:59 ` Pkshih
2021-03-19 5:42 ` [PATCH 3/7] rtw88: fix DIG min setting Ping-Ke Shih
2021-03-19 5:42 ` [PATCH 4/7] rtw88: 8822c: update tx power limit table to RF v40.1 Ping-Ke Shih
2021-04-11 9:25 ` Kalle Valo
2021-03-19 5:42 ` [PATCH 5/7] rtw88: 8822c: add LC calibration for RTL8822C Ping-Ke Shih
2021-04-11 9:27 ` Kalle Valo
2021-03-19 5:42 ` [PATCH 6/7] rtw88: 8822c: add CFO tracking Ping-Ke Shih
2021-04-11 9:19 ` Kalle Valo
2021-04-12 8:11 ` Pkshih
2021-04-12 11:47 ` Kalle Valo
2021-04-15 5:02 ` Pkshih
2021-03-19 5:42 ` [PATCH 7/7] rtw88: coex: fix A2DP stutters while WL busy + WL scan Ping-Ke Shih
2021-04-11 9:28 ` Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87r1jflo7p.fsf@codeaurora.org \
--to=kvalo@codeaurora.org \
--cc=kevin_yang@realtek.com \
--cc=ku920601@realtek.com \
--cc=linux-wireless@vger.kernel.org \
--cc=phhuang@realtek.com \
--cc=pkshih@realtek.com \
--cc=shaofu@realtek.com \
--cc=steventing@realtek.com \
--cc=tony0620emma@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.