From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BB7C2C433E0 for ; Thu, 4 Mar 2021 08:33:22 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 8861F64E41 for ; Thu, 4 Mar 2021 08:33:22 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8861F64E41 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=intel-gfx-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 396596E49F; Thu, 4 Mar 2021 08:33:22 +0000 (UTC) Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by gabe.freedesktop.org (Postfix) with ESMTPS id D09716EA01 for ; Thu, 4 Mar 2021 08:33:20 +0000 (UTC) IronPort-SDR: JlhXF7Z2f6VqTQWqu0ufb70v+obpeg7aSVxoWVw3axq+JAWOIVkaJrSLxEvtWUbXPJXQhEdgWP wWXfvCXNI7ag== X-IronPort-AV: E=McAfee;i="6000,8403,9912"; a="167269245" X-IronPort-AV: E=Sophos;i="5.81,222,1610438400"; d="scan'208";a="167269245" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 04 Mar 2021 00:33:19 -0800 IronPort-SDR: ga70ziVcAP0b+oWpVvMVRQ2i9HIEpvxb3w5cEz6TnkrbQhndrVr0LTofzTgeLUtETtvPQ3nkLE yUazx1k4qHng== X-IronPort-AV: E=Sophos;i="5.81,222,1610438400"; d="scan'208";a="407675510" Received: from kinzelba-mobl.ger.corp.intel.com (HELO localhost) ([10.252.44.66]) by orsmga008-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 04 Mar 2021 00:33:15 -0800 From: Jani Nikula To: "Shankar\, Uma" , "intel-gfx\@lists.freedesktop.org" In-Reply-To: <9fc4a8dd74894b9fb18282223193d362@intel.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo References: <95cbe1c9d45edf3e3ec252e49fb49055def98155.1614682842.git.jani.nikula@intel.com> <9fc4a8dd74894b9fb18282223193d362@intel.com> Date: Thu, 04 Mar 2021 10:33:11 +0200 Message-ID: <87r1kvnws8.fsf@intel.com> MIME-Version: 1.0 Subject: Re: [Intel-gfx] [PATCH v4 1/4] drm/i915/mso: add splitter state readout for platforms that support it X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "Varide, Nischal" Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" On Wed, 03 Mar 2021, "Shankar, Uma" wrote: > Looks Good to me. > Reviewed-by: Uma Shankar Thanks for the review, pushed the series. >> diff --git a/drivers/gpu/drm/i915/display/intel_display_types.h >> b/drivers/gpu/drm/i915/display/intel_display_types.h >> index 1a76e1d9de7a..9f1945018712 100644 >> --- a/drivers/gpu/drm/i915/display/intel_display_types.h >> +++ b/drivers/gpu/drm/i915/display/intel_display_types.h >> @@ -1166,6 +1166,13 @@ struct intel_crtc_state { >> u8 pipeline_full; >> u16 flipline, vmin, vmax; >> } vrr; >> + >> + /* Stream Splitter for eDP MSO */ >> + struct { >> + bool enable; >> + u8 link_count; >> + u8 pixel_overlap; >> + } splitter; >> }; Due to certain amount of urgency, I decided to push the series with this naming in crtc state. I think it's accurate now, and workable for legacy DSI as well. However, I'm not hung up on it, and I'm open to renaming when the time comes to convert legacy DSI to using crtc state for this stuff. BR, Jani. -- Jani Nikula, Intel Open Source Graphics Center _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx