From: Felipe Balbi <balbi@kernel.org>
To: Lorenzo Colitti <lorenzo@google.com>,
linux-usb@vger.kernel.org, gregkh@linuxfoundation.org
Cc: zenczykowski@gmail.com, Lorenzo Colitti <lorenzo@google.com>
Subject: Re: [PATCH] usb: gadget: u_ether: support configuring interface names.
Date: Wed, 13 Jan 2021 16:09:26 +0200 [thread overview]
Message-ID: <87r1mp2ajt.fsf@kernel.org> (raw)
In-Reply-To: <20210113140331.73500-1-lorenzo@google.com>
[-- Attachment #1: Type: text/plain, Size: 605 bytes --]
Hi,
Lorenzo Colitti <lorenzo@google.com> writes:
> diff --git a/drivers/usb/gadget/function/u_ether.c b/drivers/usb/gadget/function/u_ether.c
> index c019f2b0c0af..6527d169ae7c 100644
> --- a/drivers/usb/gadget/function/u_ether.c
> +++ b/drivers/usb/gadget/function/u_ether.c
> @@ -78,8 +78,9 @@ struct eth_dev {
> unsigned long todo;
> #define WORK_RX_MEMORY 0
>
> - bool zlp;
> - bool no_skb_reserve;
> + bool zlp:1,
> + no_skb_reserve:1,
> + ifname_set:1;
let's keep one declaration per line, as it was before. Other than that,
patch looks good.
--
balbi
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 857 bytes --]
next prev parent reply other threads:[~2021-01-13 14:10 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-13 14:03 [PATCH] usb: gadget: u_ether: support configuring interface names Lorenzo Colitti
2021-01-13 14:09 ` Felipe Balbi [this message]
2021-01-13 15:48 ` Lorenzo Colitti
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87r1mp2ajt.fsf@kernel.org \
--to=balbi@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-usb@vger.kernel.org \
--cc=lorenzo@google.com \
--cc=zenczykowski@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.