From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5F1D4C43457 for ; Mon, 12 Oct 2020 09:50:30 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id EA68F208D5 for ; Mon, 12 Oct 2020 09:50:29 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=suse.com header.i=@suse.com header.b="Z5k4XGUS" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729458AbgJLJu3 (ORCPT ); Mon, 12 Oct 2020 05:50:29 -0400 Received: from mx2.suse.de ([195.135.220.15]:45902 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726104AbgJLJu1 (ORCPT ); Mon, 12 Oct 2020 05:50:27 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1602496225; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=znID3Yp0OfR3dmXjA/b3uU1xhv9pYAA6FAm5lFz4kww=; b=Z5k4XGUSGqc2F1wrXMswb8PEkChTI+eFnBFLZhqWA2EXfKz8iFrT/StKBXQzf+ZHJDi4VM q8/AJR4rKxfZkYTd+JZoR+DGRl6CvPz2rBrFaTlzg2XE9pa87S8CXvU6v+7YdPZ3qZbb4w OVyLcgrfb8YHKnFJi8/cXNE/NopFOEI= Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id B766DADA8; Mon, 12 Oct 2020 09:50:25 +0000 (UTC) From: =?utf-8?Q?Aur=C3=A9lien?= Aptel To: Stefan Metzmacher , Steve French , CIFS Cc: samba-technical Subject: Re: [PATCH][SMB3.1.1] Add defines for new signing context In-Reply-To: References: Date: Mon, 12 Oct 2020 11:50:24 +0200 Message-ID: <87r1q3hixr.fsf@suse.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-cifs@vger.kernel.org Patch LGTM Reviewed-by: Aurelien Aptel Stefan Metzmacher via samba-technical > This isn't in MS-SMB2 yet. > > Is this AES_128? This is returned in latest Windows Server Insider builds but it's not documented yet. https://www.microsoft.com/en-us/software-download/windowsinsiderpreviewserv= er I've asked dochelp about it during the SDC plugfest and they gave me this: The new ContextType is: SMB2_SIGNING_CAPABILITIES 0x0008 The Data field contains a list of signing algorithms. =E2=80=A2 It adds a new negotiate context, which enables SMB to deco= uple signing algorithms from dialects. E.g. if both client and server suppo= rts it, a session may use HMAC-SHA256 with SMB 3.1.1. =E2=80=A2 It adds the AES-GMAC algorithm. =20=20=20=20=20 SigningAlgorithmCount (2 bytes): Count of signing algorithms SigningAlgorithms (variable): An array of SigningAlgorithmCount 16-bit = integer IDs specifying the supported signing algorithms. =20=20=20=20=20 The following IDs are assigned:=20 0 =3D HMAC-SHA256 1 =3D AES-CMAC 2 =3D AES-GMAC I've been CCed in a Microsoft email thread later on and it seems to be unclear why this was missed/wasn't documented. Maybe this is subject to change so take with a grain of salt. Cheers, --=20 Aur=C3=A9lien Aptel / SUSE Labs Samba Team GPG: 1839 CB5F 9F5B FB9B AA97 8C99 03C8 A49B 521B D5D3 SUSE Software Solutions Germany GmbH, Maxfeldstr. 5, 90409 N=C3=BCrnberg, DE GF: Felix Imend=C3=B6rffer, Mary Higgins, Sri Rasiah HRB 247165 (AG M=C3=BC= nchen)