All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Gleixner <tglx@linutronix.de>
To: Tom Hromatka <tom.hromatka@oracle.com>,
	tom.hromatka@oracle.com, linux-kernel@vger.kernel.org,
	linux-fsdevel@vger.kernel.org, fweisbec@gmail.com,
	mingo@kernel.org, adobriyan@gmail.com
Subject: Re: [PATCH v2 1/2] tick-sched: Do not clear the iowait and idle times
Date: Thu, 24 Sep 2020 22:41:47 +0200	[thread overview]
Message-ID: <87r1qq7vqs.fsf@nanos.tec.linutronix.de> (raw)
In-Reply-To: <20200915193627.85423-2-tom.hromatka@oracle.com>

On Tue, Sep 15 2020 at 13:36, Tom Hromatka wrote:
> Prior to this commit, the cpu idle and iowait data in /proc/stat were
> cleared when a CPU goes down.  When the CPU came back online, both idle
> and iowait times were restarted from 0.

Starting a commit message with 'Prior to this commit' is
pointless. Describe the factual problem which made you come up with this
change.

>
> This commit preserves the CPU's idle and iowait values when a CPU goes
> offline and comes back online.

'This commit does' is just a variation of 'This patch does'.

git grep 'This patch' Documentation/process/

Thanks,

        tglx

  reply	other threads:[~2020-09-24 20:41 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-09-15 19:36 [PATCH v2 0/2] iowait and idle fixes in /proc/stat Tom Hromatka
2020-09-15 19:36 ` [PATCH v2 1/2] tick-sched: Do not clear the iowait and idle times Tom Hromatka
2020-09-24 20:41   ` Thomas Gleixner [this message]
2020-09-15 19:36 ` [PATCH v2 2/2] /proc/stat: Simplify iowait and idle calculations when cpu is offline Tom Hromatka
2020-09-24 21:19   ` Thomas Gleixner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87r1qq7vqs.fsf@nanos.tec.linutronix.de \
    --to=tglx@linutronix.de \
    --cc=adobriyan@gmail.com \
    --cc=fweisbec@gmail.com \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@kernel.org \
    --cc=tom.hromatka@oracle.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.